[Lldb-commits] [PATCH] D149692: Allow scripted thread plans to modify the stop reason shown when the plan completes

delcypher added inline comments. Comment at: lldb/examples/python/scripted_step.py:130 +def stop_description(self, stream): +stream.Print("Simple step completed") @jingham Thanks for implementing this. Is there a reason why the interface needs to a

[Lldb-commits] [PATCH] D149692: Allow scripted thread plans to modify the stop reason shown when the plan completes

jingham added a comment. Committed as: c2be702104284cb3facf31124494b9a400296179 . I forgot to put the differential revision cookie in the commit message... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION ht

[Lldb-commits] [PATCH] D149692: Allow scripted thread plans to modify the stop reason shown when the plan completes

mib accepted this revision. mib added a comment. This revision is now accepted and ready to land. Alright Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149692/new/ https://reviews.llvm.org/D149692 ___ ll

[Lldb-commits] [PATCH] D149692: Allow scripted thread plans to modify the stop reason shown when the plan completes

jingham added a comment. In D149692#4313715 , @mib wrote: > This looks good to me, although I'm wondering whether instead of passing a > string, we should pass a dictionary. This way the user could either fill the > dictionary with a simple stop reason

[Lldb-commits] [PATCH] D149692: Allow scripted thread plans to modify the stop reason shown when the plan completes

jingham marked an inline comment as done. jingham added inline comments. Comment at: lldb/bindings/python/python-wrapper.swig:390 + if (PyErr_Occurred()) { +printf("Error occured for call to %s.\n", + method_name); mib wrote: > If we passed a `Stat

[Lldb-commits] [PATCH] D149692: Allow scripted thread plans to modify the stop reason shown when the plan completes

jingham updated this revision to Diff 518878. jingham added a comment. Address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149692/new/ https://reviews.llvm.org/D149692 Files: lldb/bindings/python/python-wrapper.swig lldb/exa

[Lldb-commits] [PATCH] D149692: Allow scripted thread plans to modify the stop reason shown when the plan completes

mib added a comment. This looks good to me, although I'm wondering whether instead of passing a string, we should pass a dictionary. This way the user could either fill the dictionary with a simple stop reason description or the MachException data What do you think Jim ? Com

[Lldb-commits] [PATCH] D149692: Allow scripted thread plans to modify the stop reason shown when the plan completes

jingham created this revision. jingham added reviewers: JDevlieghere, delcypher, mib. Herald added a project: All. jingham requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. We were just printing some fairly ugly boiler plate, for instance: (