kparzysz added a comment.
It works now. Thanks!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D150624/new/
https://reviews.llvm.org/D150624
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https
JDevlieghere added a comment.
I have enabled Lua testing on the incremental bot on GreenDragon
(https://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/). This has always
been the intention (note how the job mentions "Python 3 and Lua 5.3") but
wasn't enabled until earlier today.
Repository
This revision was automatically updated to reflect the committed changes.
Closed by commit rG692ae97ae71d: [lldb] Fix lua build after 27b6a4e63afe
(authored by bulbazord).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D150624/new/
https://reviews.llv
mib accepted this revision.
mib added a comment.
This revision is now accepted and ready to land.
Let's fix the Lua build failures first
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D150624/new/
https://reviews.llvm.org/D150624
___
bulbazord requested review of this revision.
bulbazord added a comment.
So, I agree that we should definitely unify this or else we end up doing this
for **every** scripting language that we add support for. That being said, I
think this is actually better than what we had before because now we'
mib requested changes to this revision.
mib added a comment.
This revision now requires changes to proceed.
We've already discussed that offline but I really think there should be a
ScriptInterpreter `SWIGBridge` plugin and that would have all the method the
Python and Lua SWIGBridge have in com
bulbazord created this revision.
bulbazord added reviewers: kparzysz, JDevlieghere, mib.
Herald added a project: All.
bulbazord requested review of this revision.
Herald added a project: LLDB.
Herald added a subscriber: lldb-commits.
This applies the same trick for Lua that I did for python in
27b
