krytarowski added a comment.
In http://reviews.llvm.org/D15067#419964, @labath wrote:
> Good question. I don't really have an opinion on that... Is it just that
> single line? (this would be simpler if you uploaded the final version :) ).
> If it just that single line, then I think it's fine. I
labath added a comment.
Good question. I don't really have an opinion on that... Is it just that single
line? (this would be simpler if you uploaded the final version :) ). If it just
that single line, then I think it's fine. If you also need to play with the
ADDITIONAL_VERSIONS and such, then
krytarowski added a comment.
In http://reviews.llvm.org/D15067#419632, @labath wrote:
> Looks good.
Thanks!
Are you accepting it with the patch in `scripts/CMakeLists.txt` as noted in the
comment?
Repository:
rL LLVM
http://reviews.llvm.org/D15067
_
labath accepted this revision.
labath added a comment.
Looks good.
Repository:
rL LLVM
http://reviews.llvm.org/D15067
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
krytarowski added inline comments.
Comment at: cmake/modules/LLDBStandalone.cmake:85
@@ -63,3 +84,3 @@
if (PYTHON_EXECUTABLE STREQUAL "")
set(Python_ADDITIONAL_VERSIONS 3.5 3.4 3.3 3.2 3.1 3.0 2.7 2.6 2.5)
When I am including conditionally `include(FindP
krytarowski added a comment.
please take a look @zturner @labath
Repository:
rL LLVM
http://reviews.llvm.org/D15067
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
krytarowski updated this revision to Diff 55742.
krytarowski added a comment.
Revamp the patch and reduce it only to the CMake part.
Leave regex code for later.
Repository:
rL LLVM
http://reviews.llvm.org/D15067
Files:
cmake/modules/LLDBStandalone.cmake
Index: cmake/modules/LLDBStandalon
labath resigned from this revision.
labath removed a reviewer: labath.
labath added a comment.
I am cleaning out my review queue. Feel free to add me back when you want to
get this moving again...
Repository:
rL LLVM
http://reviews.llvm.org/D15067
_
krytarowski added a comment.
Just in case someone will be quicker, new version against revamped CMake dirs
is in pkgsrc-wip/lldb-git
Repository:
rL LLVM
http://reviews.llvm.org/D15067
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
htt
krytarowski added a comment.
For the reference, I hold on with pushing this forward, till I will get
significantly larger coverage with tests on my platform.
I keep this patch locally for local development.
Repository:
rL LLVM
http://reviews.llvm.org/D15067
__
Eugene.Zelenko added a comment.
In http://reviews.llvm.org/D15067#299220, @labath wrote:
> In http://reviews.llvm.org/D15067#298902, @Eugene.Zelenko wrote:
>
> > But it's necessary to pass path from CMake command line argument to
> > find_program after PATHS. Another problem if default OS locati
labath added a comment.
In http://reviews.llvm.org/D15067#298902, @Eugene.Zelenko wrote:
> But it's necessary to pass path from CMake command line argument to
> find_program after PATHS. Another problem if default OS location (if Clang
> installed and of old version) will be returned instead of
Eugene.Zelenko added a comment.
In http://reviews.llvm.org/D15067#298830, @krytarowski wrote:
> In http://reviews.llvm.org/D15067#298701, @Eugene.Zelenko wrote:
>
> > I build LLVM/Clang with LLVM_ENABLE_WARNINGS=ON, so I'll need to use
> > llvm-config from build directory. I'm not sure how well
krytarowski added a comment.
In http://reviews.llvm.org/D15067#298701, @Eugene.Zelenko wrote:
> I build LLVM/Clang with LLVM_ENABLE_WARNINGS=ON, so I'll need to use
> llvm-config from build directory. I'm not sure how well find_program will
> work if path to /bin will be not added to PATH, so p
Eugene.Zelenko added a comment.
I build LLVM/Clang with LLVM_ENABLE_WARNINGS=ON, so I'll need to use
llvm-config from build directory. I'm not sure how well find_program will work
if path to /bin will be not added to PATH, so probably will be
good idea to allow LLVM_CONFIG to be set in Cmake co
labath requested changes to this revision.
labath added a comment.
OK, llvm seems to export the regex interface via include/llvm/Support/Regex.h.
I think we should fix lldb-mi to use this interface instead, and then our
problem will go away. The MI wrapper seems to be very simple, so it should n
zturner added a comment.
lldb-mi is including from the source tree, it should be including from the
incldue tree.
In other words, the incldue should be changed to:
#include "llvm/Support/Regex.h"
and the code should be updated to use `llvm::Regex` instead of the raw c
functions.
Repositor
labath added a comment.
Hmm.. you are right, of course.. I was only looking at the second version of
the patch, which seems to omit the regex files. However that seems to by
accidental, as they are still references in the CMake files.
I agree that we should not copy the files over.
@krytarowsk
zturner added a subscriber: zturner.
zturner requested changes to this revision.
zturner added a reviewer: zturner.
zturner added a comment.
This revision now requires changes to proceed.
@labath, can you point out where clang is doing the same thing? I searched for
files named `regcomp.c` for e
labath added subscribers: artagnon, Eugene.Zelenko, tfiala.
labath added a comment.
It seems to follow what clang does here, so I think it should be ok.
However, I'm not actually using the standalone build... I've added some people
who I think might be using it. Let's give them a bit of time to
krytarowski updated this revision to Diff 41366.
krytarowski added a comment.
Upload the proper latest patch.
Repository:
rL LLVM
http://reviews.llvm.org/D15067
Files:
cmake/modules/LLDBStandalone.cmake
scripts/CMakeLists.txt
source/Utility/CMakeLists.txt
tools/lldb-mi/MIUtilParse.h
krytarowski added a comment.
@labath feel free to disagree with the regex files. It was copied from LLVM. If
you disagree, help me please to export it in LLVM build for everybody or find a
better solution.
pkgsrc-wip commit affirming that it works:
https://wip.pkgsrc.org/cgi-bin/gitweb.cgi?p=pk
22 matches
Mail list logo
