[Lldb-commits] [PATCH] D151269: [lldb] Pass CMAKE_SYSROOT through to lldb tests

2023-05-24 Thread Daniel Thornburgh via Phabricator via lldb-commits
mysterymath updated this revision to Diff 525282. mysterymath added a comment. Restrict description to Shell tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151269/new/ https://reviews.llvm.org/D151269 Files: lldb/test/Shell/helper/build.py

[Lldb-commits] [PATCH] D151269: [lldb] Pass CMAKE_SYSROOT through to lldb tests

2023-05-24 Thread Daniel Thornburgh via Phabricator via lldb-commits
mysterymath added a comment. In D151269#4366484 , @JDevlieghere wrote: > The change itself looks fine, but isn't this an issue for the API tests too? > If so, how is the sys root passed to `dotest.py` and can the shell tests do > the same? Ah, thanks

[Lldb-commits] [PATCH] D151269: [lldb] Pass CMAKE_SYSROOT through to lldb tests

2023-05-23 Thread Jonas Devlieghere via Phabricator via lldb-commits
JDevlieghere added a comment. The change itself looks fine, but isn't this an issue for the API tests too? If so, how is the sys root passed to `dotest.py` and can the shell tests do the same? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151269/n