[Lldb-commits] [PATCH] D152861: Clear non-addressable bits from fp/sp/lr/pc values in RegisterContextUnwind

DavidSpickett added a comment. TIL what gcore is. One can save a corefile from within lldb too, I assume you've checked what that does (and with this change, it wouldn't matter either way). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D152861: Clear non-addressable bits from fp/sp/lr/pc values in RegisterContextUnwind

This revision was automatically updated to reflect the committed changes. Closed by commit rG0ce7037b5edd: Clear non-addressable bits from pc/fp/sp in unwinds (authored by jasonmolenda). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152861/new/

[Lldb-commits] [PATCH] D152861: Clear non-addressable bits from fp/sp/lr/pc values in RegisterContextUnwind

jasonmolenda added a comment. In D152861#4420223 , @DavidSpickett wrote: > I'm curious how you would end up with a signed PC value, but given this is > unwind it could be a value from a previous frame that was signed when stored > to the stack. The

[Lldb-commits] [PATCH] D152861: Clear non-addressable bits from fp/sp/lr/pc values in RegisterContextUnwind

DavidSpickett accepted this revision. DavidSpickett added a comment. This revision is now accepted and ready to land. I'm curious how you would end up with a signed PC value, but given this is unwind it could be a value from a previous frame that was signed when stored to the stack. LGTM.

[Lldb-commits] [PATCH] D152861: Clear non-addressable bits from fp/sp/lr/pc values in RegisterContextUnwind

jasonmolenda updated this revision to Diff 531092. jasonmolenda added a comment. Address Alex's feedback of not extracting the ABI pointer out of the shared pointer; simply use the shared pointer. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D152861: Clear non-addressable bits from fp/sp/lr/pc values in RegisterContextUnwind

jasonmolenda added a comment. In D152861#4419197 , @bulbazord wrote: > I noticed you're pulling a lot of raw pointers out of shared pointers. Is > there a particular reason you're doing that? `operator bool` on > `std::shared_ptr` returns true if the

[Lldb-commits] [PATCH] D152861: Clear non-addressable bits from fp/sp/lr/pc values in RegisterContextUnwind

bulbazord added a comment. I noticed you're pulling a lot of raw pointers out of shared pointers. Is there a particular reason you're doing that? `operator bool` on `std::shared_ptr` returns true if the held pointer is non-null. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D152861: Clear non-addressable bits from fp/sp/lr/pc values in RegisterContextUnwind

jasonmolenda created this revision. jasonmolenda added a reviewer: JDevlieghere. jasonmolenda added a project: LLDB. Herald added a subscriber: kristof.beyls. Herald added a reviewer: a.sidorin. Herald added a project: All. jasonmolenda requested review of this revision. Herald added a subscriber: