[Lldb-commits] [PATCH] D152866: [lldb] Print lldbassert to debugger diagnostics

This revision was automatically updated to reflect the committed changes. Closed by commit rG83a6a0a62047: [lldb] Print lldbassert to debugger diagnostics (authored by JDevlieghere). Herald added a project: LLDB. Changed prior to commit: https://reviews.llvm.org/D152866?vs=531126&id=531161#toc

[Lldb-commits] [PATCH] D152866: [lldb] Print lldbassert to debugger diagnostics

JDevlieghere updated this revision to Diff 531126. JDevlieghere added a comment. Separate out message, backtrace and prompt. This works better for a custom (downstream) callback that prompts the user to automatically file a bug report. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D15286

[Lldb-commits] [PATCH] D152866: [lldb] Print lldbassert to debugger diagnostics

bulbazord accepted this revision. bulbazord added a comment. This revision is now accepted and ready to land. In D152866#4419413 , @JDevlieghere wrote: > In D152866#4419406 , @bulbazord > wrote: > >> I like this

[Lldb-commits] [PATCH] D152866: [lldb] Print lldbassert to debugger diagnostics

JDevlieghere updated this revision to Diff 53. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152866/new/ https://reviews.llvm.org/D152866 Files: lldb/include/lldb/Core/Debugger.h lldb/include/lldb/Utility/LLDBAssert.h lldb/source/API/SystemInitializerFull.cpp lldb/source/Core

[Lldb-commits] [PATCH] D152866: [lldb] Print lldbassert to debugger diagnostics

JDevlieghere updated this revision to Diff 531110. JDevlieghere marked an inline comment as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152866/new/ https://reviews.llvm.org/D152866 Files: lldb/include/lldb/Core/Debugger.h lldb/include/lldb/Utility/LLDBAssert.h lldb/source/A

[Lldb-commits] [PATCH] D152866: [lldb] Print lldbassert to debugger diagnostics

JDevlieghere added a comment. In D152866#4419406 , @bulbazord wrote: > I like this idea quite a bit! I assume that when somebody hits a bug, they > can give us their diagnostics file and we will hopefully see the assertion > somewhere (if there was one)

[Lldb-commits] [PATCH] D152866: [lldb] Print lldbassert to debugger diagnostics

bulbazord added a comment. I like this idea quite a bit! I assume that when somebody hits a bug, they can give us their diagnostics file and we will hopefully see the assertion somewhere (if there was one)? Comment at: lldb/source/Target/Target.cpp:115 + lldbassert(false &

[Lldb-commits] [PATCH] D152866: [lldb] Print lldbassert to debugger diagnostics

JDevlieghere created this revision. JDevlieghere added reviewers: labath, rupprecht, bulbazord, aprantl. Herald added a project: All. JDevlieghere requested review of this revision. When hitting an lldbassert in a non-assert build, we emit a blurb including the assertion, the triggering file and