This revision was automatically updated to reflect the committed changes.
Closed by commit rL280942: Fix for rL280668, Intel(R) Memory Protection
Extensions (Intel(R) MPX) support. (authored by valentinagiusti).
Changed prior to commit:
https://reviews.llvm.org/D24255?vs=70695&id=70698#toc
Rep
labath accepted this revision.
labath added a comment.
This revision is now accepted and ready to land.
LGTM, thanks.
https://reviews.llvm.org/D24255
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/lis
valentinagiusti added inline comments.
Comment at:
packages/Python/lldbsuite/test/functionalities/register/intel_xtended_registers/Makefile:7
@@ +6,2 @@
+
+include $(LEVEL)/Makefile.rules
Np, thanks for the review and explanations ;)
https://reviews.llvm.org/D2
valentinagiusti updated this revision to Diff 70695.
valentinagiusti added a comment.
Improved MPX test Makefile and removed workaround for unnamed register sets,
and rebased according to the new coding style.
https://reviews.llvm.org/D24255
Files:
packages/Python/lldbsuite/test/functionalit
labath added a comment.
I think we're approaching the end now. If you could upload the new version
(you'll have to reformat the changes), I'll give it a final pass.
Comment at:
packages/Python/lldbsuite/test/functionalities/register/intel_xtended_registers/Makefile:6
@@ +5,3 @
valentinagiusti marked an inline comment as done.
Comment at:
packages/Python/lldbsuite/test/functionalities/register/intel_xtended_registers/Makefile:6
@@ +5,3 @@
+ifeq "$(ARCH)" "i386"
+ CFLAGS_EXTRAS += -mmpx -fcheck-pointer-bounds -fuse-ld=bfd -m32
+ LD_EXTRAS +=
labath added inline comments.
Comment at:
packages/Python/lldbsuite/test/functionalities/register/intel_xtended_registers/Makefile:5
@@ +4,3 @@
+
+ifeq "$(ARCH)" "i386"
+ CXXFLAGS += -mmpx -fcheck-pointer-bounds -fuse-ld=bfd -m32
valentinagiusti wrote:
> la
valentinagiusti updated this revision to Diff 70507.
valentinagiusti added a comment.
Improved TestMPXRegisters.py and Makefile according to review.
https://reviews.llvm.org/D24255
Files:
packages/Python/lldbsuite/test/functionalities/register/Makefile
packages/Python/lldbsuite/test/functio
clayborg requested changes to this revision.
clayborg added a comment.
Just switch to using CFLAGS_EXTRAS and LD_EXTRAS and this is good to go.
Comment at:
packages/Python/lldbsuite/test/functionalities/register/intel_xtended_registers/Makefile:6-11
@@ +5,8 @@
+ifeq "$(ARCH)" "
valentinagiusti added a comment.
Hi, inline there are my other replies.
Comment at:
packages/Python/lldbsuite/test/functionalities/register/intel_xtended_registers/Makefile:5
@@ +4,3 @@
+
+ifeq "$(ARCH)" "i386"
+ CXXFLAGS += -mmpx -fcheck-pointer-bounds -fuse-ld=bfd -m32
Also given that the reformat is going to happen today, I wonder if we
should wait until after it is complete to put in any more high risk changes.
On Tue, Sep 6, 2016 at 8:07 AM Pavel Labath via lldb-commits <
lldb-commits@lists.llvm.org> wrote:
> labath requested changes to this revision.
> laba
labath requested changes to this revision.
labath added a comment.
This revision now requires changes to proceed.
I have a couple of questions I'd like to be answered before this goes in. Apart
from the inline comments, all my questions from the previous version of this
commit still stand.
===
valentinagiusti created this revision.
valentinagiusti added a subscriber: lldb-commits.
Signed-off-by: Valentina Giusti
https://reviews.llvm.org/D24255
Files:
packages/Python/lldbsuite/test/functionalities/register/Makefile
packages/Python/lldbsuite/test/functionalities/register/TestRegist
13 matches
Mail list logo