This revision was automatically updated to reflect the committed changes.
Closed by commit rL295342: [lldb] Add support for "external" reports in
ThreadSanitizer LLDB plugin (authored by kuba.brecka).
Changed prior to commit:
https://reviews.llvm.org/D30024?vs=88654&id=88751#toc
Repository:
kubamracek added inline comments.
Comment at:
source/Plugins/InstrumentationRuntime/ThreadSanitizer/ThreadSanitizerRuntime.cpp:89
+
+void *dlsym(void* handle, const char* symbol);
+int (*ptr__tsan_get_report_loc_object_type)(void *report, unsigned long
idx, const char
clayborg added inline comments.
Comment at:
source/Plugins/InstrumentationRuntime/ThreadSanitizer/ThreadSanitizerRuntime.cpp:89
+
+void *dlsym(void* handle, const char* symbol);
+int (*ptr__tsan_get_report_loc_object_type)(void *report, unsigned long
idx, const char *
kubamracek added inline comments.
Comment at:
source/Plugins/InstrumentationRuntime/ThreadSanitizer/ThreadSanitizerRuntime.cpp:89
+
+void *dlsym(void* handle, const char* symbol);
+int (*ptr__tsan_get_report_loc_object_type)(void *report, unsigned long
idx, const char
clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.
Looks good.
Comment at:
source/Plugins/InstrumentationRuntime/ThreadSanitizer/ThreadSanitizerRuntime.cpp:89
+
+void *dlsym(void* handle, const char* symbol);
+
kubamracek created this revision.
TSan now has the ability to report races on "external" object, i.e. any library
class/object that has read-shared write-exclusive threading semantics. The
detection and reporting work almost out of the box, but TSan can now provide
the type of the object (as a
