[Lldb-commits] [PATCH] D40474: DWZ 09/11: Main functionality

2018-03-18 Thread Jan Kratochvil via Phabricator via lldb-commits
jankratochvil updated this revision to Diff 138860. https://reviews.llvm.org/D40474 Files: include/lldb/Utility/ConstString.h include/lldb/Utility/FileSpec.h source/Plugins/SymbolFile/DWARF/CMakeLists.txt source/Plugins/SymbolFile/DWARF/DWARFCompileUnit.cpp

[Lldb-commits] [PATCH] D40474: DWZ 09/11: Main functionality

2018-03-12 Thread Pavel Labath via Phabricator via lldb-commits
labath added a reviewer: davide. labath added a comment. I think the most controversial issue here is the testing... davide may have some thoughts on that. Comment at: source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp:4529 +SymbolFileDWARF::DWZCommonFile::DWZCommonFile( +

[Lldb-commits] [PATCH] D40474: DWZ 09/11: Main functionality

2018-03-12 Thread Greg Clayton via Phabricator via lldb-commits
clayborg added a comment. Too many changes to give the whole thing the OK to checkin. I will worry about each one as an individual patch. 02/11 next. https://reviews.llvm.org/D40474 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D40474: DWZ 09/11: Main functionality

2018-03-11 Thread Jan Kratochvil via Phabricator via lldb-commits
jankratochvil added a comment. ping: Are there more comments how to make this whole patchset accepted upstream? Thanks. https://reviews.llvm.org/D40474 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D40474: DWZ 09/11: Main functionality

2018-02-20 Thread Jan Kratochvil via Phabricator via lldb-commits
jankratochvil updated this revision to Diff 135060. jankratochvil marked an inline comment as done. jankratochvil retitled this revision from "DWZ 11/12: Main functionality" to "DWZ 09/11: Main functionality". https://reviews.llvm.org/D40474 Files: include/lldb/Utility/ConstString.h