This revision was automatically updated to reflect the committed changes.
Closed by commit rL332842: Fix PathMappingList for relative and empty paths
after recent FileSpec… (authored by gclayton, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
labath accepted this revision.
labath added a comment.
This revision is now accepted and ready to land.
looks good. I don't know if anyone else has an opinion on how should we treat
"" for mapping purposes, but treating it as "." seems fine to me.
Comment at:
clayborg updated this revision to Diff 147587.
clayborg added a comment.
- Fixed Pavel's issues
- If user specifies "" as the first directory in PathMappingList, it will match
"."
- User can specify "/" as the first directory to remap all absolute paths
- Fixed FileSpec::IsAbsolute() and added
labath added a comment.
Although it may not seem that way from the number of comments, the change looks
good to me. The main thing is the moving of the test file, as that will fail in
the cmake build. And it also looks like some code can be simplified if my
assumption about not converting ""
clayborg marked 7 inline comments as done.
clayborg added a comment.
Marked things as done.
https://reviews.llvm.org/D47021
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
clayborg updated this revision to Diff 147354.
clayborg added a comment.
Fix issues found by Zach.
https://reviews.llvm.org/D47021
Files:
include/lldb/Target/PathMappingList.h
lldb.xcodeproj/project.pbxproj
source/Target/PathMappingList.cpp
source/Target/Target.cpp
zturner added inline comments.
Comment at: source/Target/PathMappingList.cpp:76
++m_mod_id;
- m_pairs.push_back(pair(path, replacement));
+ m_pairs.push_back(pair(NormalizePath(path), NormalizePath(replacement)));
if (notify && m_callback)
Slightly more
clayborg created this revision.
clayborg added reviewers: labath, zturner, davide.
Herald added subscribers: JDevlieghere, aprantl, mgorny.
PathMappingList was broken for relative and empty paths after normalization
changes in FileSpec. There were also no tests for PathMappingList so I added
