Re: [Lldb-commits] [PATCH] D57475: [Reproducers] Add SBReproducer macros

Yes, I think that makes sense. I'll remove the register macro for now, which initializes the types. The record macro I'll leave in place to ensure the toggling between boundaries doesn't get affected by this. The "nice" side effect is that it will trigger an assertion during replay, which hopefully

[Lldb-commits] [PATCH] D57475: [Reproducers] Add SBReproducer macros

labath added a comment. Jonas, would it be possible to just not intercept the functions which work with thread IDs and similar stuff (an all OSs)? Using the naive serialization approach will not be correct for these, even if the types happen to be implemented as primitive types (most likely we w

[Lldb-commits] [PATCH] D57475: [Reproducers] Add SBReproducer macros

mgorny added a comment. This is still breaking NetBSD buildbot: http://lab.llvm.org:8011/builders/netbsd-amd64/builds/19339/steps/ninja%20build%20local/logs/stdio FAILED: tools/lldb/source/API/CMakeFiles/liblldb.dir/SBHostOS.cpp.o /usr/bin/g++ -DGTEST_HAS_RTTI=0 -DHAVE_ROUND -DLIBXML2_DEFI

[Lldb-commits] [PATCH] D57475: [Reproducers] Add SBReproducer macros

JDevlieghere marked 4 inline comments as done. JDevlieghere added a comment. Thanks Tatyana! Comment at: source/API/SBReproducer.cpp:40 + // write into the replay buffer. + char buffer[arch_name_len]; + return SBDebugger::GetDefaultArchitecture(buffer, arch_name_len); --

[Lldb-commits] [PATCH] D57475: [Reproducers] Add SBReproducer macros

tatyana-krasnukha added a comment. Run into a few compilation errors building on Windows with msvc. Comment at: source/API/SBReproducer.cpp:40 + // write into the replay buffer. + char buffer[arch_name_len]; + return SBDebugger::GetDefaultArchitecture(buffer, arch_name_len);

[Lldb-commits] [PATCH] D57475: [Reproducers] Add SBReproducer macros

This revision was automatically updated to reflect the committed changes. Closed by commit rLLDB355459: [Reproducers] Add SBReproducer macros (authored by JDevlieghere, committed by ). Herald added a subscriber: teemperor. Changed prior to commit: https://reviews.llvm.org/D57475?vs=188015&id=18

[Lldb-commits] [PATCH] D57475: [Reproducers] Add SBReproducer macros

JDevlieghere updated this revision to Diff 188015. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57475/new/ https://reviews.llvm.org/D57475 Files: lldb/source/API/SBAddress.cpp lldb/source/API/SBAttachInfo.cpp lldb/source/API/SBBlock.cpp lldb/source/API/SBBreakpoint.cpp lldb/so

[Lldb-commits] [PATCH] D57475: [Reproducers] Add SBReproducer macros

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. lgtm CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57475/new/ https://reviews.llvm.org/D57475 ___ lldb-commits mailing list lldb-commits

[Lldb-commits] [PATCH] D57475: [Reproducers] Add SBReproducer macros

JDevlieghere updated this revision to Diff 187287. JDevlieghere added a comment. Herald added a subscriber: jdoerfert. - Rebase - Re-ran the latest version of the tool to insert `LLDB_RECORD_RESULT` CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57475/new/ https://reviews.llvm.org/D57475

[Lldb-commits] [PATCH] D57475: [Reproducers] Add SBReproducer macros

JDevlieghere updated this revision to Diff 185432. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57475/new/ https://reviews.llvm.org/D57475 Files: source/API/SBAddress.cpp source/API/SBAttachInfo.cpp source/API/SBBlock.cpp source/API/SBBreakpoint.cpp source/API/SBBreakpointLoca

[Lldb-commits] [PATCH] D57475: [Reproducers] Add SBReproducer macros

labath added inline comments. Comment at: source/API/SBBlock.cpp:52-58 + SB_RECORD_METHOD_CONST_NO_ARGS(bool, SBBlock, IsValid); + return m_opaque_ptr != NULL; +} bool SBBlock::IsInlined() const { + SB_RECORD_METHOD_CONST_NO_ARGS(bool, SBBlock, IsInlined); + ---

[Lldb-commits] [PATCH] D57475: [Reproducers] Add SBReproducer macros

JDevlieghere marked an inline comment as done. JDevlieghere added inline comments. Comment at: source/API/SBBlock.cpp:52-58 + SB_RECORD_METHOD_CONST_NO_ARGS(bool, SBBlock, IsValid); + return m_opaque_ptr != NULL; +} bool SBBlock::IsInlined() const { + SB_RECORD_METHOD_CONST

[Lldb-commits] [PATCH] D57475: [Reproducers] Add SBReproducer macros

labath added a comment. BTW, it would be nice to mention somewhere how to use this tool. Do you just run it, or does it needs some special arguments, or something? Comment at: source/API/SBBlock.cpp:52-58 + SB_RECORD_METHOD_CONST_NO_ARGS(bool, SBBlock, IsValid); + return m_o

[Lldb-commits] [PATCH] D57475: [Reproducers] Add SBReproducer macros

JDevlieghere created this revision. JDevlieghere added a reviewer: labath. JDevlieghere added a project: LLDB. Herald added a reviewer: jfb. This patch adds the SBReproducer macros needed to capture and reply the corresponding calls. The patch was generated using the SBRepro tool (D56822