This revision was not accepted when it landed; it landed in state "Needs
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit rLLDB356090: Fix an invalid static cast in
ClangExpressionParser.cpp (authored by adrian, committed by ).
Herald added a sub
aprantl added a comment.
Renamed enumerators.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D59314/new/
https://reviews.llvm.org/D59314
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo
aprantl updated this revision to Diff 190476.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D59314/new/
https://reviews.llvm.org/D59314
Files:
lldb/include/lldb/Expression/Expression.h
lldb/include/lldb/Expression/FunctionCaller.h
lldb/include/lldb/Expression/LLVMUserExpression.h
aprantl added a comment.
I was following http://www.llvm.org/docs/HowToSetUpLLVMStyleRTTI.html I will
rename it to eKind...
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D59314/new/
https://reviews.llvm.org/D59314
___
lldb-commits mailing l
jingham added a comment.
Also naming quibble...
Comment at: lldb/include/lldb/Expression/Expression.h:38
+ /// Discriminator for LLVM-style RTTI (dyn_cast<> et al.)
+ enum ExpressionKind {
+EK_FunctionCaller,
I don't think we use this naming for enum's an
aprantl updated this revision to Diff 190470.
aprantl added a comment.
Excellent point!
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D59314/new/
https://reviews.llvm.org/D59314
Files:
lldb/include/lldb/Expression/Expression.h
lldb/include/lldb/Expression/FunctionCaller.h
lldb/inc
jingham added a comment.
I think you have to protect against your dyn_cast failing.
Comment at:
lldb/source/Plugins/ExpressionParser/Clang/ClangExpressionParser.cpp:495
- auto &clang_expr = *static_cast(&m_expr);
- if (clang_expr.DidImportCxxModules()) {
+ auto *clang_exp
aprantl updated this revision to Diff 190460.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D59314/new/
https://reviews.llvm.org/D59314
Files:
lldb/include/lldb/Expression/Expression.h
lldb/include/lldb/Expression/FunctionCaller.h
lldb/include/lldb/Expression/LLVMUserExpression.h
aprantl created this revision.
aprantl added a reviewer: jingham.
Herald added a project: LLDB.
This was found by the green dragon sanitizer bot.
Repository:
rG LLVM Github Monorepo
https://reviews.llvm.org/D59314
Files:
lldb/include/lldb/Expression/Expression.h
lldb/include/lldb/Express
