[Lldb-commits] [PATCH] D60121: Object/Minidump: Add support for reading the ModuleList stream

labath created this revision. labath added reviewers: zturner, amccarth, jhenderson, clayborg. Herald added a subscriber: jdoerfert. Herald added a project: LLVM. The ModuleList stream consists of an integer giving the number of entries in the list, followed by the list itself. Each entry in the l

[Lldb-commits] [PATCH] D60121: Object/Minidump: Add support for reading the ModuleList stream

jhenderson added a comment. Code basically looks fine, but somebody else should confirm that the format is correct. Comment at: lib/Object/Minidump.cpp:55 + if (!OptionalStream) +return createError("No such stream", object_error::invalid_section_index); + auto ExpectedSi

[Lldb-commits] [PATCH] D60121: Object/Minidump: Add support for reading the ModuleList stream

labath marked 2 inline comments as done. labath added a comment. In D60121#1454817 , @jhenderson wrote: > Code basically looks fine, but somebody else should confirm that the format > is correct. BTW, the structure definitions are just copied from lldb

[Lldb-commits] [PATCH] D60121: Object/Minidump: Add support for reading the ModuleList stream

labath updated this revision to Diff 193713. labath marked an inline comment as done. labath added a comment. - avoid using mismatched error codes - use decimal numbers more consistently in the tests Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60121/new/ https:/

[Lldb-commits] [PATCH] D60121: Object/Minidump: Add support for reading the ModuleList stream

labath marked an inline comment as done. labath added inline comments. Comment at: lib/Object/Minidump.cpp:55 + if (!OptionalStream) +return createError("No such stream", object_error::invalid_section_index); + auto ExpectedSize = labath wrote: > jhenderson

[Lldb-commits] [PATCH] D60121: Object/Minidump: Add support for reading the ModuleList stream

jhenderson accepted this revision. jhenderson added a comment. This revision is now accepted and ready to land. Okay, no more comments from me. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60121/new/ https://reviews.llvm.org/D60121

[Lldb-commits] [PATCH] D60121: Object/Minidump: Add support for reading the ModuleList stream

This revision was automatically updated to reflect the committed changes. Closed by commit rL357897: Object/Minidump: Add support for reading the ModuleList stream (authored by labath, committed by ). Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60121/new/ https:/