[Lldb-commits] [PATCH] D65469: Remove `bugreport` command

2019-09-05 Thread Jonas Devlieghere via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGf5687d7c1257: Remove `bugreport` command (authored by JDevlieghere). Changed prior to commit: https://reviews.llvm.org/D65469?vs=212406&id=218989#toc Repository: rG LLVM Github Monorepo CHANGES SINC

[Lldb-commits] [PATCH] D65469: Remove `bugreport` command

2019-09-05 Thread Jason Molenda via Phabricator via lldb-commits
jasonmolenda accepted this revision. jasonmolenda added a comment. This revision is now accepted and ready to land. We don't need to keep this command around. It was originated by Tamas in 2015, https://reviews.llvm.org/D10868 but never got used for anything - Tamas was working on unwind things b

[Lldb-commits] [PATCH] D65469: Remove `bugreport` command

2019-09-02 Thread Raphael Isemann via Phabricator via lldb-commits
teemperor added a comment. What's the state of this? Because thi is in my review queue and it has no associated test, so either this moves forward and we remove bugreport or we keep bugreport and I'll put it on my list of things that need tests :) Repository: rLLDB LLDB CHANGES SINCE LAST A

[Lldb-commits] [PATCH] D65469: Remove `bugreport` command

2019-07-31 Thread Jonas Devlieghere via Phabricator via lldb-commits
JDevlieghere added a comment. In D65469#1608737 , @jingham wrote: > If we don't want to forget that there was specific useful info, we could gate > this patch on implementing the "reproducer generate " feature. That > should be easy to add if we're clea

[Lldb-commits] [PATCH] D65469: Remove `bugreport` command

2019-07-31 Thread Jim Ingham via Phabricator via lldb-commits
jingham added a comment. If we don't want to forget that there was specific useful info, we could gate this patch on implementing the "reproducer generate " feature. That should be easy to add if we're clear this this is the right design for reproducers. But I don't think that "bugreport unwi

[Lldb-commits] [PATCH] D65469: Remove `bugreport` command

2019-07-31 Thread Jim Ingham via Phabricator via lldb-commits
jingham added a comment. The thing the "bugreport unwind" adds is that it runs a handful of commands that gather data useful in diagnosing unwind problems. That's useful when the information you need might not be output by the session in which the bug appeared. The same thing could be achieve

[Lldb-commits] [PATCH] D65469: Remove `bugreport` command

2019-07-31 Thread Jonas Devlieghere via Phabricator via lldb-commits
JDevlieghere added a comment. In D65469#1608653 , @clayborg wrote: > In D65469#1608631 , @JDevlieghere > wrote: > > > In D65469#1608278 , @clayborg > > wrote: > > > > > IMH

[Lldb-commits] [PATCH] D65469: Remove `bugreport` command

2019-07-31 Thread Greg Clayton via Phabricator via lldb-commits
clayborg added a comment. In D65469#1608631 , @JDevlieghere wrote: > In D65469#1608278 , @clayborg wrote: > > > IMHO: we should keep this command and expand its abilities to help report > > stepping issues, expres

[Lldb-commits] [PATCH] D65469: Remove `bugreport` command

2019-07-31 Thread Jonas Devlieghere via Phabricator via lldb-commits
JDevlieghere added a comment. In D65469#1608278 , @clayborg wrote: > IMHO: we should keep this command and expand its abilities to help report > stepping issues, expression issues and more. Why? Getting good bug reports > from users is quite hard. Allowi

[Lldb-commits] [PATCH] D65469: Remove `bugreport` command

2019-07-31 Thread Greg Clayton via Phabricator via lldb-commits
clayborg added a comment. IMHO: we should keep this command and expand its abilities to help report stepping issues, expression issues and more. Why? Getting good bug reports from users is quite hard. Allowing them to type "bugreport step --step-in" or "bugreport step --step-over" would be real

[Lldb-commits] [PATCH] D65469: Remove `bugreport` command

2019-07-30 Thread Davide Italiano via Phabricator via lldb-commits
davide added a comment. Other than that, I have no objections. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65469/new/ https://reviews.llvm.org/D65469 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http

[Lldb-commits] [PATCH] D65469: Remove `bugreport` command

2019-07-30 Thread Davide Italiano via Phabricator via lldb-commits
davide added a comment. I wanted to remove it a while ago, but Jason told me he found this useful, so I would wait for his opinion. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65469/new/ https://reviews.llvm.org/D65469

[Lldb-commits] [PATCH] D65469: Remove `bugreport` command

2019-07-30 Thread Jonas Devlieghere via Phabricator via lldb-commits
JDevlieghere created this revision. JDevlieghere added reviewers: jingham, jasonmolenda. JDevlieghere added a project: LLDB. Herald added a subscriber: mgorny. The bugreport command exists to create domain-specific bug reports. Currently it has one implementation for filing bugs on the unwinder.