This revision was automatically updated to reflect the committed changes.
Closed by commit rL373563: SBDebugger::SetInputFile, SetOutputFile, etc.
(authored by lawrence_danna, committed by ).
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https:/
lawrence_danna updated this revision to Diff 222664.
lawrence_danna marked an inline comment as done.
lawrence_danna added a comment.
no inlines in the API
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D68181/new/
https://reviews.llvm.org/D68181
Fi
labath accepted this revision.
labath added a comment.
This revision is now accepted and ready to land.
LGTM. thanks.
Comment at: lldb/include/lldb/API/SBFile.h:31-36
operator bool() const { return IsValid(); }
bool operator!() const { return !IsValid(); }
private:
lawrence_danna updated this revision to Diff 222538.
lawrence_danna added a comment.
assertions instead of exceptions
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D68181/new/
https://reviews.llvm.org/D68181
Files:
lldb/include/lldb/API/SBDebugge
lawrence_danna updated this revision to Diff 222537.
lawrence_danna added a comment.
pushed validity checks out to the SB layer
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D68181/new/
https://reviews.llvm.org/D68181
Files:
lldb/include/lldb/API
lawrence_danna updated this revision to Diff 222520.
lawrence_danna added a comment.
propagated updates from parent
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D68181/new/
https://reviews.llvm.org/D68181
Files:
lldb/include/lldb/API/SBDebugger.
labath added a comment.
Looks mostly fine to me. Just a couple of questions inline...
Comment at:
lldb/packages/Python/lldbsuite/test/python_api/file_handle/TestFileHandle.py:243-244
+status = debugger.SetOutputFile(outsbf)
+if status.Fail():
+
lawrence_danna updated this revision to Diff 85.
lawrence_danna added a comment.
clang-format fix
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D68181/new/
https://reviews.llvm.org/D68181
Files:
lldb/include/lldb/API/SBDebugger.h
lldb/inclu
lawrence_danna created this revision.
lawrence_danna added reviewers: JDevlieghere, jasonmolenda, labath.
Herald added a project: LLDB.
Add new methods to SBDebugger to set IO files as SBFiles instead of
as FILE* streams.
In future commits, the FILE* methods will be deprecated and these
will bec
