[Lldb-commits] [PATCH] D69931: Add cmake variables to specify a python framework to ship with lldb

smeenai added a comment. Commit message needs to be updated. Comment at: lldb/cmake/modules/LLDBFramework.cmake:124 + +# Add an rpath pointing to the directory where LLDB.framework is installed. +set_property(TARGET liblldb APPEND PROPERTY INSTALL_RPATH You may

[Lldb-commits] [PATCH] D69931: Add cmake variables to specify a python framework to ship with lldb

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. This seems reasonable to me. > path @loader_path/../../../../../../../../Library/Frameworks/ LOL :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.or

[Lldb-commits] [PATCH] D69931: Add cmake variables to specify a python framework to ship with lldb

aadsm updated this revision to Diff 228634. aadsm added a comment. Updating to only add an rpath that points to the directory where LLDB.frameworks gets installed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69931/new/ https://reviews.llvm.org/D

[Lldb-commits] [PATCH] D69931: Add cmake variables to specify a python framework to ship with lldb

aadsm added a comment. > The proposed path in this patch, -rpath "@loader_path/../../../", uses the > @loader_path expansion which is the directory containing the binary that the > load command is in (in this case liblldb's directory). Popping 3 directories > up from that is likely not sane in

[Lldb-commits] [PATCH] D69931: Add cmake variables to specify a python framework to ship with lldb

smeenai added a comment. In D69931#1739063 , @beanz wrote: > It is a bit gross that Python does an @rpath install name, that is generally > against convention. I can see adding an option to add rpaths to liblldb > making sense. I certainly agree LLDB sho

[Lldb-commits] [PATCH] D69931: Add cmake variables to specify a python framework to ship with lldb

beanz added a comment. It is a bit gross that Python does an @rpath install name, that is generally against convention. I can see adding an option to add rpaths to liblldb making sense. I certainly agree LLDB shouldn't be in the business of packaging transitive dependencies. In a broader sense

[Lldb-commits] [PATCH] D69931: Add cmake variables to specify a python framework to ship with lldb

aadsm added a comment. That should work fine yeah. It should be a matter of adding `"@loader_path/../../../"` to the rpath. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69931/new/ https://reviews.llvm.org/D69931 ___

[Lldb-commits] [PATCH] D69931: Add cmake variables to specify a python framework to ship with lldb

labath added a reviewer: beanz. labath added a subscriber: beanz. labath added a comment. In D69931#1738097 , @smeenai wrote: > I agree on not getting into the business of installing Python ourselves, but > there's also the rpath issue. The Windows case i

[Lldb-commits] [PATCH] D69931: Add cmake variables to specify a python framework to ship with lldb

smeenai added a comment. I agree on not getting into the business of installing Python ourselves, but there's also the rpath issue. The Windows case is different because you just put all your DLLs in the same directory (or some other directory in your PATH) and you're done. With macOS, you have

[Lldb-commits] [PATCH] D69931: Add cmake variables to specify a python framework to ship with lldb

hhb added a comment. In D69931#1736607 , @labath wrote: > In principle, this looks pretty similar to D67942 > , and my opinion on it is the same -- I > don't think we should be in the business of trying to package the tra

[Lldb-commits] [PATCH] D69931: Add cmake variables to specify a python framework to ship with lldb

labath added a comment. In principle, this looks pretty similar to D67942 , and my opinion on it is the same -- I don't think we should be in the business of trying to package the transitive set of lldb dependencies. I think the lldb install target should instal

[Lldb-commits] [PATCH] D69931: Add cmake variables to specify a python framework to ship with lldb

aadsm created this revision. aadsm added reviewers: hhb, sgraenitz, xiaobai, smeenai. Herald added subscribers: lldb-commits, mgorny. Herald added a project: LLDB. I want to be able to specify which python framework to use for lldb in macos. With python2.7 we could just rely on the MacOS one but