aganea created this revision.
aganea added a reviewer: jingham.
Herald added a project: LLDB.
Herald added a subscriber: lldb-commits.
This fixes a warning on MSVC:
F:\llvm-project\lldb\source\Commands\CommandObjectThread.cpp(529): warning
C4305: 'argument': truncation from 'char' to 'bool'
P
shafik added inline comments.
Comment at: lldb/source/Commands/CommandObjectThread.cpp:529
m_step_type(step_type), m_step_scope(step_scope), m_options(),
-m_class_options("scripted step", 'C') {
+m_class_options("scripted step", true, 'C') {
CommandA
aganea updated this revision to Diff 230097.
aganea marked an inline comment as done.
aganea added a comment.
Omit default arguments.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D70448/new/
https://reviews.llvm.org/D70448
Files:
lldb/source/Commands/CommandObjectThread.cpp
Index:
aganea added a comment.
This is a trivial change, unless you have any objections, I'll go forward with
this.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D70448/new/
https://reviews.llvm.org/D70448
___
lldb-commits mailing list
lldb-commit
jingham accepted this revision.
jingham added a comment.
This revision is now accepted and ready to land.
Looks right, thanks for catching this.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D70448/new/
https://reviews.llvm.org/D70448
___
ll
This revision was automatically updated to reflect the committed changes.
Closed by commit rGb4dfc5508f92: [LLDB] Fix wrong argument in
CommandObjectThreadStepWithTypeAndScope (authored by aganea).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D70448/
