This revision was automatically updated to reflect the committed changes.
Closed by commit rG45c843de4eb8: [LLDB] [ARM] Use r11 as frame pointer on
Windows on ARM (authored by mstorsjo).
Changed prior to commit:
https://reviews.llvm.org/D70797?vs=231416&id=231527#toc
Repository:
rG LLVM Gith
mstorsjo updated this revision to Diff 231416.
mstorsjo edited the summary of this revision.
mstorsjo added a comment.
Added a testcase using a minidump. I had to add recognition of r11 as a
potential frame pointer register in thumb mode in the handling of one
instruction, to make it pick up the
labath added a reviewer: jasonmolenda.
labath added a comment.
Presumably, this should change how unwind plans are computed. The unwind
machinery will treat a `mov %sp, %fp`(whatever is the arm equivalent) as a
signal that it should switch to an frame-pointer based unwind. This logic
should not
mstorsjo created this revision.
mstorsjo added reviewers: labath, amccarth.
Herald added a subscriber: kristof.beyls.
Herald added a project: LLDB.
The change in itself is straightforward based on reading the code, but I don't
have a real world case where I know this made a difference, so I don't
