[Lldb-commits] [PATCH] D74255: [LLDB] Add support for AVR breakpoints

This revision was automatically updated to reflect the committed changes. Closed by commit rG0818e6cf1d30: [LLDB] Add support for AVR breakpoints (authored by aykevl). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74255/new/

[Lldb-commits] [PATCH] D74255: [LLDB] Add support for AVR breakpoints

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. > As Dylan already mentioned, the opcode is indeed for the BREAK instruction. Ok, let's go with that. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D74255: [LLDB] Add support for AVR breakpoints

aykevl added a comment. In D74255#1871958 , @labath wrote: > However, if we look at this locally, if the AVR architecture has a trap > opcode (maybe to implement `__builtin_debugbreak()` -- I am assuming that's > what 0x98 0x95 is), then I don't see a

[Lldb-commits] [PATCH] D74255: [LLDB] Add support for AVR breakpoints

dylanmckay added a comment. > However, if we look at this locally, if the AVR architecture has a trap > opcode (maybe to implement __builtin_debugbreak() -- I am assuming that's > what 0x98 0x95 is), then I don't see a problem with this function returning > it. Chiming in from an AVR

[Lldb-commits] [PATCH] D74255: [LLDB] Add support for AVR breakpoints

labath added a comment. The whole flow here is pretty nonsensical -- the only reason we ask for the opcode is to get its size so we can put it into the Z0 packet -- however this is only needed for targets like arm, which have mutiple ISAs/opcodes, and we've already gotten complaints about

[Lldb-commits] [PATCH] D74255: [LLDB] Add support for AVR breakpoints

jingham added a comment. Might also be good to fix the crash. If you don't support software breakpoints, you shouldn't get asked what your breakpoint opcode is. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74255/new/

[Lldb-commits] [PATCH] D74255: [LLDB] Add support for AVR breakpoints

labath added a comment. We have infrastructure to "mock" a gdb-remote server (see packages/Python/lldbsuite/test/functionalities/gdb_remote_client/) to test lldb's interaction with it. For a simple patch like this, I don't think a test is really required (especially as they are not the

[Lldb-commits] [PATCH] D74255: [LLDB] Add support for AVR breakpoints

aykevl created this revision. aykevl added reviewers: labath, clayborg. Herald added subscribers: lldb-commits, Jim, dylanmckay. Herald added a project: LLDB. I believe the actual opcode does not matter because the AVR architecture is a Harvard architecture that does not support writing to