[Lldb-commits] [PATCH] D76314: [lldb-vscode] stop read loop after termination

This revision was automatically updated to reflect the committed changes. Closed by commit rG576105c322b6: [lldb-vscode] stop read loop after termination (authored by Walter Erquinigo walterme...@fb.com). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D76314: [lldb-vscode] stop read loop after termination

labath accepted this revision. labath marked an inline comment as done. labath added inline comments. Comment at: lldb/test/API/tools/lldb-vscode/launch/TestVSCode_launch.py:55-56 +# Wait until the underlying lldb-vscode process dies. +# We need to do this

[Lldb-commits] [PATCH] D76314: [lldb-vscode] stop read loop after termination

wallace updated this revision to Diff 251428. wallace added a comment. support python2.7 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76314/new/ https://reviews.llvm.org/D76314 Files: lldb/test/API/tools/lldb-vscode/launch/TestVSCode_launch.py

[Lldb-commits] [PATCH] D76314: [lldb-vscode] stop read loop after termination

wallace updated this revision to Diff 251425. wallace added a comment. address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76314/new/ https://reviews.llvm.org/D76314 Files: lldb/test/API/tools/lldb-vscode/launch/TestVSCode_launch.py

[Lldb-commits] [PATCH] D76314: [lldb-vscode] stop read loop after termination

labath added inline comments. Comment at: lldb/test/API/tools/lldb-vscode/launch/TestVSCode_launch.py:50-53 +time.sleep(1) +# lldb-vscode process must have already finished even though +# we didn't close the communication socket explicitly +

[Lldb-commits] [PATCH] D76314: [lldb-vscode] stop read loop after termination

clayborg added a comment. Just watch the build bots carefully when you check this in! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76314/new/ https://reviews.llvm.org/D76314 ___ lldb-commits mailing

[Lldb-commits] [PATCH] D76314: [lldb-vscode] stop read loop after termination

clayborg accepted this revision. clayborg added a comment. lgtm. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76314/new/ https://reviews.llvm.org/D76314 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D76314: [lldb-vscode] stop read loop after termination

wallace updated this revision to Diff 251204. wallace added a comment. address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76314/new/ https://reviews.llvm.org/D76314 Files: lldb/test/API/tools/lldb-vscode/launch/TestVSCode_launch.py

[Lldb-commits] [PATCH] D76314: [lldb-vscode] stop read loop after termination

clayborg added inline comments. Comment at: lldb/test/API/tools/lldb-vscode/launch/TestVSCode_launch.py:46-48 +program = self.getBuildArtifact("a.out") +self.build_and_launch(program, stopOnEntry=True) +

[Lldb-commits] [PATCH] D76314: [lldb-vscode] stop read loop after termination

wallace updated this revision to Diff 251149. wallace added a comment. add a test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76314/new/ https://reviews.llvm.org/D76314 Files: lldb/test/API/tools/lldb-vscode/launch/TestVSCode_launch.py

[Lldb-commits] [PATCH] D76314: [lldb-vscode] stop read loop after termination

wallace updated this revision to Diff 251150. wallace added a comment. nit Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76314/new/

[Lldb-commits] [PATCH] D76314: [lldb-vscode] stop read loop after termination

wallace added a comment. As we discussed privately, some remote connections use a mutiplexor socket that doesn't die when the debug session ends. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76314/new/ https://reviews.llvm.org/D76314

[Lldb-commits] [PATCH] D76314: [lldb-vscode] stop read loop after termination

clayborg added a comment. Does this have something to do with a multiplexor that funnels traffic through one tunnel? I am curious as to why the ReadJSON() doesn't exit after the other side closes down? LGTM, but needs a test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D76314: [lldb-vscode] stop read loop after termination

wallace created this revision. wallace added reviewers: clayborg, aadsm, kusmour. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. kusmour accepted this revision. This revision is now accepted and ready to land. On Linux, when executing lldb-vscode on a remote machine,