[Lldb-commits] [PATCH] D76449: [lldb/Dwarf] Change DW_OP_piece to use an llvm::BitVector (WIP)

labath added a comment. looking forward to seeing the final form of this In D76449#1932293 , @mib wrote: > Note that this diff is more a quick draft than a “finished” patch, I’m not > expecting to submit this until the DW_OP_bit_piece support is done.

[Lldb-commits] [PATCH] D76449: [lldb/Dwarf] Change DW_OP_piece to use an llvm::BitVector

mib marked an inline comment as done. mib added inline comments. Comment at: lldb/source/Expression/DWARFExpression.cpp:2164 + unsigned int curr_scalar = curr_piece.GetScalar().UInt(); + curr_scalar = curr_scalar << curr_width; + bit_pieces.resize(curr_

[Lldb-commits] [PATCH] D76449: [lldb/Dwarf] Change DW_OP_piece to use an llvm::BitVector

mib added a comment. Note that this diff is more a quick draft than a “finished” patch, I’m not expecting to submit this until the DW_OP_bit_piece support is done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76449/new/ https://reviews.llvm.org/D

[Lldb-commits] [PATCH] D76449: [lldb/Dwarf] Change DW_OP_piece to use an llvm::BitVector

mib marked 3 inline comments as done. mib added inline comments. Comment at: lldb/source/Expression/DWARFExpression.cpp:936 /// Insertion point for evaluating multi-piece expression. - uint64_t op_piece_offset = 0; - Value pieces; // Used for DW_OP_piece + llvm::BitVector b

[Lldb-commits] [PATCH] D76449: [lldb/Dwarf] Change DW_OP_piece to use an llvm::BitVector

vsk added a reviewer: labath. vsk added a comment. Excited to see this take shape :) Comment at: lldb/source/Expression/DWARFExpression.cpp:935 /// Insertion point for evaluating multi-piece expression. + llvm::BitVector bit_pieces; Stale comment here, wo

[Lldb-commits] [PATCH] D76449: [lldb/Dwarf] Change DW_OP_piece to use an llvm::BitVector

aprantl added inline comments. Comment at: lldb/source/Expression/DWARFExpression.cpp:936 /// Insertion point for evaluating multi-piece expression. - uint64_t op_piece_offset = 0; - Value pieces; // Used for DW_OP_piece + llvm::BitVector bit_pieces; + llvm::BitVector bit_

[Lldb-commits] [PATCH] D76449: [lldb/Dwarf] Change DW_OP_piece to use an llvm::BitVector

mib created this revision. mib added reviewers: aprantl, vsk, friss. mib added a project: LLDB. Herald added a subscriber: lldb-commits. This patch changes the implementation of DW_OP_piece to use llvm::BitVector instead of the lldb_private::Value. This allow to have more granularity which would