This revision was automatically updated to reflect the committed changes.
Closed by commit rG1beffc18886a: Support build-ids of other sizes than 16 in
UUID::SetFromStringRef (authored by jarin).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D80755/new
jarin updated this revision to Diff 268497.
jarin added a comment.
Exclude UUID strings ending with "-".
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D80755/new/
https://reviews.llvm.org/D80755
Files:
lldb/include/lldb/Utility/UUID.h
lldb/source/Interpreter/OptionValueUUID.cpp
ll
friss added inline comments.
Comment at: lldb/source/Utility/UUID.cpp:66-67
uuid_bytes.clear();
while (!p.empty()) {
-if (isxdigit(p[0]) && isxdigit(p[1])) {
+if (p.size() >= 2 && isxdigit(p[0]) && isxdigit(p[1])) {
int hi_nibble = xdigit_to_int(p[0]);
--
labath accepted this revision.
labath added a comment.
This revision is now accepted and ready to land.
Looks good. Let's just wait a while to see if Fred has any comments. If you
haven't already, you can use that time to get commit access. :)
Comment at: lldb/source/Utility/U
jarin updated this revision to Diff 267754.
jarin added a comment.
Added a test for missing nibble in UUID.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D80755/new/
https://reviews.llvm.org/D80755
Files:
lldb/include/lldb/Utility/UUID.h
lldb/source/Interpreter/OptionValueUUID.cpp
jarin updated this revision to Diff 267739.
jarin edited the summary of this revision.
jarin added a comment.
Removed size restrictions on UUIDs.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D80755/new/
https://reviews.llvm.org/D80755
Files:
lldb/include/lldb/Utility/UUID.h
lldb/so
jarin marked an inline comment as done.
jarin added inline comments.
Comment at: lldb/source/Utility/UUID.cpp:109
*this = fromData(bytes);
-return str.size() - rest.size();
+return str.size();
}
jankratochvil wrote:
> Now the return type could be
labath added a reviewer: friss.
labath added inline comments.
Comment at: lldb/source/Utility/UUID.cpp:93-94
+bool UUID::SetFromStringRef(llvm::StringRef str) {
+ const size_t max_uuid_size = 20;
+ const size_t min_uuid_size = 4;
+
I don't think we should be re
jarin updated this revision to Diff 267490.
jarin marked an inline comment as done.
jarin added a comment.
Change SetFromStringRef to return bool.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D80755/new/
https://reviews.llvm.org/D80755
Files:
lldb/include/lldb/Utility/UUID.h
lldb/s
MaskRay added a comment.
I haven't been paying close attention to this patch, but allowing 20 bytes
makes sense. In GNU ld and gold, `--build-id` is `--build-id=sha1` (20 bytes).
The 3 linkers (plus LLD) don't have a way to produce a build ID longer than 20
bytes.
CHANGES SINCE LAST ACTION
jankratochvil added inline comments.
Comment at: lldb/source/Utility/UUID.cpp:109
*this = fromData(bytes);
-return str.size() - rest.size();
+return str.size();
}
Now the return type could be `bool`.
CHANGES SINCE LAST ACTION
https://reviews.l
jarin updated this revision to Diff 267241.
jarin retitled this revision from "Support build-ids of other sizes than 16 in
SBTarget::AddModule" to "Support build-ids of other sizes than 16 in
UUID::SetFromStringRef".
jarin edited the summary of this revision.
Herald added subscribers: MaskRay, em
12 matches
Mail list logo
