[Lldb-commits] [PATCH] D82813: [Apple Silicon] Rewrite part of the Rosetta support to be confined in Apple specific files

2020-06-29 Thread Adrian Prantl via Phabricator via lldb-commits
aprantl added inline comments. Comment at: lldb/include/lldb/Host/Host.h:231 + /// Check whether a process is translated (Rosetta). + /// \arg process_info The info structure for the process queried. Is this supposed to be a generic function call that, e.g, s

[Lldb-commits] [PATCH] D82813: [Apple Silicon] Rewrite part of the Rosetta support to be confined in Apple specific files

2020-06-29 Thread Jonas Devlieghere via Phabricator via lldb-commits
JDevlieghere added inline comments. Comment at: lldb/source/Host/macosx/objcxx/Host.mm:1471 + size_t bufsize = sizeof(processInfo); + if (sysctl(mib, (unsigned)(sizeof(mib)/sizeof(int)), &processInfo, + &bufsize, NULL, 0) == 0 && bufsize <= 0) nit:

[Lldb-commits] [PATCH] D82813: [Apple Silicon] Rewrite part of the Rosetta support to be confined in Apple specific files

2020-06-29 Thread Davide Italiano via Phabricator via lldb-commits
davide updated this revision to Diff 274253. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82813/new/ https://reviews.llvm.org/D82813 Files: lldb/include/lldb/Host/Host.h lldb/source/Host/common/Host.cpp lldb/source/Host/macosx/objcxx/Host.mm lldb/source/Plugins/Process/gdb-remot

[Lldb-commits] [PATCH] D82813: [Apple Silicon] Rewrite part of the Rosetta support to be confined in Apple specific files

2020-06-29 Thread Davide Italiano via Phabricator via lldb-commits
davide marked an inline comment as done. davide added inline comments. Comment at: lldb/include/lldb/Host/Host.h:231 + /// Run a shell command. + /// \arg process_info The info structure for the process queried. Stale comment, I'll update CHANGES SINCE LAST

[Lldb-commits] [PATCH] D82813: [Apple Silicon] Rewrite part of the Rosetta support to be confined in Apple specific files

2020-06-29 Thread Davide Italiano via Phabricator via lldb-commits
davide created this revision. davide added reviewers: aprantl, jasonmolenda. Nothing crazy here, just an organizational cleanup. https://reviews.llvm.org/D82813 Files: lldb/include/lldb/Host/Host.h lldb/source/Host/common/Host.cpp lldb/source/Host/macosx/objcxx/Host.mm lldb/source/Plugi

[Lldb-commits] [PATCH] D82813: [Apple Silicon] Rewrite part of the Rosetta support to be confined in Apple specific files

2020-06-29 Thread Davide Italiano via Phabricator via lldb-commits
davide marked an inline comment as done. davide added inline comments. Comment at: lldb/include/lldb/Host/Host.h:231 + /// Check whether a process is translated (Rosetta). + /// \arg process_info The info structure for the process queried. aprantl wrote: > Is

[Lldb-commits] [PATCH] D82813: [Apple Silicon] Rewrite part of the Rosetta support to be confined in Apple specific files

2020-06-30 Thread Pavel Labath via Phabricator via lldb-commits
labath added inline comments. Comment at: lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp:3424 +if (Host::IsProcessTranslated(process_info)) { + FileSpec rosetta_debugserver("/Library/Apple/usr/libexec/oah/debugserver"); + debugserver_launch_info.SetExe

[Lldb-commits] [PATCH] D82813: [Apple Silicon] Rewrite part of the Rosetta support to be confined in Apple specific files

2020-06-30 Thread Davide Italiano via Phabricator via lldb-commits
davide marked an inline comment as done. davide added inline comments. Comment at: lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp:3424 +if (Host::IsProcessTranslated(process_info)) { + FileSpec rosetta_debugserver("/Library/Apple/usr/libexec/oah/debugserver

[Lldb-commits] [PATCH] D82813: [Apple Silicon] Rewrite part of the Rosetta support to be confined in Apple specific files

2020-06-30 Thread Adrian Prantl via Phabricator via lldb-commits
aprantl added inline comments. Comment at: lldb/include/lldb/Host/Host.h:231 + /// Check whether a process is translated (Rosetta). + /// \arg process_info The info structure for the process queried. davide wrote: > aprantl wrote: > > Is this supposed to be a

[Lldb-commits] [PATCH] D82813: [Apple Silicon] Rewrite part of the Rosetta support to be confined in Apple specific files

2020-06-30 Thread Pavel Labath via Phabricator via lldb-commits
labath added inline comments. Comment at: lldb/include/lldb/Host/Host.h:231 + /// Check whether a process is translated (Rosetta). + /// \arg process_info The info structure for the process queried. aprantl wrote: > davide wrote: > > aprantl wrote: > > > Is t

[Lldb-commits] [PATCH] D82813: [Apple Silicon] Rewrite part of the Rosetta support to be confined in Apple specific files

2020-07-01 Thread Adrian Prantl via Phabricator via lldb-commits
aprantl added inline comments. Comment at: lldb/include/lldb/Host/Host.h:231 + /// Check whether a process is translated (Rosetta). + /// \arg process_info The info structure for the process queried. labath wrote: > aprantl wrote: > > davide wrote: > > > apra

[Lldb-commits] [PATCH] D82813: [Apple Silicon] Rewrite part of the Rosetta support to be confined in Apple specific files

2020-07-01 Thread Adrian Prantl via Phabricator via lldb-commits
aprantl accepted this revision. aprantl added a comment. This revision is now accepted and ready to land. From my side this is good to go once everybody else's concerns are addressed. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82813/new/ https://reviews.llvm.org/D82813 ___

[Lldb-commits] [PATCH] D82813: [Apple Silicon] Rewrite part of the Rosetta support to be confined in Apple specific files

2020-09-03 Thread Davide Italiano via Phabricator via lldb-commits
davide closed this revision. davide added a comment. Somebody will pick this up, probably in a different form. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82813/new/ https://reviews.llvm.org/D82813 ___ lldb-commits mailing list lldb-commits