[Lldb-commits] [PATCH] D82863: [LLDB] Add support to resize SVE registers at run-time

This revision was automatically updated to reflect the committed changes. Closed by commit rGe448ad787e16: [LLDB] Add support to resize SVE registers at run-time (authored by omjavaid). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D82863: [LLDB] Add support to resize SVE registers at run-time

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Looks good, thanks. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82863/new/ https://reviews.llvm.org/D82863 ___ lldb-commits mailing

[Lldb-commits] [PATCH] D82863: [LLDB] Add support to resize SVE registers at run-time

omjavaid updated this revision to Diff 317036. omjavaid added a comment. @labath incorporated your suggestion. Good for commit? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82863/new/ https://reviews.llvm.org/D82863 Files:

[Lldb-commits] [PATCH] D82863: [LLDB] Add support to resize SVE registers at run-time

labath added a comment. Thanks for your patience. I think this is in a pretty good shape now. Just a couple of quick questions inline... Comment at: lldb/source/Plugins/Process/gdb-remote/GDBRemoteRegisterContext.cpp:410 + if (success && do_reconfigure_arm64_sve &&

[Lldb-commits] [PATCH] D82863: [LLDB] Add support to resize SVE registers at run-time

omjavaid added a comment. @labath ping! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82863/new/ https://reviews.llvm.org/D82863 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D82863: [LLDB] Add support to resize SVE registers at run-time

omjavaid updated this revision to Diff 314327. omjavaid added a comment. @labath I have incorporated your suggestions in this update. Invalidate all registers as SVE size update is not a high frequency occurrence. Also using same logic for offset calculation as we did

[Lldb-commits] [PATCH] D82863: [LLDB] Add support to resize SVE registers at run-time

labath added inline comments. Comment at: lldb/source/Plugins/Process/gdb-remote/GDBRemoteRegisterContext.cpp:792-793 + } + reg.byte_offset = end_reg_offset; + end_reg_offset += reg.byte_size; +} We already have a mostly generic algorithm for

[Lldb-commits] [PATCH] D82863: [LLDB] Add support to resize SVE registers at run-time

omjavaid added a comment. Herald added a subscriber: NickHung. ping! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82863/new/ https://reviews.llvm.org/D82863 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D82863: [LLDB] Add support to resize SVE registers at run-time

omjavaid updated this revision to Diff 308341. omjavaid added a comment. Updated after re-base over D91241 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82863/new/ https://reviews.llvm.org/D82863 Files:

[Lldb-commits] [PATCH] D82863: [LLDB] Add support to resize SVE registers at run-time

omjavaid updated this revision to Diff 304726. omjavaid added a comment. This update addresses comments about last revision. Also sending offset field in qRegisterInfo and XML register description has been disabled D91241 CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D82863: [LLDB] Add support to resize SVE registers at run-time

labath added a comment. In D82863#2375525 , @omjavaid wrote: > GDB does not have pseudo registers as part of xml register description. GDB > is managing pseudo registers on client side and independent of rest of the > register set. In case of SVE Z

[Lldb-commits] [PATCH] D82863: [LLDB] Add support to resize SVE registers at run-time

omjavaid updated this revision to Diff 303786. omjavaid added a comment. This updates after remove invalidate_regs from primary registers D91057 . Currently only SVE Z registers had invalidate_reg list populated which has been removed to send less information

[Lldb-commits] [PATCH] D82863: [LLDB] Add support to resize SVE registers at run-time

omjavaid updated this revision to Diff 303052. omjavaid added a comment. This updates after discussion yesterday. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82863/new/ https://reviews.llvm.org/D82863 Files: lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux_arm64.cpp

[Lldb-commits] [PATCH] D82863: [LLDB] Add support to resize SVE registers at run-time

omjavaid added a comment. In D82863#2373557 , @labath wrote: > [ I've replying to your message in a slightly different order that what it > was written. ] > > In D82863#2373356 , @omjavaid wrote: > >> In

[Lldb-commits] [PATCH] D82863: [LLDB] Add support to resize SVE registers at run-time

labath added a comment. [ I've replying to your message in a slightly different order that what it was written. ] In D82863#2373356 , @omjavaid wrote: > In D82863#2373276 , @labath wrote: > >> I'd like to avoid

[Lldb-commits] [PATCH] D82863: [LLDB] Add support to resize SVE registers at run-time

omjavaid added a comment. In D82863#2373276 , @labath wrote: > I'm sorry about the delay, I was having trouble finding the time to think > this through... > > In D82863#2342112 , @omjavaid wrote: > >> In

[Lldb-commits] [PATCH] D82863: [LLDB] Add support to resize SVE registers at run-time

labath added a comment. I'm sorry about the delay, I was having trouble finding the time to think this through... In D82863#2342112 , @omjavaid wrote: > In D82863#2341628 , @labath wrote: > >> I'm afraid I don't

[Lldb-commits] [PATCH] D82863: [LLDB] Add support to resize SVE registers at run-time

omjavaid updated this revision to Diff 302794. omjavaid added a comment. This update tries to mitigate effects of fixed offset fields in LLDB register description. We have now replaced Arm64 register infos on lldb-server side to generate offsets which increase with respect to size in increasing

[Lldb-commits] [PATCH] D82863: [LLDB] Add support to resize SVE registers at run-time

omjavaid added a comment. In D82863#2341628 , @labath wrote: > I'm afraid I don't understand what you mean. Could you try to be more > specific? > > It's true that currently lldb client uses the register offsets provided by > the server (if they are

[Lldb-commits] [PATCH] D82863: [LLDB] Add support to resize SVE registers at run-time

labath added a comment. I'm afraid I don't understand what you mean. Could you try to be more specific? It's true that currently lldb client uses the register offsets provided by the server (if they are present), and this is a divergence from pure gdb-remote. Were it not for variable-sized

[Lldb-commits] [PATCH] D82863: [LLDB] Add support to resize SVE registers at run-time

omjavaid added a comment. In D82863#2334664 , @labath wrote: > In D82863#2331892 , @omjavaid wrote: > >> In D82863#2330122 , @labath wrote: >> >>> I started drafting an

[Lldb-commits] [PATCH] D82863: [LLDB] Add support to resize SVE registers at run-time

labath added a comment. In D82863#2331892 , @omjavaid wrote: > In D82863#2330122 , @labath wrote: > >> I started drafting an email to the gdb mailing list to try to clarify this >> thing. For that, I was

[Lldb-commits] [PATCH] D82863: [LLDB] Add support to resize SVE registers at run-time

labath added a comment. In D82863#2324560 , @omjavaid wrote: > In D82863#2321647 , @labath wrote: > >> In D82863#2321370 , @omjavaid wrote: >> >>> In D82863#2320342

[Lldb-commits] [PATCH] D82863: [LLDB] Add support to resize SVE registers at run-time

omjavaid added a comment. In D82863#2321647 , @labath wrote: > In D82863#2321370 , @omjavaid wrote: > >> In D82863#2320342 , @jasonmolenda >> wrote: >> >>> The original g/G

[Lldb-commits] [PATCH] D82863: [LLDB] Add support to resize SVE registers at run-time

labath added a comment. In D82863#2321370 , @omjavaid wrote: > In D82863#2320342 , @jasonmolenda > wrote: > >> The original g/G packets were designed for little embedded systems where the >> stub had to be very

[Lldb-commits] [PATCH] D82863: [LLDB] Add support to resize SVE registers at run-time

omjavaid added a comment. In D82863#2320342 , @jasonmolenda wrote: > In D82863#2319568 , @labath wrote: > >> In D82863#2313676 , @jasonmolenda >> wrote: >> >>> (about g

[Lldb-commits] [PATCH] D82863: [LLDB] Add support to resize SVE registers at run-time

jasonmolenda added a comment. In D82863#2319568 , @labath wrote: > In D82863#2313676 , @jasonmolenda > wrote: > >> (about g packets...) they cause so many problems if there is a >> mis-coordination between the

[Lldb-commits] [PATCH] D82863: [LLDB] Add support to resize SVE registers at run-time

labath added a comment. I haven't looked at the new version of the patch yet, partly because I'm busy (sorry), and partly because I'm not sure we have reached a consensus yet (or at least, I don't know what that consensus is). Here's some questions/comments to what was earlier said, as I try

[Lldb-commits] [PATCH] D82863: [LLDB] Add support to resize SVE registers at run-time

omjavaid added a comment. HI @labath Do you have any comments or suggestions for this patch? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82863/new/ https://reviews.llvm.org/D82863 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D82863: [LLDB] Add support to resize SVE registers at run-time

omjavaid added inline comments. Comment at: lldb/source/Plugins/Process/gdb-remote/GDBRemoteRegisterContext.cpp:767 + m_reg_data.Clear(); + m_reg_data.SetData(reg_data_sp); + m_reg_data.SetByteOrder(GetByteOrder()); jasonmolenda wrote: > I'm

[Lldb-commits] [PATCH] D82863: [LLDB] Add support to resize SVE registers at run-time

omjavaid updated this revision to Diff 296811. omjavaid added a comment. This is an update after addressing comments from @jasonmolenda CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82863/new/ https://reviews.llvm.org/D82863 Files:

[Lldb-commits] [PATCH] D82863: [LLDB] Add support to resize SVE registers at run-time

jasonmolenda added a comment. Hey all, got distracted while reading the patch and jotted a few notes, but I know that's not as much what Pavel wanted to discuss. We already have some target specific goop in these ProcessGDBRemote type classes for registers and such, this doesn't cause my

[Lldb-commits] [PATCH] D82863: [LLDB] Add support to resize SVE registers at run-time

omjavaid added a comment. @labath I am just back from holiday and was hoping for Jason to give his advice in this. I am wondering how we can move forward on this. I have added a some information from GDB inline. In D82863#2254423 , @labath wrote: > I'd

[Lldb-commits] [PATCH] D82863: [LLDB] Add support to resize SVE registers at run-time

labath added a reviewer: jasonmolenda. labath added a comment. I'd like to also pull in Jason for this, since this is really the trickiest part of the whole patchset. What this patch essentially does is bake in the knowledge of the arm sve registers and their various configurations into the

[Lldb-commits] [PATCH] D82863: [LLDB] Add support to resize SVE registers at run-time

omjavaid added a comment. @labath ping! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82863/new/ https://reviews.llvm.org/D82863 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D82863: [LLDB] Add support to resize SVE registers at run-time

omjavaid added a comment. @labath ping! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82863/new/ https://reviews.llvm.org/D82863 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D82863: [LLDB] Add support to resize SVE registers at run-time

omjavaid created this revision. omjavaid added a reviewer: labath. Herald added a subscriber: tschuett. Herald added a reviewer: rengolin. omjavaid added parent revisions: D82853: [LLDB] Support custom expedited register set in gdb-remote, D82855: [LLDB] Send SVE vg register in custom expedited