[Lldb-commits] [PATCH] D86497: [lldb] Add reproducer verifier

This revision was automatically updated to reflect the committed changes. Closed by commit rG3746906193c1: [lldb] Add reproducer verifier (authored by JDevlieghere). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86497/new/

[Lldb-commits] [PATCH] D86497: [lldb] Add reproducer verifier

JDevlieghere added a comment. Thanks, should be fixed by 426fa35b655ffb8647d9d69580a69627c0d19024 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86497/new/

[Lldb-commits] [PATCH] D86497: [lldb] Add reproducer verifier

davezarzycki added a comment. And just to be clear, the source directory in my setup is in the home directory. My cron job / "bot" build just builds in /tmp. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86497/new/ https://reviews.llvm.org/D86497

[Lldb-commits] [PATCH] D86497: [lldb] Add reproducer verifier

davezarzycki added a comment. Line 18 fails: `%lldb -x -b --replay %t.repro >> %t.txt 2>&1` error: reproducer replay failed: warning: home directory '/home/dave' not in VFS I tried rebuilding in my home directory as opposed to /tmp and the error went away. Did you try building outside of

[Lldb-commits] [PATCH] D86497: [lldb] Add reproducer verifier

JDevlieghere added a comment. In D86497#2248934 , @davezarzycki wrote: > Hello. I have an auto-bisecting multi-stage bot that has identified this > change as breaking release (without assertions) testing on Fedora 33 x86-64. > Can we get a quick fix or

[Lldb-commits] [PATCH] D86497: [lldb] Add reproducer verifier

teemperor reopened this revision. teemperor added a comment. This revision is now accepted and ready to land. Don't see an obvious fix, so I reverted for Jonas in 7c80f2da812e45bbdfa3c8f9ab24440f8ef3362a Repository: rG

[Lldb-commits] [PATCH] D86497: [lldb] Add reproducer verifier

davezarzycki added a comment. Hello. I have an auto-bisecting multi-stage bot that has identified this change as breaking release (without assertions) testing on Fedora 33 x86-64. Can we get a quick fix or revert this change for now? FAIL: lldb-shell ::

[Lldb-commits] [PATCH] D86497: [lldb] Add reproducer verifier

This revision was automatically updated to reflect the committed changes. JDevlieghere marked an inline comment as done. Closed by commit rG297f69afac58: [lldb] Add reproducer verifier (authored by JDevlieghere). Herald added a project: LLDB. Changed prior to commit:

[Lldb-commits] [PATCH] D86497: [lldb] Add reproducer verifier

JDevlieghere marked an inline comment as done. JDevlieghere added inline comments. Comment at: lldb/source/Utility/Reproducer.cpp:337 + } else { +llvm::consumeError(symbol_files.takeError()); + } teemperor wrote: > Maybe log the error to llvm::errs? Or is

[Lldb-commits] [PATCH] D86497: [lldb] Add reproducer verifier

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. One nit about naming and another small thing, but otherwise this LGTM. Comment at: lldb/include/lldb/Utility/Reproducer.h:242 +struct ReplayOptions { + bool

[Lldb-commits] [PATCH] D86497: [lldb] Add reproducer verifier

JDevlieghere updated this revision to Diff 288051. JDevlieghere added a comment. - Address code review feedback - Run the verifier when replaying a reproducer - Add SBReplayOptions instead of adding another overload - Add `--reproducer-skip-verify` flag CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D86497: [lldb] Add reproducer verifier

teemperor requested changes to this revision. teemperor added a comment. This revision now requires changes to proceed. As discussed offline, I think the warnings here seem also useful when just replaying. I guess we should make it clear that things like missing files are fine when replaying a

[Lldb-commits] [PATCH] D86497: [lldb] Add reproducer verifier

JDevlieghere updated this revision to Diff 287713. JDevlieghere added a comment. - Make CHECK-line more specific CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86497/new/ https://reviews.llvm.org/D86497 Files: lldb/include/lldb/Utility/ReproducerProvider.h

[Lldb-commits] [PATCH] D86497: [lldb] Add reproducer verifier

JDevlieghere updated this revision to Diff 287710. JDevlieghere added a comment. Herald added a subscriber: ormris. - Add tests - Extract common code from `CommandObjectReproducerDump` and `CommandObjectReproducerVerify` into `GetLoaderFromPathOrCurrent` - Address code review feedback CHANGES

[Lldb-commits] [PATCH] D86497: [lldb] Add reproducer verifier

JDevlieghere added inline comments. Comment at: lldb/source/Commands/CommandObjectReproducer.cpp:670 +auto error_callback = [&](llvm::StringRef error) { + result.AppendError(error); +}; kastiglione wrote: > Is this lambda missing an assignment to

[Lldb-commits] [PATCH] D86497: [lldb] Add reproducer verifier

kastiglione added inline comments. Comment at: lldb/source/Commands/CommandObjectReproducer.cpp:670 +auto error_callback = [&](llvm::StringRef error) { + result.AppendError(error); +}; Is this lambda missing an assignment to `errors`? Repository:

[Lldb-commits] [PATCH] D86497: [lldb] Add reproducer verifier

JDevlieghere added a comment. This will require a test and maybe some code deduplication in `CommandObjectReproducer` but I already wanted to put the patch up in case I can't get to that today. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86497/new/

[Lldb-commits] [PATCH] D86497: [lldb] Add reproducer verifier

JDevlieghere created this revision. JDevlieghere added reviewers: LLDB, labath. Herald added subscribers: llvm-commits, dang, hiraditya. Herald added a project: LLVM. JDevlieghere requested review of this revision. Add a reproducer verifier that catches: - Missing or invalid home directory -