This revision was automatically updated to reflect the committed changes.
Closed by commit rG9ad5d37fd917: [lldb] Correct wording of EXP_MSG (authored by
DavidSpickett).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D86603/new/
teemperor added a comment.
That's true, `EXP_MSG` is not used like the other messages so the only problem
with it is the confusing error message.
IMHO this is still good to land as it improves the error message. If you want
to implement Pavel's much nicer error message in a follow-up patch,
DavidSpickett added a comment.
Ok to land this as is just to remove some confusion?
I agree it could be much improved, I'll look into that.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D86603/new/
https://reviews.llvm.org/D86603
labath added a comment.
Though these extra messages are often superfluous in general, I don't think
that's the case for this particular message. This macro is only used in the
`expect` and `match` checks. These are the most common way of asserting
something right now, so I think it's
teemperor accepted this revision.
teemperor added a comment.
This revision is now accepted and ready to land.
FWIW, I actually think this patch itself is perfectly fine. As these messages
are only displayed when an assert failed they should be worded with the
assumption that the assert did
teemperor added a reviewer: LLDB.
teemperor added a comment.
If you look at the other "assert messages" above and below your patch you'll
see that all (most?) of them use this very confusing "Say the opposite of what
actually happened" style. Weirdly enough only around 70% of the "assertion
DavidSpickett created this revision.
Herald added a project: LLDB.
Herald added a subscriber: lldb-commits.
DavidSpickett requested review of this revision.
Herald added a subscriber: JDevlieghere.
EXP_MSG generates a message to show on assert
failure. Currently it looks like:
AssertionError:
