labath added a comment.
Not long ago. I added a `MCBasedABI` class which makes this goo mostly
disappear as it gets its information from llvm MC layer. I haven't converted
the mips abi due to a combination of being preempted by higher priority task,
not having a mips machine to test on, and
teemperor added a comment.
Yeah, this is just to prevent the MIPS backend from hitting the assert (well,
and get the related code to actually do what it's supposed to do). This whole
code on my "to refactor" list.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
JDevlieghere added a comment.
Instead of copy-pasting this code can we extract a helper and call it with
`g_register_infos_mips64` and `g_register_infos` respectively?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D88375/new/
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rGe779427757f2: Fix MIPS and MIPS64 ABI to use ConstString in
their register info arrays. (authored by tatsuo, committed by teemperor).
Repository:
teemperor added a comment.
Done. Thanks for the patch!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D88375/new/
https://reviews.llvm.org/D88375
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
tatsuo added a comment.
@teemperor Thanks for the quick review and context!
I don't have commit access, that'd be great if you could merge it in.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D88375/new/
https://reviews.llvm.org/D88375
teemperor accepted this revision.
teemperor added a comment.
This revision is now accepted and ready to land.
To clarify the description a bit: `RegInfoBasedABI::GetRegisterInfoByName` is
comparing the name/alt_name by doing a `const char *` pointer value comparison.
That only works if both
tatsuo created this revision.
tatsuo added reviewers: LLDB, jasonmolenda.
Herald added subscribers: lldb-commits, atanasyan, jrtc27, arichardson, sdardis.
Herald added a project: LLDB.
tatsuo requested review of this revision.
Herald added a subscriber: JDevlieghere.
