This revision was not accepted when it landed; it landed in state "Needs
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit rGcf245086518e: Add support for more OS types to
AddClangModuleCompilationOptionsForSDKType() (authored by aprantl).
Herald
aprantl added inline comments.
Comment at: lldb/source/Plugins/Platform/MacOSX/PlatformDarwin.cpp:1525
+ // If the SDK type is for the host OS, use its version number.
+ auto get_host_os = []() { return HostInfo::GetTargetTriple().getOS(); };
switch (sdk_type) {
aprantl updated this revision to Diff 298453.
aprantl added a comment.
Address review feedback
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D89428/new/
https://reviews.llvm.org/D89428
Files:
lldb/source/Plugins/Platform/MacOSX/PlatformDarwin.cpp
Index:
teemperor added a comment.
Thanks for refactoring this!
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D89428/new/
https://reviews.llvm.org/D89428
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
teemperor requested changes to this revision.
teemperor added inline comments.
This revision now requires changes to proceed.
Comment at: lldb/source/Plugins/Platform/MacOSX/PlatformDarwin.cpp:1525
+ // If the SDK type is for the host OS, use its version number.
+ auto
aprantl created this revision.
aprantl added reviewers: JDevlieghere, teemperor.
aprantl requested review of this revision.
[This is upstreaming an Apple Silicon support patch rdar://problem/66927829]
This patch also avoids hardcoding the clang options, which makes it less likely
for them to
