[Lldb-commits] [PATCH] D93481: [lldb/Lua] add support for multiline scripted breakpoints

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd853bd7a4e86: [lldb/Lua] add support for multiline scripted breakpoints (authored by tammela). Repository: rG LLVM Github Monorepo CHANGES SINCE

[Lldb-commits] [PATCH] D93481: [lldb/Lua] add support for multiline scripted breakpoints

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. This looks better. I haven't checked the rest of the patch in detail, but it seems ok at a quick glance and Jonas appeared to be happy with it. Repository: rG LLVM Github Monorepo CHANGES

[Lldb-commits] [PATCH] D93481: [lldb/Lua] add support for multiline scripted breakpoints

tammela added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93481/new/ https://reviews.llvm.org/D93481 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi

[Lldb-commits] [PATCH] D93481: [lldb/Lua] add support for multiline scripted breakpoints

tammela added inline comments. Comment at: lldb/source/Plugins/ScriptInterpreter/Lua/Lua.h:39 llvm::Error LoadModule(llvm::StringRef filename); + llvm::Error LoadBuffer(llvm::StringRef buffer, bool pop_result = true); llvm::Error ChangeIO(FILE *out, FILE *err); ---

[Lldb-commits] [PATCH] D93481: [lldb/Lua] add support for multiline scripted breakpoints

tammela updated this revision to Diff 313870. tammela added a comment. Addressing comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93481/new/ https://reviews.llvm.org/D93481 Files: lldb/source/Plugins/ScriptInterpreter/Lua/Lua.cpp lldb/s

[Lldb-commits] [PATCH] D93481: [lldb/Lua] add support for multiline scripted breakpoints

labath added inline comments. Comment at: lldb/source/Plugins/ScriptInterpreter/Lua/Lua.h:39 llvm::Error LoadModule(llvm::StringRef filename); + llvm::Error LoadBuffer(llvm::StringRef buffer, bool pop_result = true); llvm::Error ChangeIO(FILE *out, FILE *err);

[Lldb-commits] [PATCH] D93481: [lldb/Lua] add support for multiline scripted breakpoints

tammela added inline comments. Comment at: lldb/source/Plugins/ScriptInterpreter/Lua/Lua.h:39 llvm::Error LoadModule(llvm::StringRef filename); + llvm::Error LoadBuffer(llvm::StringRef buffer, bool pop_result = true); llvm::Error ChangeIO(FILE *out, FILE *err); ---

[Lldb-commits] [PATCH] D93481: [lldb/Lua] add support for multiline scripted breakpoints

labath added inline comments. Comment at: lldb/source/Plugins/ScriptInterpreter/Lua/Lua.h:39 llvm::Error LoadModule(llvm::StringRef filename); + llvm::Error LoadBuffer(llvm::StringRef buffer, bool pop_result = true); llvm::Error ChangeIO(FILE *out, FILE *err);

[Lldb-commits] [PATCH] D93481: [lldb/Lua] add support for multiline scripted breakpoints

tammela added inline comments. Comment at: lldb/source/Plugins/ScriptInterpreter/Lua/ScriptInterpreterLua.cpp:62 +case eIOHandlerWatchpoint: + break; +case eIOHandlerBreakpoint: JDevlieghere wrote: > Shouldn't this be the same for break- and watchpo

[Lldb-commits] [PATCH] D93481: [lldb/Lua] add support for multiline scripted breakpoints

tammela updated this revision to Diff 312942. tammela added a comment. Addressing comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93481/new/ https://reviews.llvm.org/D93481 Files: lldb/source/Plugins/ScriptInterpreter/Lua/Lua.cpp lldb/s

[Lldb-commits] [PATCH] D93481: [lldb/Lua] add support for multiline scripted breakpoints

JDevlieghere added a comment. Thanks Pedro, it's really great to see the Lua interpreter getting all these improvements! Comment at: lldb/source/Plugins/ScriptInterpreter/Lua/ScriptInterpreterLua.cpp:62 +case eIOHandlerWatchpoint: + break; +case eIOHandlerBreakpo

[Lldb-commits] [PATCH] D93481: [lldb/Lua] add support for multiline scripted breakpoints

tammela created this revision. tammela requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. 1 - Partial Statements The interpreter loop runs every line it receives, so partial Lua statements are not being handled properly. This is a problem for