[Lldb-commits] [PATCH] D94888: [lldb] Add -Wl, -rpath to make tests run with fresh built libc++

This revision was automatically updated to reflect the committed changes. Closed by commit rG50830e50031b: [lldb] Add -Wl,-rpath to make tests run with fresh built libc++ (authored by MaskRay). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D94888: [lldb] Add -Wl, -rpath to make tests run with fresh built libc++

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Let's give this a shot. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94888/new/ https://reviews.llvm.org/D94888

[Lldb-commits] [PATCH] D94888: [lldb] Add -Wl, -rpath to make tests run with fresh built libc++

MaskRay updated this revision to Diff 318546. MaskRay added a comment. Drop fancy check in dotest.py (restore the previous behavior) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94888/new/ https://reviews.llvm.org/D94888 Files:

[Lldb-commits] [PATCH] D94888: [lldb] Add -Wl, -rpath to make tests run with fresh built libc++

labath added a comment. In D94888#2511675 , @rupprecht wrote: > In D94888#2506140 , @labath wrote: > >> I am pretty sure they were. This flag is needed to use (system) libc++ with >> gcc, and this was happening at

[Lldb-commits] [PATCH] D94888: [lldb] Add -Wl, -rpath to make tests run with fresh built libc++

MaskRay updated this revision to Diff 318414. MaskRay marked an inline comment as done. MaskRay added a comment. Adopt rupprecht's suggestion Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94888/new/ https://reviews.llvm.org/D94888 Files:

[Lldb-commits] [PATCH] D94888: [lldb] Add -Wl, -rpath to make tests run with fresh built libc++

rupprecht added a comment. In D94888#2506140 , @labath wrote: > In D94888#2506000 , @MaskRay wrote: > >> In D94888#2505992 , @labath wrote: >> >>> It looks like this is

[Lldb-commits] [PATCH] D94888: [lldb] Add -Wl, -rpath to make tests run with fresh built libc++

MaskRay updated this revision to Diff 317599. MaskRay added a comment. Delete `if os.path.isdir("/usr/include/c++/v1"):` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94888/new/ https://reviews.llvm.org/D94888 Files:

[Lldb-commits] [PATCH] D94888: [lldb] Add -Wl, -rpath to make tests run with fresh built libc++

labath added a comment. In D94888#2506000 , @MaskRay wrote: > In D94888#2505992 , @labath wrote: > >> It looks like this is removing the ability to build libc++ tests with gcc >> (as it does not have the `-stdlib`

[Lldb-commits] [PATCH] D94888: [lldb] Add -Wl, -rpath to make tests run with fresh built libc++

MaskRay added a comment. In D94888#2505992 , @labath wrote: > It looks like this is removing the ability to build libc++ tests with gcc (as > it does not have the `-stdlib` option). While having that ability would be > nice, I don't believe there's

[Lldb-commits] [PATCH] D94888: [lldb] Add -Wl, -rpath to make tests run with fresh built libc++

labath added a comment. In D94888#2505698 , @dblaikie wrote: > Out of curiousity did you find a way to get lldb-test to print out the > stdout/stderr of the underlying lldb process to see what error messages it > was producing that demonstrated this

[Lldb-commits] [PATCH] D94888: [lldb] Add -Wl, -rpath to make tests run with fresh built libc++

labath added a comment. It looks like this is removing the ability to build libc++ tests with gcc (as it does not have the `-stdlib` option). While having that ability would be nice, I don't believe there's anyone currently using that configuration, so it shouldn't stand in the way of other

[Lldb-commits] [PATCH] D94888: [lldb] Add -Wl, -rpath to make tests run with fresh built libc++

dblaikie added a comment. (Works for me, FWIW - takes my local run down from 42 failures in check-lldb-api to 1 (a timeout)) Out of curiousity did you find a way to get lldb-test to print out the stdout/stderr of the underlying lldb process to see what error messages it was producing that

[Lldb-commits] [PATCH] D94888: [lldb] Add -Wl, -rpath to make tests run with fresh built libc++

mgorny added a comment. You seem to be removing more than adding there. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94888/new/ https://reviews.llvm.org/D94888 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D94888: [lldb] Add -Wl, -rpath to make tests run with fresh built libc++

MaskRay created this revision. MaskRay added reviewers: dblaikie, labath, mgorny, rupprecht. Herald added a subscriber: krytarowski. MaskRay requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. On my Debian machine, system libc++/libc++abi is