DavidSpickett wrote:
What did you intend with `/H`? If anything it would be
https://learn.microsoft.com/en-us/cpp/build/reference/h-restrict-length-of-external-names?view=msvc-170
but clang-cl doesn't support this one.
(yes, the bot uses clang-cl, we really should change the name)
https://git
DavidSpickett wrote:
> If you have a recent build of lldb on windows (with python enabled), could
> you run the scripting template list command and paste the output here.
As of 229a16590a3cd65da77bb868498d3eed63bf6263:
```
C:\Users\tcwg\llvm-worker\lldb-aarch64-windows\build>.\bin\lldb.exe
(lld
medismailben wrote:
Hey @DavidSpickett! Thanks for the help! I don't have a system to try this on
and it only fails on windows :/
> Actually I'm looking at old results, the latest build makes it to tests
> https://lab.llvm.org/buildbot/#/builders/141/builds/1285 (which fail for
> reasons unre
DavidSpickett wrote:
Actually I'm looking at old results, the latest build makes it to tests
https://lab.llvm.org/buildbot/#/builders/141/builds/1285 (which fail for
reasons unrelated to this patch).
https://github.com/llvm/llvm-project/pull/97273
__
DavidSpickett wrote:
I thought I saw that fixed once already, but perhaps that was just a full
revert.
We (Linaro) can test a patch for you if it's fiddly to verify, we just need to
know the general idea of it.
https://github.com/llvm/llvm-project/pull/97273
__
zeroomega wrote:
Hi @medismailben
We are seeing redefinition of pid_t error again on windows builder:
https://lab.llvm.org/buildbot/#/builders/141/builds/1254
after multiple revert and reland like e72cdae47b4e263ea97b2bdd75cf44c1510cf3be.
Could you revert the change please? Could you also not
medismailben wrote:
> The reland broke the Fuchsia Windows build with a similar error to the LLVM
> Windows bots, but I wasn't able to cleanly revert this commit without
> detailed knowledge of the contents. Could you revert this (preferentially) or
> fix forward?
>
> https://luci-milo.appspo
mysterymath wrote:
The reland broke the Fuchsia Windows build with a similar error to the LLVM
Windows bots, but I wasn't able to cleanly revert this commit without detailed
knowledge of the contents. Could you revert this (preferentially) or fix
forward?
https://github.com/llvm/llvm-project/
https://github.com/medismailben updated
https://github.com/llvm/llvm-project/pull/97273
>From 52bdaaca9b1688eea7f5d20ceba50796f8816b77 Mon Sep 17 00:00:00 2001
From: Med Ismail Bennani
Date: Tue, 23 Jul 2024 10:14:41 -0700
Subject: [PATCH] [lldb/Commands] Add `scripting template list` command w
https://github.com/JDevlieghere approved this pull request.
LGTM modulo comment.
https://github.com/llvm/llvm-project/pull/97273
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere edited
https://github.com/llvm/llvm-project/pull/97273
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -127,6 +130,157 @@ class CommandObjectScriptingRun : public CommandObjectRaw
{
CommandOptions m_options;
};
+#pragma mark CommandObjectScriptingTemplateList
+
+#define LLDB_OPTIONS_scripting_template_list
+#include "CommandOptions.inc"
+
+class CommandObjectScriptingTemp
https://github.com/bulbazord approved this pull request.
LGTM, you'll probably want sign off from Jonas too though since he had a ton of
comments.
https://github.com/llvm/llvm-project/pull/97273
___
lldb-commits mailing list
lldb-commits@lists.llvm.or
https://github.com/medismailben updated
https://github.com/llvm/llvm-project/pull/97273
>From d40b66db50800e83ef2d9a74471e031fae1d78ae Mon Sep 17 00:00:00 2001
From: Med Ismail Bennani
Date: Mon, 22 Jul 2024 13:59:50 -0700
Subject: [PATCH] [lldb/Commands] Add `scripting template list` command w
https://github.com/medismailben updated
https://github.com/llvm/llvm-project/pull/97273
>From faa1aec645e26145467b94260df7ca3abc012f62 Mon Sep 17 00:00:00 2001
From: Med Ismail Bennani
Date: Wed, 17 Jul 2024 02:21:21 -0700
Subject: [PATCH] [lldb/Commands] Add `scripting template list` command w
@@ -127,9 +129,127 @@ class CommandObjectScriptingRun : public CommandObjectRaw
{
CommandOptions m_options;
};
-#pragma mark CommandObjectMultiwordScripting
+#define LLDB_OPTIONS_scripting_template_list
+#include "CommandOptions.inc"
+
+class CommandObjectScriptingTemplateL
@@ -329,6 +330,13 @@ class DynamicLoader : public PluginInterface {
/// safe to call certain APIs or SPIs.
virtual bool IsFullyInitialized() { return true; }
+ /// Return the `start` function \b symbol in the dynamic loader module.
+ /// This is the symbol the process wi
https://github.com/bulbazord edited
https://github.com/llvm/llvm-project/pull/97273
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/bulbazord commented:
Seems alright to me, left a few minor suggestions inline.
https://github.com/llvm/llvm-project/pull/97273
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo
https://github.com/medismailben updated
https://github.com/llvm/llvm-project/pull/97273
>From 16ef7297eef25d329631fd62d126bf7a7be24c4d Mon Sep 17 00:00:00 2001
From: Med Ismail Bennani
Date: Fri, 19 Jul 2024 11:08:39 -0700
Subject: [PATCH 1/2] [lldb/Target] Add GetStartSymbol method to DynamicL
https://github.com/medismailben updated
https://github.com/llvm/llvm-project/pull/97273
>From d812b8067d622b84af2ee62b837b87cb4479a477 Mon Sep 17 00:00:00 2001
From: Med Ismail Bennani
Date: Wed, 17 Jul 2024 02:21:21 -0700
Subject: [PATCH] [lldb/Commands] Add `scripting template list` command w
@@ -19,6 +19,12 @@ if (LLDB_ENABLE_LIBEDIT)
list(APPEND LLDB_LIBEDIT_LIBS LibEdit::LibEdit)
endif()
+set_property(GLOBAL PROPERTY LLDB_EXTRA_SCRIPT_PLUGINS
+ lldbPluginOperatingSystemPythonInterface
+ lldbPluginScriptedProcessPythonInterface
+ lldbPluginScriptedThreadPlan
@@ -19,6 +19,12 @@ if (LLDB_ENABLE_LIBEDIT)
list(APPEND LLDB_LIBEDIT_LIBS LibEdit::LibEdit)
endif()
+set_property(GLOBAL PROPERTY LLDB_EXTRA_SCRIPT_PLUGINS
+ lldbPluginOperatingSystemPythonInterface
+ lldbPluginScriptedProcessPythonInterface
+ lldbPluginScriptedThreadPlan
@@ -29,6 +29,9 @@ add_subdirectory(UnwindAssembly)
set(LLDB_STRIPPED_PLUGINS)
get_property(LLDB_ALL_PLUGINS GLOBAL PROPERTY LLDB_PLUGINS)
+get_property(LLDB_EXTRA_PLUGINS GLOBAL PROPERTY LLDB_EXTRA_SCRIPT_PLUGINS)
+list(APPEND LLDB_ALL_PLUGINS ${LLDB_EXTRA_PLUGINS})
--
@@ -127,6 +130,157 @@ class CommandObjectScriptingRun : public CommandObjectRaw
{
CommandOptions m_options;
};
+#pragma mark CommandObjectScriptingTemplateList
+
+#define LLDB_OPTIONS_scripting_template_list
+#include "CommandOptions.inc"
+
+class CommandObjectScriptingTemp
@@ -487,6 +487,33 @@ class PluginManager {
static LanguageSet GetAllTypeSystemSupportedLanguagesForExpressions();
+ // Scripted Interface
+ static bool
+ RegisterPlugin(llvm::StringRef name, llvm::StringRef description,
+ ScriptedInterfaceCreateInstance c
@@ -68,6 +68,13 @@ class ScriptedInterface {
return true;
}
+ static bool
+ CreateInstance(lldb::ScriptLanguage language,
+ std::vector command_interpreter_usages,
+ std::vector api_usages) {
+return false;
+ }
JDev
@@ -124,6 +124,10 @@ typedef lldb::REPLSP (*REPLCreateInstance)(Status &error,
lldb::LanguageType language,
Debugger *debugger, Target *target,
const
@@ -127,6 +130,157 @@ class CommandObjectScriptingRun : public CommandObjectRaw
{
CommandOptions m_options;
};
+#pragma mark CommandObjectScriptingTemplateList
+
+#define LLDB_OPTIONS_scripting_template_list
+#include "CommandOptions.inc"
+
+class CommandObjectScriptingTemp
@@ -29,6 +29,9 @@ add_subdirectory(UnwindAssembly)
set(LLDB_STRIPPED_PLUGINS)
get_property(LLDB_ALL_PLUGINS GLOBAL PROPERTY LLDB_PLUGINS)
+get_property(LLDB_EXTRA_PLUGINS GLOBAL PROPERTY LLDB_EXTRA_SCRIPT_PLUGINS)
+list(APPEND LLDB_ALL_PLUGINS ${LLDB_EXTRA_PLUGINS})
--
@@ -127,6 +130,157 @@ class CommandObjectScriptingRun : public CommandObjectRaw
{
CommandOptions m_options;
};
+#pragma mark CommandObjectScriptingTemplateList
+
+#define LLDB_OPTIONS_scripting_template_list
+#include "CommandOptions.inc"
+
+class CommandObjectScriptingTemp
@@ -487,6 +487,33 @@ class PluginManager {
static LanguageSet GetAllTypeSystemSupportedLanguagesForExpressions();
+ // Scripted Interface
+ static bool
+ RegisterPlugin(llvm::StringRef name, llvm::StringRef description,
+ ScriptedInterfaceCreateInstance c
@@ -127,6 +130,157 @@ class CommandObjectScriptingRun : public CommandObjectRaw
{
CommandOptions m_options;
};
+#pragma mark CommandObjectScriptingTemplateList
+
+#define LLDB_OPTIONS_scripting_template_list
+#include "CommandOptions.inc"
+
+class CommandObjectScriptingTemp
https://github.com/jimingham approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/97273
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/medismailben updated
https://github.com/llvm/llvm-project/pull/97273
>From bfffecd229e695e2f5b63e704e917a3585826b55 Mon Sep 17 00:00:00 2001
From: Med Ismail Bennani
Date: Tue, 2 Jul 2024 21:57:48 -0700
Subject: [PATCH] [lldb/Commands] Add `scripting template list` command wi
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff 4e567242133678c88a6cb5aeb979c6148f6a7035
54e2299fead40dba247c65ea4974a550843a9b6d --
https://github.com/medismailben updated
https://github.com/llvm/llvm-project/pull/97273
>From 54e2299fead40dba247c65ea4974a550843a9b6d Mon Sep 17 00:00:00 2001
From: Med Ismail Bennani
Date: Tue, 2 Jul 2024 21:42:49 -0700
Subject: [PATCH] [lldb/Commands] Add `scripting template list` command wi
https://github.com/medismailben updated
https://github.com/llvm/llvm-project/pull/97273
>From c475dcf4e57fbbaa0bc50da5103f1eb3a273e83a Mon Sep 17 00:00:00 2001
From: Med Ismail Bennani
Date: Tue, 2 Jul 2024 21:31:21 -0700
Subject: [PATCH] [lldb/Commands] Add `scripting template list` command wi
@@ -29,6 +29,9 @@ add_subdirectory(UnwindAssembly)
set(LLDB_STRIPPED_PLUGINS)
get_property(LLDB_ALL_PLUGINS GLOBAL PROPERTY LLDB_PLUGINS)
+get_property(LLDB_EXTRA_PLUGINS GLOBAL PROPERTY LLDB_EXTRA_SCRIPT_PLUGINS)
+list(APPEND LLDB_ALL_PLUGINS ${LLDB_EXTRA_PLUGINS})
--
@@ -841,6 +841,12 @@ let Command = "scripting run" in {
" language. If none is specific the default scripting language is used.">;
}
+let Command = "scripting template list" in {
+ def scripting_template_list_language : Option<"language", "l">,
+EnumArg<"ScriptLang">,
@@ -841,6 +841,12 @@ let Command = "scripting run" in {
" language. If none is specific the default scripting language is used.">;
}
+let Command = "scripting template list" in {
+ def scripting_template_list_language : Option<"language", "l">,
+EnumArg<"ScriptLang">,
@@ -127,6 +130,171 @@ class CommandObjectScriptingRun : public CommandObjectRaw
{
CommandOptions m_options;
};
+#pragma mark CommandObjectScriptingTemplateList
+
+#define LLDB_OPTIONS_scripting_template_list
+#include "CommandOptions.inc"
+
+class CommandObjectScriptingTemp
@@ -127,6 +130,171 @@ class CommandObjectScriptingRun : public CommandObjectRaw
{
CommandOptions m_options;
};
+#pragma mark CommandObjectScriptingTemplateList
+
+#define LLDB_OPTIONS_scripting_template_list
+#include "CommandOptions.inc"
+
+class CommandObjectScriptingTemp
@@ -127,6 +130,171 @@ class CommandObjectScriptingRun : public CommandObjectRaw
{
CommandOptions m_options;
};
+#pragma mark CommandObjectScriptingTemplateList
+
+#define LLDB_OPTIONS_scripting_template_list
+#include "CommandOptions.inc"
+
+class CommandObjectScriptingTemp
medismailben wrote:
FWIW, this is the output it's producing for now:
```
(lldb) scripting template list
Available scripted affordances:
Name: ScriptedProcessPythonInterface
Language: Python
Description: Mock process state
Command Interpreter Usages:
process attach -C [-k key -v valu
@@ -127,6 +130,171 @@ class CommandObjectScriptingRun : public CommandObjectRaw
{
CommandOptions m_options;
};
+#pragma mark CommandObjectScriptingTemplateList
+
+#define LLDB_OPTIONS_scripting_template_list
+#include "CommandOptions.inc"
+
+class CommandObjectScriptingTemp
@@ -127,6 +130,171 @@ class CommandObjectScriptingRun : public CommandObjectRaw
{
CommandOptions m_options;
};
+#pragma mark CommandObjectScriptingTemplateList
+
+#define LLDB_OPTIONS_scripting_template_list
+#include "CommandOptions.inc"
+
+class CommandObjectScriptingTemp
@@ -127,6 +130,171 @@ class CommandObjectScriptingRun : public CommandObjectRaw
{
CommandOptions m_options;
};
+#pragma mark CommandObjectScriptingTemplateList
+
+#define LLDB_OPTIONS_scripting_template_list
+#include "CommandOptions.inc"
+
+class CommandObjectScriptingTemp
@@ -127,6 +130,171 @@ class CommandObjectScriptingRun : public CommandObjectRaw
{
CommandOptions m_options;
};
+#pragma mark CommandObjectScriptingTemplateList
+
+#define LLDB_OPTIONS_scripting_template_list
+#include "CommandOptions.inc"
+
+class CommandObjectScriptingTemp
@@ -127,6 +130,171 @@ class CommandObjectScriptingRun : public CommandObjectRaw
{
CommandOptions m_options;
};
+#pragma mark CommandObjectScriptingTemplateList
+
+#define LLDB_OPTIONS_scripting_template_list
+#include "CommandOptions.inc"
+
+class CommandObjectScriptingTemp
@@ -29,6 +29,9 @@ add_subdirectory(UnwindAssembly)
set(LLDB_STRIPPED_PLUGINS)
get_property(LLDB_ALL_PLUGINS GLOBAL PROPERTY LLDB_PLUGINS)
+get_property(LLDB_EXTRA_PLUGINS GLOBAL PROPERTY LLDB_EXTRA_SCRIPT_PLUGINS)
+list(APPEND LLDB_ALL_PLUGINS ${LLDB_EXTRA_PLUGINS})
--
@@ -127,6 +130,171 @@ class CommandObjectScriptingRun : public CommandObjectRaw
{
CommandOptions m_options;
};
+#pragma mark CommandObjectScriptingTemplateList
+
+#define LLDB_OPTIONS_scripting_template_list
+#include "CommandOptions.inc"
+
+class CommandObjectScriptingTemp
@@ -127,6 +130,171 @@ class CommandObjectScriptingRun : public CommandObjectRaw
{
CommandOptions m_options;
};
+#pragma mark CommandObjectScriptingTemplateList
+
+#define LLDB_OPTIONS_scripting_template_list
+#include "CommandOptions.inc"
+
+class CommandObjectScriptingTemp
https://github.com/medismailben updated
https://github.com/llvm/llvm-project/pull/97273
>From 828d8e8c35eb5a3d0886c5d331a8a4aa466c2324 Mon Sep 17 00:00:00 2001
From: Med Ismail Bennani
Date: Mon, 1 Jul 2024 22:07:49 -0700
Subject: [PATCH] [lldb/Commands] Add `scripting template list` command wi
https://github.com/medismailben updated
https://github.com/llvm/llvm-project/pull/97273
>From 8e016c7aa66c4d5f7a90b5dc05b05c1838919177 Mon Sep 17 00:00:00 2001
From: Med Ismail Bennani
Date: Mon, 1 Jul 2024 12:00:04 -0700
Subject: [PATCH 1/2] [lldb/Commands] Alias `script` command to `scripting
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Med Ismail Bennani (medismailben)
Changes
This patch introduces a new `template` multiword sub-command to the
`scripting` top-level command. As the name suggests, this sub-command
operates on scripting templates, and currently has the abilit
medismailben wrote:
Depends on #97263
https://github.com/llvm/llvm-project/pull/97273
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/medismailben created
https://github.com/llvm/llvm-project/pull/97273
This patch introduces a new `template` multiword sub-command to the
`scripting` top-level command. As the name suggests, this sub-command
operates on scripting templates, and currently has the ability to
auto
58 matches
Mail list logo
