@@ -23,6 +23,8 @@ class Symtab {
public:
typedef std::vector IndexCollection;
typedef UniqueCStringMap NameToIndexMap;
+ typedef std::map
+ FileAddressToAddressClassMap;
DavidSpickett wrote:
Yes, we binary search it later. I will at least add a
DavidSpickett wrote:
Went with https://github.com/llvm/llvm-project/pull/91585 instead.
https://github.com/llvm/llvm-project/pull/91603
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://github.com/DavidSpickett closed
https://github.com/llvm/llvm-project/pull/91603
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -23,6 +23,8 @@ class Symtab {
public:
typedef std::vector IndexCollection;
typedef UniqueCStringMap NameToIndexMap;
+ typedef std::map
+ FileAddressToAddressClassMap;
labath wrote:
This code depends on the map being sorted, which densemap isn't.
@@ -23,6 +23,8 @@ class Symtab {
public:
typedef std::vector IndexCollection;
typedef UniqueCStringMap NameToIndexMap;
+ typedef std::map
+ FileAddressToAddressClassMap;
clayborg wrote:
You might want to use a llvm::DenseMap if possible. std::map
DavidSpickett wrote:
The only thing I can think of that breaks this is if some object wanted to use
the same symbol table section, but interpret it in a different way that changed
the address classes. I don't see any evidence of us doing that or needing to.
Even if we did it'd probably change
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: David Spickett (DavidSpickett)
Changes
Code in https://github.com/llvm/llvm-project/pull/90622 exposed a situation
where a symbol table may be loaded via a second copy of the same object.
This resulted in the first copy having its address
https://github.com/DavidSpickett created
https://github.com/llvm/llvm-project/pull/91603
Code in https://github.com/llvm/llvm-project/pull/90622 exposed a situation
where a symbol table may be loaded via a second copy of the same object.
This resulted in the first copy having its address
