[Lldb-commits] [lldb] [lldb] Add a setting to customize the prompt color (PR #66218)

2023-09-13 Thread Greg Clayton via lldb-commits
https://github.com/clayborg approved this pull request. https://github.com/llvm/llvm-project/pull/66218 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Add a setting to customize the prompt color (PR #66218)

2023-09-13 Thread Jonas Devlieghere via lldb-commits
JDevlieghere wrote: > can we wire up the ansi color formatting without supporting all these other > bits of data? Yes, but you'd still need to solve (1), (3) and (4) which are the "hard" ones. Doing what you suggests only saves you (2) which is by far the easiest one in the list.

[Lldb-commits] [lldb] [lldb] Add a setting to customize the prompt color (PR #66218)

2023-09-13 Thread Dave Lee via lldb-commits
kastiglione wrote: > You will need access to the debugger, target, process etc. Currently Editline > lives in Host, so we'd have to move that out into Core to avoid circular > dependencies. can we wire up the ansi color formatting without supporting all these other bits of data? if we're

[Lldb-commits] [lldb] [lldb] Add a setting to customize the prompt color (PR #66218)

2023-09-13 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere updated https://github.com/llvm/llvm-project/pull/66218: >From bb1941649714c424bbcaab6c14892657aab55c93 Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Wed, 13 Sep 2023 08:05:10 -0700 Subject: [PATCH] [lldb] Add a setting to customize the prompt color

[Lldb-commits] [lldb] [lldb] Add a setting to customize the prompt color (PR #66218)

2023-09-13 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere updated https://github.com/llvm/llvm-project/pull/66218: >From 9e3ccc3b7209ef92abedb3f7aa9b1ddd6687f410 Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Wed, 13 Sep 2023 08:05:10 -0700 Subject: [PATCH] [lldb] Add a setting to customize the prompt color

Re: [Lldb-commits] [lldb] [lldb] Add a setting to customize the prompt color (PR #66218)

2023-09-13 Thread Jim Ingham via lldb-commits
We actually have several requests for this internally, and I think that's a good idea. However, some of the format tokens can return arbitrary text, including newlines, for instance "thread.completed-expression", and all the "script." ones. Do we want to try to support prompts with

[Lldb-commits] [lldb] [lldb] Add a setting to customize the prompt color (PR #66218)

2023-09-13 Thread Greg Clayton via lldb-commits
https://github.com/clayborg commented: Any interest in just allowing "settings set prompt" to use the format strings approach that we support in thread-format, frame-format? I see we have a ton of settings that already ansi-prefix and ansi-suffix settings, but it would be easy to just do: ```

[Lldb-commits] [lldb] [lldb] Add a setting to customize the prompt color (PR #66218)

2023-09-13 Thread Jonas Devlieghere via lldb-commits
JDevlieghere wrote: Regarding the column width bug: it's something we'd want to fix anyway. I have a naive implementation [here](https://github.com/JDevlieghere/llvm-project/commit/17e7844547e8b8509014bc953545c76f3fd6eb25). Probably more important than the ANSI escape characters is UTF-8

[Lldb-commits] [lldb] [lldb] Add a setting to customize the prompt color (PR #66218)

2023-09-13 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Changes Users often want to change the look of their prompt and currently the only way to do that is by using ANSI escape codes in the prompt itself. This is not only tedious, it also results in extra whitespace because our Editline

[Lldb-commits] [lldb] [lldb] Add a setting to customize the prompt color (PR #66218)

2023-09-13 Thread via lldb-commits
https://github.com/llvmbot labeled https://github.com/llvm/llvm-project/pull/66218 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Add a setting to customize the prompt color (PR #66218)

2023-09-13 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere review_requested https://github.com/llvm/llvm-project/pull/66218 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Add a setting to customize the prompt color (PR #66218)

2023-09-13 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere created https://github.com/llvm/llvm-project/pull/66218: Users often want to change the look of their prompt and currently the only way to do that is by using ANSI escape codes in the prompt itself. This is not only tedious, it also results in extra whitespace