https://github.com/adrian-prantl closed
https://github.com/llvm/llvm-project/pull/74413
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/felipepiovezan approved this pull request.
https://github.com/llvm/llvm-project/pull/74413
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
PortalPete wrote:
> > > doesn't appear to be anything that calls these methods
> >
> >
> > Candidate for removal then? If so it still makes sense to fix them, then
> > remove them. Saves fixing them again if they are brought back.
> > Either way, I'm not going to block this by requiring a
adrian-prantl wrote:
> > doesn't appear to be anything that calls these methods
>
> Candidate for removal then? If so it still makes sense to fix them, then
> remove them. Saves fixing them again if they are brought back.
>
> Either way, I'm not going to block this by requiring a test case.
DavidSpickett wrote:
> doesn't appear to be anything that calls these methods
Candidate for removal then? If so it still makes sense to fix them, then remove
them. Saves fixing them again if they are brought back.
Either way, I'm not going to block this by requiring a test case.
https://github.com/PortalPete updated
https://github.com/llvm/llvm-project/pull/74413
>From 5731517e6453f9fc72577531bc3e2f745a8b9ca3 Mon Sep 17 00:00:00 2001
From: Pete Lawrence
Date: Mon, 4 Dec 2023 18:29:37 -1000
Subject: [PATCH] [lldb] Return index of element in ValueObject path instead of
@@ -414,13 +417,17 @@ lldb::ValueObjectSP ValueObject::GetChildAtIndexPath(
if (idxs.size() == 0)
return GetSP();
ValueObjectSP root(GetSP());
+
+ size_t current_index = 0;
for (std::pair idx : idxs) {
root = root->GetChildAtIndex(idx.first, idx.second);
PortalPete wrote:
> I can see why the mistake was made, we have an index into a list of different
> indexes? Anyway, please add a test for this.
I'm not really sure there's a good way to test this there doesn't appear to be
anything that calls these methods, let alone an SB API.
CC
@@ -414,13 +417,17 @@ lldb::ValueObjectSP ValueObject::GetChildAtIndexPath(
if (idxs.size() == 0)
return GetSP();
ValueObjectSP root(GetSP());
+
+ size_t current_index = 0;
for (std::pair idx : idxs) {
root = root->GetChildAtIndex(idx.first, idx.second);
@@ -398,13 +398,16 @@ ValueObject::GetChildAtIndexPath(llvm::ArrayRef
idxs,
if (idxs.size() == 0)
return GetSP();
ValueObjectSP root(GetSP());
+
+ size_t current_index = 0;
for (size_t idx : idxs) {
root = root->GetChildAtIndex(idx);
if (!root) {
https://github.com/PortalPete updated
https://github.com/llvm/llvm-project/pull/74413
>From 5d991726fbb22bc79336becc08b53b49dc87396d Mon Sep 17 00:00:00 2001
From: Pete Lawrence
Date: Mon, 4 Dec 2023 18:29:37 -1000
Subject: [PATCH] [lldb] Return index of element in ValueObject path instead of
https://github.com/PortalPete edited
https://github.com/llvm/llvm-project/pull/74413
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/felipepiovezan edited
https://github.com/llvm/llvm-project/pull/74413
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -414,13 +417,17 @@ lldb::ValueObjectSP ValueObject::GetChildAtIndexPath(
if (idxs.size() == 0)
return GetSP();
ValueObjectSP root(GetSP());
+
+ size_t current_index = 0;
for (std::pair idx : idxs) {
root = root->GetChildAtIndex(idx.first, idx.second);
@@ -398,13 +398,16 @@ ValueObject::GetChildAtIndexPath(llvm::ArrayRef
idxs,
if (idxs.size() == 0)
return GetSP();
ValueObjectSP root(GetSP());
+
+ size_t current_index = 0;
for (size_t idx : idxs) {
root = root->GetChildAtIndex(idx);
if (!root) {
https://github.com/PortalPete edited
https://github.com/llvm/llvm-project/pull/74413
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -414,13 +417,17 @@ lldb::ValueObjectSP ValueObject::GetChildAtIndexPath(
if (idxs.size() == 0)
return GetSP();
ValueObjectSP root(GetSP());
+
+ size_t current_index = 0;
for (std::pair idx : idxs) {
root = root->GetChildAtIndex(idx.first, idx.second);
@@ -398,13 +398,16 @@ ValueObject::GetChildAtIndexPath(llvm::ArrayRef
idxs,
if (idxs.size() == 0)
return GetSP();
ValueObjectSP root(GetSP());
+
+ size_t current_index = 0;
for (size_t idx : idxs) {
root = root->GetChildAtIndex(idx);
if (!root) {
https://github.com/PortalPete edited
https://github.com/llvm/llvm-project/pull/74413
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -414,13 +417,17 @@ lldb::ValueObjectSP ValueObject::GetChildAtIndexPath(
if (idxs.size() == 0)
return GetSP();
ValueObjectSP root(GetSP());
+
+ size_t current_index = 0;
for (std::pair idx : idxs) {
root = root->GetChildAtIndex(idx.first, idx.second);
felipepiovezan wrote:
Should we change the documentation of these functions?
https://github.com/llvm/llvm-project/pull/74413
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -398,13 +398,16 @@ ValueObject::GetChildAtIndexPath(llvm::ArrayRef
idxs,
if (idxs.size() == 0)
return GetSP();
ValueObjectSP root(GetSP());
+
+ size_t current_index = 0;
for (size_t idx : idxs) {
root = root->GetChildAtIndex(idx);
if (!root) {
DavidSpickett wrote:
I can see why the mistake was made, we have an index into a list of different
indexes? Anyway, please add a test for this.
https://github.com/llvm/llvm-project/pull/74413
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Pete Lawrence (PortalPete)
Changes
rdar://119169160
---
Full diff: https://github.com/llvm/llvm-project/pull/74413.diff
1 Files Affected:
- (modified) lldb/source/Core/ValueObject.cpp (+9-2)
``diff
diff --git
https://github.com/PortalPete ready_for_review
https://github.com/llvm/llvm-project/pull/74413
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/PortalPete created
https://github.com/llvm/llvm-project/pull/74413
rdar://119169160
>From 26891e6fab2c6ecc13ee11b6c2f4adbb1c936058 Mon Sep 17 00:00:00 2001
From: Pete Lawrence
Date: Mon, 4 Dec 2023 18:29:37 -1000
Subject: [PATCH] [lldb] Return index of element in
26 matches
Mail list logo
