https://github.com/mbucko closed https://github.com/llvm/llvm-project/pull/94494
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -200,7 +200,10 @@ def test_commands(self):
# Get output from the console. This should contain both the
# "exitCommands" that were run after the second breakpoint was hit
# and the "terminateCommands" due to the debugging session ending
-output
https://github.com/mbucko created
https://github.com/llvm/llvm-project/pull/94494
Test Plan:
llvm-lit llvm-project/lldb/test/API/tools/lldb-dap/console/TestDAP_console.py
>From 0d1eb164ab12773cb574de6066b717fd4c4c9e31 Mon Sep 17 00:00:00 2001
From: Miro Bucko
Date: Wed, 5 Jun 2024 09:03:38 -07
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Miro Bucko (mbucko)
Changes
Test Plan:
llvm-lit llvm-project/lldb/test/API/tools/lldb-dap/console/TestDAP_console.py
---
Full diff: https://github.com/llvm/llvm-project/pull/94494.diff
1 Files Affected:
- (modified) lldb/test/API/tools/l
https://github.com/walter-erquinigo approved this pull request.
https://github.com/llvm/llvm-project/pull/94494
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
JDevlieghere wrote:
Would this affect other calls to `collect_console` too? Do we usually look for
a particular string? If so, would it make sense to change the function (rather
than this particular call site) or have a little helper?
https://github.com/llvm/llvm-project/pull/94494
__
mbucko wrote:
> Would this affect other calls to `collect_console` too? Do we usually look
> for a particular string? If so, would it make sense to change the function
> (rather than this particular call site) or have a little helper?
The problem is that the console hasn't had enough time to c
JDevlieghere wrote:
> The problem is that the console hasn't had enough time to collect the logs
> after the process was terminated. This fix will keep collecting the logs
> until the "exited with status..." log has been collected so that we can check
> it. The caller could specify 10.0 second
walter-erquinigo wrote:
Jonas' suggestion is pretty good. Please do that. Probably something like this
would work
`
def collect_console(timeout_secs=10, check_interval_secs=1):
...
`
Then you can just update every caller of this function to just do
`collect_console()`
https://github.com/llv
https://github.com/mbucko updated
https://github.com/llvm/llvm-project/pull/94494
>From ea050132f653a908eeefecd647431a0ed65e2cc0 Mon Sep 17 00:00:00 2001
From: Miro Bucko
Date: Wed, 5 Jun 2024 09:03:38 -0700
Subject: [PATCH] Fix flaky TestDAP_console test.
Test Plan:
llvm-lit llvm-project/lldb
github-actions[bot] wrote:
:warning: Python code formatter, darker found issues in your code. :warning:
You can test this locally with the following command:
``bash
darker --check --diff -r
f26bc5f0c421c7a01a1a611249dd7483b749bab5...ea050132f653a908eeefecd647431a0ed65e2cc0
lldb/
https://github.com/mbucko updated
https://github.com/llvm/llvm-project/pull/94494
>From 5e92ee56b2b278b3ddad04cfdb1f440d3568389c Mon Sep 17 00:00:00 2001
From: Miro Bucko
Date: Wed, 5 Jun 2024 09:03:38 -0700
Subject: [PATCH] Fix flaky TestDAP_console test.
Test Plan:
llvm-lit llvm-project/lldb
@@ -467,5 +467,5 @@ def test_terminate_commands(self):
# Once it's disconnected the console should contain the
# "terminateCommands"
self.dap_server.request_disconnect(terminateDebuggee=True)
-output = self.collect_console(duration=1.0)
+
@@ -75,6 +75,6 @@ def
test_command_directive_abort_on_error_attach_commands(self):
attachCommands=["?!" + command_quiet, "!" +
command_abort_on_error],
expectFailure=True,
)
-full_output = self.collect_console(duration=1.0)
+ful
@@ -47,7 +47,7 @@ def do_test_abort_on_error(
postRunCommands=commands if use_post_run_commands else None,
expectFailure=True,
)
-full_output = self.collect_console(duration=1.0)
+full_output = self.collect_console(timeout_secs=1.
@@ -235,5 +235,5 @@ def test_terminate_commands(self):
# Once it's disconnected the console should contain the
# "terminateCommands"
self.dap_server.request_disconnect(terminateDebuggee=True)
-output = self.collect_console(duration=1.0)
+
@@ -200,7 +200,7 @@ def test_commands(self):
# Get output from the console. This should contain both the
# "exitCommands" that were run after the second breakpoint was hit
# and the "terminateCommands" due to the debugging session ending
-output
@@ -337,7 +337,7 @@ def test_commands(self):
# Get output from the console. This should contain both the
# "exitCommands" that were run after the second breakpoint was hit
# and the "terminateCommands" due to the debugging session ending
-output
https://github.com/mbucko updated
https://github.com/llvm/llvm-project/pull/94494
>From 39c8c9aa1cc45fd4cfd16fe841f65a4d1cb08cf4 Mon Sep 17 00:00:00 2001
From: Miro Bucko
Date: Wed, 5 Jun 2024 09:03:38 -0700
Subject: [PATCH] Fix flaky TestDAP_console test.
Test Plan:
llvm-lit llvm-project/lldb
https://github.com/JDevlieghere approved this pull request.
Thanks. LGTM!
https://github.com/llvm/llvm-project/pull/94494
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
mbucko wrote:
> Thanks. LGTM!
Would you be able to Merge it in?
https://github.com/llvm/llvm-project/pull/94494
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
walter-erquinigo wrote:
@mbucko , could you request commit access to Chris Latner?
```
We grant commit access to contributors with a track record of submitting high
quality patches. If you would like commit access, please send an email to
[Chris](mailto:clattner%40llvm.org) with your GitHub u
22 matches
Mail list logo
