[llvm-branch-commits] [clang] [clang][test] add testing for the AST matcher reference (PR #94248)

2024-06-04 Thread Aaron Ballman via llvm-branch-commits
https://github.com/AaronBallman edited https://github.com/llvm/llvm-project/pull/94248 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [clang] [clang][test] add testing for the AST matcher reference (PR #94248)

2024-06-04 Thread Aaron Ballman via llvm-branch-commits
https://github.com/AaronBallman commented: It looks like precommit CI found relevant failures: ``` _bk;t=1717501095887FAILED: tools/clang/unittests/ASTMatchers/ASTMatchersDocTests.cpp _bk;t=1717501095887cmd.exe /C "cd /D C:\ws\src\build\tools\clang\unittests\ASTMatchers && C:\ws\src\clang

[llvm-branch-commits] [clang] [clang][test] add testing for the AST matcher reference (PR #94248)

2024-06-04 Thread Aaron Ballman via llvm-branch-commits
https://github.com/AaronBallman edited https://github.com/llvm/llvm-project/pull/94248 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [clang] [clang][test] add testing for the AST matcher reference (PR #94248)

2024-06-04 Thread Aaron Ballman via llvm-branch-commits
https://github.com/AaronBallman commented: I wonder if we should add some documentation to ASTMatchers.h about the new special syntax for comments so that users who hit test failures with the new automatic tests have some more help getting to a solution. https://github.com/llvm/llvm-project/pu

[llvm-branch-commits] [clang] [clang][test] add testing for the AST matcher reference (PR #94248)

2024-06-04 Thread Aaron Ballman via llvm-branch-commits
@@ -330,35 +377,46 @@ AST_POLYMORPHIC_MATCHER_P(isExpandedFromMacro, /// Matches declarations. /// -/// Examples matches \c X, \c C, and the friend declaration inside \c C; +/// Given /// \code /// void X(); /// class C { -/// friend X; +/// friend void X(); //

[llvm-branch-commits] [clang] [clang][test] add testing for the AST matcher reference (PR #94248)

2024-06-04 Thread Aaron Ballman via llvm-branch-commits
@@ -176,11 +176,13 @@ inline internal::TrueMatcher anything() { return internal::TrueMatcher(); } /// \code /// int X; /// namespace NS { -/// int Y; +/// int Y; /// } // namespace NS /// \endcode -/// decl(hasDeclContext(translationUnitDecl())) -/// matches "

[llvm-branch-commits] [clang] [clang][test] add testing for the AST matcher reference (PR #94248)

2024-06-05 Thread Aaron Ballman via llvm-branch-commits
@@ -330,35 +377,46 @@ AST_POLYMORPHIC_MATCHER_P(isExpandedFromMacro, /// Matches declarations. /// -/// Examples matches \c X, \c C, and the friend declaration inside \c C; +/// Given /// \code /// void X(); /// class C { -/// friend X; +/// friend void X(); //

[llvm-branch-commits] [clang] [clang][test] add testing for the AST matcher reference (PR #94248)

2024-06-27 Thread Aaron Ballman via llvm-branch-commits
https://github.com/AaronBallman commented: The changes generally LGTM, though I would appreciate a second set of eyes on the CMake and Python changes because I have a bit less confidence in my review abilities there. Thank you for adding the documentation to the header file, I think that will

[llvm-branch-commits] [clang] [clang][test] add testing for the AST matcher reference (PR #94248)

2024-07-02 Thread Aaron Ballman via llvm-branch-commits
AaronBallman wrote: > Thanks. > > > ... how this impacts build times for Clang itself? I'm assuming that if > > ASTMatchers.h isn't modified, CMake won't re-run > > generate_ast_matcher_doc_tests.py and so the compile time performance hit > > is only on full rebuilds or when changing the head

[llvm-branch-commits] [clang] [clang][test] remove unused `run` overload in `BoundNodesCallback` (PR #94244)

2024-07-03 Thread Aaron Ballman via llvm-branch-commits
https://github.com/AaronBallman approved this pull request. LGTM! https://github.com/llvm/llvm-project/pull/94244 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commit

[llvm-branch-commits] [clang] [clang][test] add testing for the AST matcher reference (PR #94248)

2024-07-03 Thread Aaron Ballman via llvm-branch-commits
AaronBallman wrote: > > Do you need me to land the changes on your behalf? > > No need, I can do that. However, this PR is in a stack and depends on two > small PRs: #94244 and #94243 that need to be reviewed before this PR can be > merged Ah thank you for pointing this out, I hadn't realized

[llvm-branch-commits] [clang] release/19.x: [clang][headers] Including stddef.h always redefines NULL (#99727) (PR #100191)

2024-07-25 Thread Aaron Ballman via llvm-branch-commits
https://github.com/AaronBallman approved this pull request. LGTM, I think the CI failures are unrelated to this patch. https://github.com/llvm/llvm-project/pull/100191 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://list

[llvm-branch-commits] [clang] release/19.x: [clang][Sema] Add support for OpenBSD's syslog format attribute (#97366) (PR #100703)

2024-07-29 Thread Aaron Ballman via llvm-branch-commits
https://github.com/AaronBallman commented: I don't see a need to backport this for 19.x, it seems reasonable to let it bake for a while in 20.x (though I would be surprised if there was significant negative fallout from the changes). https://github.com/llvm/llvm-project/pull/100703 ___

[llvm-branch-commits] [clang] Ofast deprecation clarifications (PR #101005)

2024-07-29 Thread Aaron Ballman via llvm-branch-commits
https://github.com/AaronBallman edited https://github.com/llvm/llvm-project/pull/101005 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [clang] Ofast deprecation clarifications (PR #101005)

2024-07-29 Thread Aaron Ballman via llvm-branch-commits
@@ -495,10 +495,12 @@ New Compiler Flags Deprecated Compiler Flags - -- The ``-Ofast`` command-line option has been deprecated. This option both - enables the ``-O3`` optimization-level, as well as enabling non-standard - ``-ffast-math`` behaviors. As

[llvm-branch-commits] [clang] Ofast deprecation clarifications (PR #101005)

2024-07-29 Thread Aaron Ballman via llvm-branch-commits
@@ -429,8 +429,11 @@ Code Generation Options :option:`-Ofast` Enables all the optimizations from :option:`-O3` along with other aggressive optimizations that may violate strict compliance with -language standards. This is deprecated in favor of :option:`-O3` -i

[llvm-branch-commits] [clang] Ofast deprecation clarifications (PR #101005)

2024-07-29 Thread Aaron Ballman via llvm-branch-commits
https://github.com/AaronBallman commented: Thank you for working on this! I think we need these changes to be against `main` and not `19.x`, aside from the release notes (otherwise we're losing the documentation in 20.x). For the release notes, I think we can talk to @tstellar and @tru about g

[llvm-branch-commits] [clang] release/19.x: [ExprConstant] Handle shift overflow the same way as other kinds of overflow (#99579) (PR #100452)

2024-07-29 Thread Aaron Ballman via llvm-branch-commits
AaronBallman wrote: Just what was hopefully already merged: - Clang now diagnoses undefined behavior in constant expressions more consistently. This includes invalid shifts, and signed overflow in arithmetic. https://github.com/llvm/llvm-project/pull/100452

[llvm-branch-commits] [clang] [clang][FMV][AArch64] Improve streaming mode compatibility (PR #101007)

2024-07-31 Thread Aaron Ballman via llvm-branch-commits
AaronBallman wrote: Ah thank you for the explanation -- what was tripping me up was the changes in `clang/test/Sema/aarch64-sme-func-attrs.c` where we used to issue diagnostics. Okay, this makes more sense as to why we'd want to backport it then, so I retract my objection. https://github.com/

[llvm-branch-commits] [clang] [clang][FMV][AArch64] Improve streaming mode compatibility (PR #101007)

2024-07-31 Thread Aaron Ballman via llvm-branch-commits
https://github.com/AaronBallman approved this pull request. The changes LGTM -- the precommit CI failures seem to be unrelated, but it would be good to get a second opinion. After the pick lands, please be sure to add a release note so users know about the fix. https://github.com/llvm/llvm-pr

[llvm-branch-commits] [clang] [llvm] release/19.x: [clang] Fix definition of layout-compatible to ignore empty classes (PR #101491)

2024-08-02 Thread Aaron Ballman via llvm-branch-commits
https://github.com/AaronBallman approved this pull request. LGTM! The ABI precommit CI test failures look to be unrelated to these changes, but at the same time, this could potentially impact ABI (any time we change the behavior of a type trait, it can potentially impact ABI). So it may be goo

[llvm-branch-commits] [clang] release/19.x: Ofast deprecation clarifications (#101005) (PR #101663)

2024-08-02 Thread Aaron Ballman via llvm-branch-commits
https://github.com/AaronBallman approved this pull request. LGTM! There's no chance these changes are what is breaking the ABI precommit CI tests. ;-) https://github.com/llvm/llvm-project/pull/101663 ___ llvm-branch-commits mailing list llvm-branch-co

[llvm-branch-commits] [clang] [llvm] release/19.x: [clang] Fix definition of layout-compatible to ignore empty classes (PR #101491)

2024-08-02 Thread Aaron Ballman via llvm-branch-commits
AaronBallman wrote: Thanks for reminding me of that @Endilll -- LGTM still. https://github.com/llvm/llvm-project/pull/101491 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-br

[llvm-branch-commits] [clang] release/19.x: Ofast deprecation clarifications (#101005) (PR #101663)

2024-08-02 Thread Aaron Ballman via llvm-branch-commits
AaronBallman wrote: The current release note reads as: ``` - The ``-Ofast`` command-line option has been deprecated. This option both enables the ``-O3`` optimization-level, as well as enabling non-standard ``-ffast-math`` behaviors. As such, it is somewhat misleading as an "optimization le

[llvm-branch-commits] [clang] release/19.x: [Driver] Restrict Ofast deprecation help message to Clang (#101682) (PR #101963)

2024-08-05 Thread Aaron Ballman via llvm-branch-commits
https://github.com/AaronBallman approved this pull request. LGTM for a backport https://github.com/llvm/llvm-project/pull/101963 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llv

[llvm-branch-commits] [clang] release/19.x: [Clang] SFINAE on mismatching pack length during constraint satisfaction checking (#101879) (PR #101967)

2024-08-05 Thread Aaron Ballman via llvm-branch-commits
https://github.com/AaronBallman approved this pull request. LGTM! https://github.com/llvm/llvm-project/pull/101967 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commi

[llvm-branch-commits] [clang] [Driver] Temporarily probe aarch64-linux-gnu GCC installation (PR #102039)

2024-08-06 Thread Aaron Ballman via llvm-branch-commits
https://github.com/AaronBallman approved this pull request. LGTM, thank you for the quick workaround! https://github.com/llvm/llvm-project/pull/102039 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bi

[llvm-branch-commits] [clang] release/19.x: [clang] Fix crash when #embed used in a compound literal (#102304) (PR #102428)

2024-08-08 Thread Aaron Ballman via llvm-branch-commits
https://github.com/AaronBallman approved this pull request. LGTM! https://github.com/llvm/llvm-project/pull/102428 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commi

[llvm-branch-commits] [llvm] release/19.x: [AArch64] Add streaming-mode stack hazard optimization remarks (#101695) (PR #102168)

2024-08-12 Thread Aaron Ballman via llvm-branch-commits
AaronBallman wrote: > The patch here is pretty big in size, but it seems to only affects the > remarks, on the other hand it doesn't seem to really fix anything and in that > case I feel like RC3 might be the wrong time to merge this. Is there a huge > upside to take this this late in the proc

[llvm-branch-commits] [clang] release/19.x: [AIX] Revert `#pragma mc_func` check (#102919) (PR #102968)

2024-08-13 Thread Aaron Ballman via llvm-branch-commits
https://github.com/AaronBallman approved this pull request. LGTM! https://github.com/llvm/llvm-project/pull/102968 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commi

[llvm-branch-commits] [clang] Cherry pick: [Clang][Sema] Make UnresolvedLookupExprs in class scope explicit spec… (PR #102514)

2024-08-13 Thread Aaron Ballman via llvm-branch-commits
https://github.com/AaronBallman approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/102514 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commit

[llvm-branch-commits] [clang] release/19.x: [clang][AArch64] Point the nofp ABI check diagnostics at the callee (#103392) (PR #104027)

2024-08-14 Thread Aaron Ballman via llvm-branch-commits
https://github.com/AaronBallman approved this pull request. LGTM, but please add a release note when this lands. https://github.com/llvm/llvm-project/pull/104027 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm

[llvm-branch-commits] [clang] PR for llvm/llvm-project#80843 (PR #80845)

2024-02-06 Thread Aaron Ballman via llvm-branch-commits
https://github.com/AaronBallman approved this pull request. LGTM! https://github.com/llvm/llvm-project/pull/80845 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commit

[llvm-branch-commits] [clang] PR for llvm/llvm-project#80961 (PR #80962)

2024-02-07 Thread Aaron Ballman via llvm-branch-commits
https://github.com/AaronBallman approved this pull request. LGTM! https://github.com/llvm/llvm-project/pull/80962 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commit

[llvm-branch-commits] [clang] [llvm] release/18.x: [AArch64] Backport Ampere1B support (#81297 , #81341, and #81744) (PR #81857)

2024-02-20 Thread Aaron Ballman via llvm-branch-commits
AaronBallman wrote: Is this fixing a regression introduced in Clang 18? I'm wondering why the backport is needed in the first place, as this seems to be making potentially significant changes during the RC ("Make +pauth enabled in Armv8.3-a by default"). https://github.com/llvm/llvm-project/p

[llvm-branch-commits] [clang] [llvm] release/18.x: [AArch64] Backport Ampere1B support (#81297 , #81341, and #81744) (PR #81857)

2024-02-23 Thread Aaron Ballman via llvm-branch-commits
AaronBallman wrote: > I'm OK with this kind of change if the AArch64 maintainers are on board. > @AaronBallman Do you have a strong objection to this PR? We don't typically backport *features* unless there's some strongly compelling case. This sounds like a nice-to-have but I'm not certain why

[llvm-branch-commits] [clang] [llvm] release/18.x: [AArch64] Backport Ampere1B support (#81297 , #81341, and #81744) (PR #81857)

2024-02-23 Thread Aaron Ballman via llvm-branch-commits
AaronBallman wrote: > > I'm OK with this kind of change if the AArch64 maintainers are on board. > > @AaronBallman Do you have a strong objection to this PR? > > We don't typically backport _features_ unless there's some strongly > compelling case. This sounds like a nice-to-have but I'm not c

[llvm-branch-commits] [clang] fix links on clang 18.1.0rc release page (PR #82739)

2024-02-23 Thread Aaron Ballman via llvm-branch-commits
https://github.com/AaronBallman approved this pull request. LGTM! https://github.com/llvm/llvm-project/pull/82739 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commit

[llvm-branch-commits] [clang] fix links on clang 18.1.0rc release page (PR #82739)

2024-02-26 Thread Aaron Ballman via llvm-branch-commits
https://github.com/AaronBallman updated https://github.com/llvm/llvm-project/pull/82739 >From d3ae59831c804f18b3a415c71a7b392d07c40f94 Mon Sep 17 00:00:00 2001 From: "H. Vetinari" Date: Fri, 23 Feb 2024 19:03:59 +1100 Subject: [PATCH] fix links on clang 18.1.0rc release page --- clang/docs/Re

[llvm-branch-commits] [clang] fix links on clang 18.1.0rc release page (PR #82739)

2024-02-26 Thread Aaron Ballman via llvm-branch-commits
https://github.com/AaronBallman milestoned https://github.com/llvm/llvm-project/pull/82739 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [clang] release/18.x: backport PR84230 (PR #86106)

2024-03-21 Thread Aaron Ballman via llvm-branch-commits
https://github.com/AaronBallman approved this pull request. LGTM! https://github.com/llvm/llvm-project/pull/86106 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commit

[llvm-branch-commits] [clang] [CIR][cmake] Add support for cmake variable CLANG_ENABLE_CIR (PR #86078)

2024-03-21 Thread Aaron Ballman via llvm-branch-commits
https://github.com/AaronBallman commented: The changes seem reasonable to me, but I've added the CMake code owners for final approval. https://github.com/llvm/llvm-project/pull/86078 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.

[llvm-branch-commits] [clang] [CIR][NFC] Add scaffolding for the CIR dialect and CIROps.td (PR #86080)

2024-03-21 Thread Aaron Ballman via llvm-branch-commits
https://github.com/AaronBallman edited https://github.com/llvm/llvm-project/pull/86080 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [clang] [CIR][NFC] Add scaffolding for the CIR dialect and CIROps.td (PR #86080)

2024-03-21 Thread Aaron Ballman via llvm-branch-commits
@@ -0,0 +1,46 @@ +//===- CIRTypes.td - CIR dialect types -*- tablegen -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[llvm-branch-commits] [clang] [CIR][NFC] Add scaffolding for the CIR dialect and CIROps.td (PR #86080)

2024-03-21 Thread Aaron Ballman via llvm-branch-commits
@@ -0,0 +1,18 @@ +//===-- CIROps.td - CIR dialect definition -*- tablegen -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[llvm-branch-commits] [clang] [CIR][NFC] Add scaffolding for the CIR dialect and CIROps.td (PR #86080)

2024-03-21 Thread Aaron Ballman via llvm-branch-commits
https://github.com/AaronBallman commented: Generally LGTM as well, but added the CMake code owners for their opinions on those bits. https://github.com/llvm/llvm-project/pull/86080 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.or

[llvm-branch-commits] [clang] [CIR][Basic][NFC] Add the CIR language to the Language enum (PR #86072)

2024-03-21 Thread Aaron Ballman via llvm-branch-commits
https://github.com/AaronBallman approved this pull request. LGTM! https://github.com/llvm/llvm-project/pull/86072 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commit

[llvm-branch-commits] [clang] [CIR][NFC] Add scaffolding for the CIR dialect and CIROps.td (PR #86080)

2024-03-22 Thread Aaron Ballman via llvm-branch-commits
@@ -0,0 +1,46 @@ +//===- CIRTypes.td - CIR dialect types -*- tablegen -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[llvm-branch-commits] [clang] [CIR][NFC] Add scaffolding for the CIR dialect and CIROps.td (PR #86080)

2024-03-22 Thread Aaron Ballman via llvm-branch-commits
@@ -0,0 +1,18 @@ +//===-- CIROps.td - CIR dialect definition -*- tablegen -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[llvm-branch-commits] [clang] release/18.x: backport PR84230 (PR #86106)

2024-03-23 Thread Aaron Ballman via llvm-branch-commits
https://github.com/AaronBallman milestoned https://github.com/llvm/llvm-project/pull/86106 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [clang] release/18.x: backport PR84230 (PR #86106)

2024-03-28 Thread Aaron Ballman via llvm-branch-commits
AaronBallman wrote: > Hi @antoniofrighetto (or anyone else). If you would like to add a note about > this fix in the release notes (completely optional). Please reply to this > comment with a one or two sentence description of the fix. How about we go with something along the lines of: Fixed

[llvm-branch-commits] [clang] release/18.x: [Headers] Don't declare unreachable() from stddef.h in C++ (#86748) (PR #87696)

2024-04-05 Thread Aaron Ballman via llvm-branch-commits
https://github.com/AaronBallman approved this pull request. LGTM for backporting https://github.com/llvm/llvm-project/pull/87696 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llv

[llvm-branch-commits] [clang] Fix override keyword being print to the left side (PR #88453)

2024-04-12 Thread Aaron Ballman via llvm-branch-commits
https://github.com/AaronBallman requested changes to this pull request. I don't think we should add this to the 18.x release -- we're already getting requests from users to not do that: https://lists.llvm.org/pipermail/cfe-commits/Week-of-Mon-20240408/566402.html https://github.com/llvm/llvm-p

[llvm-branch-commits] [clang] Fix override keyword being print to the left side (PR #88453)

2024-04-12 Thread Aaron Ballman via llvm-branch-commits
https://github.com/AaronBallman milestoned https://github.com/llvm/llvm-project/pull/88453 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [clang] Fix override keyword being print to the left side (PR #88453)

2024-04-12 Thread Aaron Ballman via llvm-branch-commits
AaronBallman wrote: I think the 18.1 behavior is already correct? https://godbolt.org/z/v3G7h44E1 https://github.com/llvm/llvm-project/pull/88453 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/ma

[llvm-branch-commits] [clang] Fix override keyword being print to the left side (PR #88453)

2024-04-12 Thread Aaron Ballman via llvm-branch-commits
AaronBallman wrote: Ah that's right, it was with definitions that we ran into the issue! Sorry for being slow today. Okay, I retract my concerns, this is a safe and targeted fix. https://github.com/llvm/llvm-project/pull/88453 ___ llvm-branch-commits

[llvm-branch-commits] [clang] Fix override keyword being print to the left side (PR #88453)

2024-04-12 Thread Aaron Ballman via llvm-branch-commits
https://github.com/AaronBallman commented: I think this is reasonable, but leaving it to @erichkeane to make the final call. https://github.com/llvm/llvm-project/pull/88453 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https:

[llvm-branch-commits] [clang] release/18.x [X86_64] fix SSE type error in vaarg (PR #86698)

2024-04-16 Thread Aaron Ballman via llvm-branch-commits
AaronBallman wrote: > What are the current rules on cherry picks for old bugs? AFAICT this patch > wasn't fixing a bug introduced in the 17.x-18.x development region. https://releases.llvm.org/17.0.1/docs/HowToReleaseLLVM.html#release-patch-rules has the documented rules. https://github.com/l

[llvm-branch-commits] [clang] Fix override keyword being print to the left side (PR #88453)

2024-04-16 Thread Aaron Ballman via llvm-branch-commits
https://github.com/AaronBallman approved this pull request. Sorry about leaving it in a "requests changes" state, LGTM! https://github.com/llvm/llvm-project/pull/88453 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://list

[llvm-branch-commits] [clang] [CIR][NFC] Add scaffolding for the CIR dialect and CIROps.td (PR #86080)

2024-04-17 Thread Aaron Ballman via llvm-branch-commits
@@ -0,0 +1,44 @@ +//===- CIRDialect.td - CIR dialect -*- tablegen -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[llvm-branch-commits] [clang] [CIR][NFC] Add scaffolding for the CIR dialect and CIROps.td (PR #86080)

2024-04-17 Thread Aaron Ballman via llvm-branch-commits
https://github.com/AaronBallman approved this pull request. LGTM, though it would be nice if @petrhosek or @Ericson2314 could validate the cmake changes (they look sensible to me, but I never know if there's a better way to do things in CMake). https://github.com/llvm/llvm-project/pull/86080 _

[llvm-branch-commits] [clang] [CIR][NFC] Add scaffolding for the CIR dialect and CIROps.td (PR #86080)

2024-04-17 Thread Aaron Ballman via llvm-branch-commits
@@ -0,0 +1,44 @@ +//===- CIRDialect.td - CIR dialect -*- tablegen -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[llvm-branch-commits] [clang] [CIR][NFC] Add scaffolding for the CIR dialect and CIROps.td (PR #86080)

2024-04-17 Thread Aaron Ballman via llvm-branch-commits
https://github.com/AaronBallman edited https://github.com/llvm/llvm-project/pull/86080 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [clang] [CIR][NFC] Add scaffolding for the CIR dialect and CIROps.td (PR #86080)

2024-04-17 Thread Aaron Ballman via llvm-branch-commits
AaronBallman wrote: > > LGTM, though it would be nice if @petrhosek or @Ericson2314 could validate > > the cmake changes (they look sensible to me, but I never know if there's a > > better way to do things in CMake). > > We already did that above. Petr left a comment and it was fixed :p Ah, I

[llvm-branch-commits] [clang] [clang][builtin] Implement __builtin_allow_runtime_check (PR #87568)

2024-04-29 Thread Aaron Ballman via llvm-branch-commits
@@ -3464,6 +3464,34 @@ Query for this feature with ``__has_builtin(__builtin_trap)``. ``__builtin_arm_trap`` is lowered to the ``llvm.aarch64.break`` builtin, and then to ``brk #payload``. +``__builtin_allow_runtime_check`` AaronBallman wrote: The docs are

[llvm-branch-commits] [clang] [clang][builtin] Implement __builtin_allow_runtime_check (PR #87568)

2024-04-29 Thread Aaron Ballman via llvm-branch-commits
@@ -3233,6 +3233,17 @@ Sema::CheckBuiltinFunctionCall(FunctionDecl *FDecl, unsigned BuiltinID, if (BuiltinCountZeroBitsGeneric(*this, TheCall)) return ExprError(); break; + + case Builtin::BI__builtin_allow_runtime_check: { +Expr *Arg = TheCall->getArg(0); +

[llvm-branch-commits] [clang] [clang][builtin] Implement __builtin_allow_runtime_check (PR #87568)

2024-04-29 Thread Aaron Ballman via llvm-branch-commits
@@ -3464,6 +3464,34 @@ Query for this feature with ``__has_builtin(__builtin_trap)``. ``__builtin_arm_trap`` is lowered to the ``llvm.aarch64.break`` builtin, and then to ``brk #payload``. +``__builtin_allow_runtime_check`` AaronBallman wrote: > It needs t

[llvm-branch-commits] [clang] [clang][builtin] Implement __builtin_allow_runtime_check (PR #87568)

2024-04-29 Thread Aaron Ballman via llvm-branch-commits
@@ -3464,6 +3464,54 @@ Query for this feature with ``__has_builtin(__builtin_trap)``. ``__builtin_arm_trap`` is lowered to the ``llvm.aarch64.break`` builtin, and then to ``brk #payload``. +``__builtin_allow_runtime_check`` +- + +``__builtin_

[llvm-branch-commits] [clang] [clang] Revise IDE folder structure (PR #89743)

2024-05-07 Thread Aaron Ballman via llvm-branch-commits
https://github.com/AaronBallman commented: With this patch, I get errors when loading a visual studio solution generated with these change, and all of clang's libraries are placed at the top level. The error is a dialog box saying "The solution already contains an item named 'clang'." Another

[llvm-branch-commits] [clang] [clang] Revise IDE folder structure (PR #89743)

2024-05-14 Thread Aaron Ballman via llvm-branch-commits
AaronBallman wrote: > @AaronBallman Thanks for having a look. > > > With this patch, I get errors when loading a visual studio solution > > generated with these change, and all of clang's libraries are placed at the > > top level. The error is a dialog box saying "The solution already contains

[llvm-branch-commits] [clang] [clang] Revise IDE folder structure (PR #89743)

2024-05-21 Thread Aaron Ballman via llvm-branch-commits
AaronBallman wrote: > @AaronBallman Would you mind reviewing D89741 ? I was convinced a stakeholder > there but they decided to drop out instead of approving it. Oh the fun of PR numbers now lining up with Phabricator numbers. I thought you meant https://reviews.llvm.org/D89741 and was very co

[llvm-branch-commits] [clang] [clang] Revise IDE folder structure (PR #89743)

2024-05-21 Thread Aaron Ballman via llvm-branch-commits
https://github.com/AaronBallman approved this pull request. I verified the layout seems reasonable in Visual Studio 2022; LGTM! https://github.com/llvm/llvm-project/pull/89743 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org http

[llvm-branch-commits] [NFCI][metadata][clang] Use create{Unlikely, Likely}BranchWeights (PR #89467)

2024-05-21 Thread Aaron Ballman via llvm-branch-commits
https://github.com/AaronBallman edited https://github.com/llvm/llvm-project/pull/89467 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [NFCI][metadata][clang] Use create{Unlikely, Likely}BranchWeights (PR #89467)

2024-05-21 Thread Aaron Ballman via llvm-branch-commits
https://github.com/AaronBallman approved this pull request. LGTM! https://github.com/llvm/llvm-project/pull/89467 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commit

[llvm-branch-commits] [clang] [clang-tools-extra] Backport '[clang] static operators should evaluate object argument (reland)' to release/18.x (PR #80109)

2024-01-31 Thread Aaron Ballman via llvm-branch-commits
https://github.com/AaronBallman milestoned https://github.com/llvm/llvm-project/pull/80109 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [clang-tools-extra] [clang] Backport '[clang] static operators should evaluate object argument (reland)' to release/18.x (PR #80109)

2024-01-31 Thread Aaron Ballman via llvm-branch-commits
https://github.com/AaronBallman approved this pull request. LGTM for 18.x, but another set of eyes verifying the fix looks safe would not be a bad thing, either. https://github.com/llvm/llvm-project/pull/80109 ___ llvm-branch-commits mailing list llvm

[llvm-branch-commits] [clang] release/19.x: Revert "[clang] fix broken canonicalization of DeducedTemplateSpeciatizationType (#95202)" (PR #106516)

2024-08-29 Thread Aaron Ballman via llvm-branch-commits
https://github.com/AaronBallman approved this pull request. LGTM! Do we have a release note we need to remove as well? https://github.com/llvm/llvm-project/pull/106516 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://list

[llvm-branch-commits] [clang] release/19.x: Fix codegen of consteval functions returning an empty class, and related issues (#93115) (PR #102070)

2024-09-03 Thread Aaron Ballman via llvm-branch-commits
AaronBallman wrote: I'd really appreciate a review from @rjmccall -- the changes are extensive and risky enough that I worry about landing them this late in the cycle, but this does fix a miscompile and that's a pretty important thing for us to land. I didn't spot any concerns with the changes

[llvm-branch-commits] [llvm] release/19.x: [IndVars] Check if WideInc available before trying to use it (PR #106892)

2024-09-03 Thread Aaron Ballman via llvm-branch-commits
https://github.com/AaronBallman approved this pull request. I think you may have intended to tag someone other than Shafik and I for this one, but the changes LGTM nonetheless. https://github.com/llvm/llvm-project/pull/106892 ___ llvm-branch-commits m

[llvm-branch-commits] [clang] release/19.x: Fix codegen of consteval functions returning an empty class, and related issues (#93115) (PR #102070)

2024-09-04 Thread Aaron Ballman via llvm-branch-commits
https://github.com/AaronBallman approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/102070 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commit

[llvm-branch-commits] [clang] [Clang] Workaround dependent source location issues (#106925) (PR #107212)

2024-09-05 Thread Aaron Ballman via llvm-branch-commits
https://github.com/AaronBallman approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/107212 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commit

[llvm-branch-commits] [clang] release/19.x: [Clang][Sema] Use the correct lookup context when building overloaded 'operator->' in the current instantiation (#104458) (PR #107886)

2024-09-10 Thread Aaron Ballman via llvm-branch-commits
https://github.com/AaronBallman approved this pull request. LGTM -- I think this is important for 19.x given the behavior it's correcting. https://github.com/llvm/llvm-project/pull/107886 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.l

[llvm-branch-commits] [clang] release/19.x: [Clang][Sema] Use the correct lookup context when building overloaded 'operator->' in the current instantiation (#104458) (PR #107886)

2024-09-10 Thread Aaron Ballman via llvm-branch-commits
AaronBallman wrote: > This change has already been reverted on main because it breaks clang > bootstrap and causes assertion failures. This was already known at the time > it was accepted as "low risk" here. Please exercise at least a minimum amount > of due diligence before approving backport

[llvm-branch-commits] [clang-tools-extra] d6d36ba - Add a --use-color option to clang-query to allow forcing the behavior

2021-01-25 Thread Aaron Ballman via llvm-branch-commits
Author: Tom Ritter Date: 2021-01-25T08:06:54-05:00 New Revision: d6d36baa33e76ace11ac20c03de1097d48bd9246 URL: https://github.com/llvm/llvm-project/commit/d6d36baa33e76ace11ac20c03de1097d48bd9246 DIFF: https://github.com/llvm/llvm-project/commit/d6d36baa33e76ace11ac20c03de1097d48bd9246.diff LO

[llvm-branch-commits] [clang] 3484715 - Add -ansi option to CompileOnly group

2021-01-12 Thread Aaron Ballman via llvm-branch-commits
Author: Timm Bäder Date: 2021-01-12T13:16:49-05:00 New Revision: 348471575d9c24bbfb124ca5eac1589de075da88 URL: https://github.com/llvm/llvm-project/commit/348471575d9c24bbfb124ca5eac1589de075da88 DIFF: https://github.com/llvm/llvm-project/commit/348471575d9c24bbfb124ca5eac1589de075da88.diff LO

[llvm-branch-commits] [clang] ef3800e - Return false from __has_declspec_attribute() if not explicitly enabled

2021-01-12 Thread Aaron Ballman via llvm-branch-commits
Author: Timm Bäder Date: 2021-01-12T13:20:08-05:00 New Revision: ef3800e82169c674219501d9ac09ef12b28e6359 URL: https://github.com/llvm/llvm-project/commit/ef3800e82169c674219501d9ac09ef12b28e6359 DIFF: https://github.com/llvm/llvm-project/commit/ef3800e82169c674219501d9ac09ef12b28e6359.diff LO

[llvm-branch-commits] [clang] ef40d52 - Adding a test case that I accidentally dropped from 27ea7d0a6e0dc51e0214707bcc265fa6f9dc9bc6

2020-12-15 Thread Aaron Ballman via llvm-branch-commits
Author: Aaron Ballman Date: 2020-12-15T14:56:44-05:00 New Revision: ef40d5233b8b6f82927128c5b255cdc3aed9021d URL: https://github.com/llvm/llvm-project/commit/ef40d5233b8b6f82927128c5b255cdc3aed9021d DIFF: https://github.com/llvm/llvm-project/commit/ef40d5233b8b6f82927128c5b255cdc3aed9021d.diff

[llvm-branch-commits] [clang] 7685d81 - Mark implicit coroutine variables as being implicit

2020-12-16 Thread Aaron Ballman via llvm-branch-commits
Author: Emma Blink Date: 2020-12-16T14:42:07-05:00 New Revision: 7685d818ef329cd3f6ef121af1208be409eb59db URL: https://github.com/llvm/llvm-project/commit/7685d818ef329cd3f6ef121af1208be409eb59db DIFF: https://github.com/llvm/llvm-project/commit/7685d818ef329cd3f6ef121af1208be409eb59db.diff LO

[llvm-branch-commits] [clang] f500662 - Detect section type conflicts between functions and variables

2020-12-17 Thread Aaron Ballman via llvm-branch-commits
Author: Tomas Matheson Date: 2020-12-17T11:43:47-05:00 New Revision: f50066292477fb26806336e5604615d0eddde399 URL: https://github.com/llvm/llvm-project/commit/f50066292477fb26806336e5604615d0eddde399 DIFF: https://github.com/llvm/llvm-project/commit/f50066292477fb26806336e5604615d0eddde399.diff

[llvm-branch-commits] [clang-tools-extra] e69e551 - new altera single work item barrier check

2020-12-18 Thread Aaron Ballman via llvm-branch-commits
Author: Frank Derry Wanye Date: 2020-12-18T07:52:20-05:00 New Revision: e69e551e0e5fddffb6479da6a2998457104ba9e6 URL: https://github.com/llvm/llvm-project/commit/e69e551e0e5fddffb6479da6a2998457104ba9e6 DIFF: https://github.com/llvm/llvm-project/commit/e69e551e0e5fddffb6479da6a2998457104ba9e6.d

[llvm-branch-commits] [clang] 2d2498e - No longer reject tag declarations in the clause-1 of a for loop.

2020-12-18 Thread Aaron Ballman via llvm-branch-commits
Author: Aaron Ballman Date: 2020-12-18T07:56:17-05:00 New Revision: 2d2498ec6c42b12eae873257e6ddcefe8348 URL: https://github.com/llvm/llvm-project/commit/2d2498ec6c42b12eae873257e6ddcefe8348 DIFF: https://github.com/llvm/llvm-project/commit/2d2498ec6c42b12eae873257e6ddcefe8348.diff

[llvm-branch-commits] [clang] b2ba686 - Refactoring the attribute plugin example to fit the new API

2020-12-21 Thread Aaron Ballman via llvm-branch-commits
Author: Yafei Liu Date: 2020-12-21T08:24:09-05:00 New Revision: b2ba6867eac10874bd279c739639bdb9e60c1996 URL: https://github.com/llvm/llvm-project/commit/b2ba6867eac10874bd279c739639bdb9e60c1996 DIFF: https://github.com/llvm/llvm-project/commit/b2ba6867eac10874bd279c739639bdb9e60c1996.diff LOG

[llvm-branch-commits] [clang] 00dad9d - Ignore noderef attribute in unevaluated context

2020-11-23 Thread Aaron Ballman via llvm-branch-commits
Author: Jann Horn Date: 2020-11-23T08:10:35-05:00 New Revision: 00dad9d028ce31739b992a3ce2df5de054a9fa3c URL: https://github.com/llvm/llvm-project/commit/00dad9d028ce31739b992a3ce2df5de054a9fa3c DIFF: https://github.com/llvm/llvm-project/commit/00dad9d028ce31739b992a3ce2df5de054a9fa3c.diff LOG

[llvm-branch-commits] [clang-tools-extra] ed242da - Fix a typo in the documentation to unbreak the sphinx builder.

2020-11-25 Thread Aaron Ballman via llvm-branch-commits
Author: Aaron Ballman Date: 2020-11-25T07:34:08-05:00 New Revision: ed242da0ffa28493d8a5ee6b80ecbe2441ca48a7 URL: https://github.com/llvm/llvm-project/commit/ed242da0ffa28493d8a5ee6b80ecbe2441ca48a7 DIFF: https://github.com/llvm/llvm-project/commit/ed242da0ffa28493d8a5ee6b80ecbe2441ca48a7.diff

[llvm-branch-commits] [clang] 27ea7d0 - Fix inconsistent availability attribute message string literal check.

2020-12-08 Thread Aaron Ballman via llvm-branch-commits
Author: Nigel Perks Date: 2020-12-08T12:33:59-05:00 New Revision: 27ea7d0a6e0dc51e0214707bcc265fa6f9dc9bc6 URL: https://github.com/llvm/llvm-project/commit/27ea7d0a6e0dc51e0214707bcc265fa6f9dc9bc6 DIFF: https://github.com/llvm/llvm-project/commit/27ea7d0a6e0dc51e0214707bcc265fa6f9dc9bc6.diff L

[llvm-branch-commits] [clang-tools-extra] c6348e8 - cppcoreguidelines Narrowing Conversions Check: detect narrowing conversions involving typedefs

2020-12-08 Thread Aaron Ballman via llvm-branch-commits
Author: Eric Seidel Date: 2020-12-08T13:10:41-05:00 New Revision: c6348e8c95ee1eaa9dd2322b278def7a4127ff26 URL: https://github.com/llvm/llvm-project/commit/c6348e8c95ee1eaa9dd2322b278def7a4127ff26 DIFF: https://github.com/llvm/llvm-project/commit/c6348e8c95ee1eaa9dd2322b278def7a4127ff26.diff L

[llvm-branch-commits] [clang] [Clang] Improve type traits recognition in `__has_builtin` (#111516) (PR #111660)

2024-10-11 Thread Aaron Ballman via llvm-branch-commits
AaronBallman wrote: > @AaronBallman ok to backport? Yeah, seems reasonable to me. https://github.com/llvm/llvm-project/pull/111660 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/

[llvm-branch-commits] [clang] [clang] Reject if constexpr in C (#112685) (PR #112697)

2024-10-17 Thread Aaron Ballman via llvm-branch-commits
https://github.com/AaronBallman approved this pull request. LGTM! https://github.com/llvm/llvm-project/pull/112697 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-comm

[llvm-branch-commits] [clang] [clang] Fix C23 constexpr crashes (#112708) (PR #112855)

2024-10-29 Thread Aaron Ballman via llvm-branch-commits
AaronBallman wrote: > This has conflicts now. Can someone fix it and I can merge it for 19.1.4 I took a shot at resolving the conflicts (I think Mariya is out on vacation currently). https://github.com/llvm/llvm-project/pull/112855 ___ llvm-branch-co

[llvm-branch-commits] [clang] [clang] Fix C23 constexpr crashes (#112708) (PR #112855)

2024-10-29 Thread Aaron Ballman via llvm-branch-commits
https://github.com/AaronBallman updated https://github.com/llvm/llvm-project/pull/112855 >From fb40fba6f9caf44a1e839525efdaebdf936c2934 Mon Sep 17 00:00:00 2001 From: Mariya Podchishchaeva Date: Fri, 18 Oct 2024 10:18:34 +0200 Subject: [PATCH] [clang] Fix C23 constexpr crashes (#112708) Before

  1   2   >