Re: [LMMS-devel] Double name on presets

2014-06-06 Thread Stian Jørgensrud
You are not describing a problem Tobiasz? You say yourself that you use preset names in your projects and always rename the preset in different projects? So do I, and you would still do it with this enhancement without affecting the already saved preset. Or, I just realized, you are saying that th

Re: [LMMS-devel] Double name on presets

2014-06-05 Thread Tobiasz Karoń
I use the double name feature often. The preset named are local to projects: kick, snare, bass, pad. The filenames ate global to whole library and I name them with a prefix derived from the project name they come from: emerge-kick.xpf, beepson-kick.xpf etc. It makes it easy to manage and clear. I

Re: [LMMS-devel] Double name on presets

2014-06-05 Thread Tres Finocchiaro
That would be a good idea so it doesn't get lost. -Tres - tres.finocchi...@gmail.com On Thu, Jun 5, 2014 at 4:03 PM, Stian Jørgensrud wrote: > Going to file an enhancement request then? > > > > -- > View this message in context: > http://linux-multimedia-studio-lmms.996328.n3.nabble.com/Doubl

Re: [LMMS-devel] Double name on presets

2014-06-05 Thread Stian Jørgensrud
Going to file an enhancement request then? -- View this message in context: http://linux-multimedia-studio-lmms.996328.n3.nabble.com/Double-name-on-presets-tp9047p9151.html Sent from the lmms-devel mailing list archive at Nabble.com.

Re: [LMMS-devel] Double name on presets

2014-06-05 Thread Tres Finocchiaro
I don't think this necessarily needs a vote, just a small code commit. http://i.imgur.com/uCOEGmh.png -Tres - tres.finocchi...@gmail.com On Thu, Jun 5, 2014 at 7:22 AM, musikbear wrote: > Its fine > > > > -- > View this message in context: > http://linux-multimedia-studio-lmms.996328.n3.nabb

Re: [LMMS-devel] Double name on presets

2014-06-05 Thread musikbear
Its fine -- View this message in context: http://linux-multimedia-studio-lmms.996328.n3.nabble.com/Double-name-on-presets-tp9047p9145.html Sent from the lmms-devel mailing list archive at Nabble.com. -- Learn Graph Dat

Re: [LMMS-devel] Double name on presets

2014-06-04 Thread Stian Jørgensrud
Yeah, agreed. So can more agree on this? This will solve double names on presets. And of course we want the user to be able to save the preset with another name when clicking save, without renaming the instrument in his project, so the file name the user gives will wipe out the preset name. diiz

Re: [LMMS-devel] Double name on presets

2014-05-29 Thread Vesa
I think it's perfectly reasonable to just make the (sanitized) preset name the default suggestion for the filename in the save dialog. If the user wants to use a different name for whatever reason, I don't see any need to prevent that, since that's functionality that already exists. As for reserve

Re: [LMMS-devel] Double name on presets

2014-05-29 Thread Tres Finocchiaro
There are also some reserved file names in Windows (such as "LPT1") which most regex tutorials don't cover. -- Time is money. Stop wasting it! Get your web API in 5 minutes. www.restlet.com/download http://p.sf.net/sfu/rest

Re: [LMMS-devel] Double name on presets

2014-05-29 Thread Tres Finocchiaro
> You had to make a system which removed the bad characters before saving the preset? Yes, this would be the general approach. http://www.codeproject.com/Tips/758861/Removing-characters-which-are-not-allowed-in-Windo -- T

Re: [LMMS-devel] Double name on presets

2014-05-29 Thread Stian Jørgensrud
Well we didn't reach an agreement, but the only argument against: "Some people really like doing some file management things with file names so there might be a small amount of push back on this... i.e. zyn_preset_01.xpf = "Blast Off!". In this case, the preset name allows characters that are inv

Re: [LMMS-devel] Double name on presets

2014-05-29 Thread Raine M. Ekman
Quoting Tres Finocchiaro : > Perhaps the functionality could be changed to stop saving the preset name. > > Some people really like doing some file management things with file names > so there might be a small amount of push back on this... i.e. > zyn_preset_01.xpf = "Blast Off!". In this case,

Re: [LMMS-devel] Double name on presets

2014-05-29 Thread musikbear
Tres Finocchiaro wrote > In this case, the preset name allows > characters that are invalid on the file system. Ouch.. thats a hickup:/ -And a bad one. I have also been sligtly anoyed over that missing set-name in save-dialog, when i forgot to copy.. -because i definately want the project-presets

Re: [LMMS-devel] Double name on presets

2014-05-28 Thread Vesa
On 05/29/2014 12:37 AM, Stian Jørgensrud wrote: > I was originally and still are, but what if you want to name the instrument > something else? Then you would still have two names. > > Does it makes sense to have two different names on presets or should we > merge it to one. I was thinking about fo

Re: [LMMS-devel] Double name on presets

2014-05-28 Thread Tres Finocchiaro
Perhaps the functionality could be changed to stop saving the preset name. Some people really like doing some file management things with file names so there might be a small amount of push back on this... i.e. zyn_preset_01.xpf = "Blast Off!". In this case, the preset name allows characters tha

Re: [LMMS-devel] Double name on presets

2014-05-28 Thread Stian Jørgensrud
I was originally and still are, but what if you want to name the instrument something else? Then you would still have two names. Does it makes sense to have two different names on presets or should we merge it to one. I was thinking about forcing to use the filename when you save the preset, so th

Re: [LMMS-devel] Double name on presets

2014-05-28 Thread Tres Finocchiaro
In addition if you don't like the file browser displaying file name and would prefer the preset name (if specified) that would require reading the preset prior to listing it in the file browser, so that would be some more work. That should be a separate request. (screenshot) http://i.imgur.com/RG

Re: [LMMS-devel] Double name on presets

2014-05-28 Thread Tres Finocchiaro
Are you asking to pre-populate the "Save preset" dialog with the current preset name? (screenshot) http://i.imgur.com/uCOEGmh.png If so, just file a bug request. Should be a one-liner. -Tres - tres.finocchi...@gmail.com On Wed, May 28, 2014 at 2:31 PM, Stian Jørgensrud wrote: > I never un

[LMMS-devel] Double name on presets

2014-05-28 Thread Stian Jørgensrud
I never understood why. You can give the instrument a name in the Song Editor, I think that is what is called the preset name. http://lmms.sourceforge.net/wiki/index.php/1.0:Instrument_Editor#Instrument_Controls However, when you save presets you also specify a file name?? Or why isn't the file nam