Re: [lng-odp] [PATCH] example: classifier: check for null token

Reviewed-by: Balasubramanian Manoharan On 15 May 2015 at 02:53, Mike Holmes wrote: > fixes https://bugs.linaro.org/show_bug.cgi?id=1534 > > Signed-off-by: Mike Holmes > --- > > The case sudo ./example/classifier/odp_classifier -i eth0 -m 0 -p "" > now returns > odp_classifier.c:599:parse_pmr_p

[lng-odp] [Bug 1560] New: linux-generic: odp-ovs not working

https://bugs.linaro.org/show_bug.cgi?id=1560 Bug ID: 1560 Summary: linux-generic: odp-ovs not working Product: OpenDataPlane Version: unspecified Hardware: Other OS: Linux Status: UNCONFIRMED Severity: enh

[lng-odp] [Bug 1534] CID 93517: Null pointer de-references: example/classifier/odp_classifier.c

https://bugs.linaro.org/show_bug.cgi?id=1534 Mike Holmes changed: What|Removed |Added Ever confirmed|0 |1 Assignee|bala.manoha...@linaro.org

[lng-odp] [PATCH] example: classifier: check for null token

fixes https://bugs.linaro.org/show_bug.cgi?id=1534 Signed-off-by: Mike Holmes --- The case sudo ./example/classifier/odp_classifier -i eth0 -m 0 -p "" now returns odp_classifier.c:599:parse_pmr_policy():Invalid ODP_PMR_TERM string example/classifier/odp_classifier.c | 3 +++ 1 file changed, 3

[lng-odp] [Bug 1449] odp_timer_test core dump

https://bugs.linaro.org/show_bug.cgi?id=1449 --- Comment #3 from Ola Liljedahl --- Not yet I am sorry. -- You are receiving this mail because: You are on the CC list for the bug. ___ lng-odp mailing list lng-odp@lists.linaro.org https://lists.linaro.o

[lng-odp] [PATCH 2/2] gather common usage

Signed-off-by: Mike Holmes --- Uses patch enable optional perf testing apply-and-build.sh | 4 build.sh | 4 helper/generic | 4 3 files changed, 4 insertions(+), 8 deletions(-) diff --git a/apply-and-build.sh b/apply-and-build.sh index e41c297..0b2a301 100755 --- a

[lng-odp] [check-odp PATCH] enable optional perf testing

Signed-off-by: Mike Holmes --- apply-and-build.sh | 1 + build.sh | 1 + helper/generic | 9 - 3 files changed, 10 insertions(+), 1 deletion(-) diff --git a/apply-and-build.sh b/apply-and-build.sh index 9d73a2f..e41c297 100755 --- a/apply-and-build.sh +++ b/apply-and-build.

Re: [lng-odp] [PATCH] generic: external EXTRA_FLAGS overwrites script default

On 2015-05-14 11:55, Mike Holmes wrote: > Patches for the check-odp scrips are easier to identify if we use > --subject-prefix="check-odp PATCH" > > I locally added a PERF_TEST flag in the environment to disable PERF, not > fully tested but attached for consideration since it works in a way align

Re: [lng-odp] [PATCH 1/1 v1] helpers: fix udp checksum computation

Hello Alexandru, Your patch fixes check summ now that function is better: 20:49:45.613467 IP (tos 0x0, id 35630, offset 0, flags [none], proto UDP (17), length 84) 192.168.0.1.0 > 192.168.0.2.0: [bad udp cksum 0x1a7e -> 0x7e1a!] UDP, length 56 20:49:45.613470 IP (tos 0x0, id 35662, offset

Re: [lng-odp] [PATCH] linux-generic: compile out helper/linux.c from linux-generic build

On 05/14/2015 15:40, Mike Holmes wrote: Since IPC in linux-genric is currently in the process of adding dependency on the helpers and the tests already need them now, I think helper should be a library so that the issue is solved in one step for all future reuse of the helpers. For now we h

Re: [lng-odp] [PATCH] generic: external EXTRA_FLAGS overwrites script default

Patches for the check-odp scrips are easier to identify if we use --subject-prefix="check-odp PATCH" I locally added a PERF_TEST flag in the environment to disable PERF, not fully tested but attached for consideration since it works in a way aligned with all the other flags to the script. On 14

[lng-odp] [PATCH] generic: external EXTRA_FLAGS overwrites script default

The previous patch just added the values defined by the caller, this patch changes behaviour to overwrite the script default entirely. Not everyone wants the perf tests to run on make check. Signed-off-by: Zoltan Kiss --- helper/generic | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

Re: [lng-odp] [PATCH 0/3] checkpatch: update to linux 4.1-rc3

On 14 May 2015 at 18:17, Maxim Uvarov wrote: > > > On 14 May 2015 at 17:25, Mike Holmes wrote: > >> >> >> On 14 May 2015 at 09:10, Bill Fischofer >> wrote: >> >>> Well, we need to modify these new rules as these warnings are erroneous: >>> >>> *12:21:47* CHECK: Avoid CamelCase: *12:21:47* #79:

[lng-odp] [Bug 1449] odp_timer_test core dump

https://bugs.linaro.org/show_bug.cgi?id=1449 Mike Holmes changed: What|Removed |Added Ever confirmed|0 |1 Status|UNCONFIRMED

[lng-odp] [Bug 1534] CID 93517: Null pointer de-references: example/classifier/odp_classifier.c

https://bugs.linaro.org/show_bug.cgi?id=1534 Mike Holmes changed: What|Removed |Added Priority|--- |Lowest -- You are receiving this mail because:

[lng-odp] [Bug 1541] Untested API verify_pmr_packet_len

https://bugs.linaro.org/show_bug.cgi?id=1541 Mike Holmes changed: What|Removed |Added Priority|--- |Lowest -- You are receiving this mail because:

Re: [lng-odp] [PATCH 0/3] checkpatch: update to linux 4.1-rc3

On 14 May 2015 at 17:25, Mike Holmes wrote: > > > On 14 May 2015 at 09:10, Bill Fischofer wrote: > >> Well, we need to modify these new rules as these warnings are erroneous: >> >> *12:21:47* CHECK: Avoid CamelCase: *12:21:47* #79: FILE: >> platform/linux-generic/odp_buffer.c:79:*12:21:47* +

[lng-odp] [Bug 1542] Untested API verify_pmr_ip_proto

https://bugs.linaro.org/show_bug.cgi?id=1542 Mike Holmes changed: What|Removed |Added Priority|--- |Lowest -- You are receiving this mail because:

[lng-odp] [Bug 1547] Untested API copy_md_to_packet

https://bugs.linaro.org/show_bug.cgi?id=1547 Mike Holmes changed: What|Removed |Added Priority|--- |Lowest Assignee|bill.fischo...@linaro.

[lng-odp] [Bug 1544] Untested API verify_pmr_tcp_sport

https://bugs.linaro.org/show_bug.cgi?id=1544 Mike Holmes changed: What|Removed |Added Priority|--- |Lowest -- You are receiving this mail because:

[lng-odp] [Bug 1546] Untested API verify_pmr_udp_dport

https://bugs.linaro.org/show_bug.cgi?id=1546 Mike Holmes changed: What|Removed |Added Priority|--- |Lowest -- You are receiving this mail because:

[lng-odp] [Bug 1545] Untested API verify_pmr_tcp_dport

https://bugs.linaro.org/show_bug.cgi?id=1545 Mike Holmes changed: What|Removed |Added Priority|--- |Lowest -- You are receiving this mail because:

[lng-odp] [Bug 1548] Untested API parse_ipv6

https://bugs.linaro.org/show_bug.cgi?id=1548 Mike Holmes changed: What|Removed |Added Priority|--- |Lowest -- You are receiving this mail because:

[lng-odp] [Bug 1549] Untested API parse_tcp

https://bugs.linaro.org/show_bug.cgi?id=1549 Mike Holmes changed: What|Removed |Added Priority|--- |Lowest -- You are receiving this mail because:

Re: [lng-odp] How to run ODP on Fedora?

Thanks Maxim, I will start with linux-generic then move to netmap. Regards, Charlie Li From: Maxim Uvarov [mailto:maxim.uva...@linaro.org] Sent: Thursday, May 14, 2015 4:04 AM To: Li, Charlie Cc: LNG ODP Mailman List Subject: Re: How to run ODP on Fedora? Hello Charlie, To run ODP functionality

Re: [lng-odp] [PATCH 0/3] checkpatch: update to linux 4.1-rc3

On 14 May 2015 at 09:10, Bill Fischofer wrote: > Well, we need to modify these new rules as these warnings are erroneous: > > *12:21:47* CHECK: Avoid CamelCase: *12:21:47* #79: FILE: > platform/linux-generic/odp_buffer.c:79:*12:21:47* + " pool >%" PRIu64 "\n", > > > s

Re: [lng-odp] [PATCH 0/3] checkpatch: update to linux 4.1-rc3

Well, we need to modify these new rules as these warnings are erroneous: *12:21:47* CHECK: Avoid CamelCase: *12:21:47* #79: FILE: platform/linux-generic/odp_buffer.c:79:*12:21:47* + " pool %" PRIu64 "\n", since the PRIxxx routines are hard-coded to these values. Also: *12

Re: [lng-odp] [PATCH 0/3] checkpatch: update to linux 4.1-rc3

On 14 May 2015 at 08:41, Bill Fischofer wrote: > These rules seem excessively nit-picky. Why are we adding more buckles on > the the straightjacket? > checkpatch is not only focused on bugs, it is about consistent look and feel to save endless arguments on how much white space, can we use Camel

Re: [lng-odp] [PATCH 0/3] checkpatch: update to linux 4.1-rc3

These rules seem excessively nit-picky. Why are we adding more buckles on the the straightjacket? What actual bugs did the previous checkpatch allow through? On Thu, May 14, 2015 at 7:25 AM, Mike Holmes wrote: > CI has found a lot more to complain about in the current code base with > the new

Re: [lng-odp] [PATCH] linux-generic: compile out helper/linux.c from linux-generic build

Since IPC in linux-genric is currently in the process of adding dependency on the helpers and the tests already need them now, I think helper should be a library so that the issue is solved in one step for all future reuse of the helpers. On 14 May 2015 at 07:23, Maxim Uvarov wrote: > ODP help

[lng-odp] [Bug 1547] Untested API copy_md_to_packet

https://bugs.linaro.org/show_bug.cgi?id=1547 --- Comment #1 from Bill Fischofer --- This routine is called by odp_crypto_operation() in the following case: if (params->pkt != params->out_pkt) { if (odp_unlikely(ODP_PACKET_INVALID == params->out_pkt)) ODP_ABORT();

Re: [lng-odp] [PATCH 0/3] checkpatch: update to linux 4.1-rc3

CI has found a lot more to complain about in the current code base with the new checkpatch New results https://ci.linaro.org/job/odp-api-style-check/label=build/440/console I am not suggesting we go back and change it, as new code is added it will slowly clean up naturally, but the effect of the

[lng-odp] [Bug 1548] Untested API parse_ipv6

https://bugs.linaro.org/show_bug.cgi?id=1548 --- Comment #1 from Bill Fischofer --- We need to have a test that passes various packet variants into the code to provide these coverage metrics. There's no way to artificially exercise these code paths except by parsing actual packet that contain th

[lng-odp] [Bug 1549] Untested API parse_tcp

https://bugs.linaro.org/show_bug.cgi?id=1549 --- Comment #1 from Bill Fischofer --- We need to have a test that passes various packet variants into the code to provide these coverage metrics. There's no way to artificially exercise these code paths except by parsing actual packet that contain th

Re: [lng-odp] [PATCH 2/4] api ipc: update ring with shm proc argument

On 14 May 2015 at 07:29, Maxim Uvarov wrote: > On 05/14/2015 13:45, Mike Holmes wrote: > >> >> >> On 14 May 2015 at 06:31, Maxim Uvarov > maxim.uva...@linaro.org>> wrote: >> >> On 05/14/2015 01:17, Mike Holmes wrote: >> >> >> >> On 13 May 2015 at 05:03, Maxim Uvarov >

Re: [lng-odp] [PATCH 0/3] checkpatch: update to linux 4.1-rc3

Merged! Maxim. On 05/13/2015 13:49, Maxim Uvarov wrote: Update checkpatch. Add our local fixes. Plus fix lenght limit for log functions. Thanks, Maxim. Maxim Uvarov (2): checkpatch: update to linux 4.1 rc-3 checkpatch: remove cunit warnings Taras Kondratiuk (1): checkpatch: remove l

Re: [lng-odp] [PATCHv6] linux-generic: packet: Add lazy parsing support

Merged, Maxim. On 05/14/2015 14:27, Zoltan Kiss wrote: The changes seem to be OK, though I haven't ran the linux-generic unit tests on them: Reviewed-by: Zoltan Kiss On 13/05/15 13:38, Bill Fischofer wrote: Lazy parsing defers parsing until the results are actually needed. This allows appl

Re: [lng-odp] [PATCH 2/4] api ipc: update ring with shm proc argument

On 05/14/2015 13:45, Mike Holmes wrote: On 14 May 2015 at 06:31, Maxim Uvarov > wrote: On 05/14/2015 01:17, Mike Holmes wrote: On 13 May 2015 at 05:03, Maxim Uvarov mailto:maxim.uva...@linaro.org>

Re: [lng-odp] [PATCHv6] linux-generic: packet: Add lazy parsing support

The changes seem to be OK, though I haven't ran the linux-generic unit tests on them: Reviewed-by: Zoltan Kiss On 13/05/15 13:38, Bill Fischofer wrote: Lazy parsing defers parsing until the results are actually needed. This allows applications that do their own parsing and never reference OD

[lng-odp] [PATCH] linux-generic: compile out helper/linux.c from linux-generic build

ODP helper are function optional used in odp applications. Application has compile helper during it's own build and not expect that odp implementation will have this functions compiled in. Signed-off-by: Maxim Uvarov --- example/classifier/Makefile.am | 2 +- example/generator/Makefile.am

Re: [lng-odp] [PATCH 2/4] api ipc: update ring with shm proc argument

On 14 May 2015 at 06:31, Maxim Uvarov wrote: > On 05/14/2015 01:17, Mike Holmes wrote: > >> >> >> On 13 May 2015 at 05:03, Maxim Uvarov > maxim.uva...@linaro.org>> wrote: >> >> On 05/12/2015 20:52, Mike Holmes wrote: >> >> I dont think you can implement a mandatory ODP API based on an

Re: [lng-odp] [PATCH 2/4] api ipc: update ring with shm proc argument

On 05/14/2015 01:17, Mike Holmes wrote: On 13 May 2015 at 05:03, Maxim Uvarov > wrote: On 05/12/2015 20:52, Mike Holmes wrote: I dont think you can implement a mandatory ODP API based on an optional helper api. The ring implementat

Re: [lng-odp] How to run ODP on Fedora?

Hello Charlie, To run ODP functionality refer to README file in the root of linux-generic odp repo: https://git.linaro.org/lng/odp.git it has to be very simple. Compile it and build. Then run ./test/performance/odp_l2fwd application and specify required network cards. But linux-generic works wit