Re: [lng-odp] [PATCH v2] linux-generic/odp_impl: add implementation version details

2015-05-18 Thread Nicolas Morey-Chaisemartin
On 05/07/2015 02:38 PM, Mike Holmes wrote: Signed-off-by: Mike Holmes mike.hol...@linaro.org + +GIT_DESC !=$(top_builddir)/scripts/git_hash.sh This breaks the build on older distrib (Centos 7). It seems the != is only available in Make = 4.0 I replaced it by this: GIT_DESC = $(shell

Re: [lng-odp] Which hardware for ODP-DPDK or DPDK-KeyStone2 ?

2015-05-18 Thread Zoltan Kiss
On 17/05/15 00:26, Kury Nicolas wrote: Hi I would like to try ODP-DPDK (or eventually DPDK-KeyStone2) but I need first to know which NIC/configuration is compatible ? For ODP-DPDK, I bought a NIC Intel CT Desktop model EXPI9301CT (controller 82574Lā€‹) but it isn't recognized by DPDK 1.7.1.

Re: [lng-odp] [PATCH v2] linux-generic/odp_impl: add implementation version details

2015-05-18 Thread Maxim Uvarov
Hello Anders, can you please take a look what is portable solution here? Thank you, Maxim. On 05/18/2015 17:52, Nicolas Morey-Chaisemartin wrote: On 05/07/2015 02:38 PM, Mike Holmes wrote: Signed-off-by: Mike Holmes mike.hol...@linaro.org + +GIT_DESC !=$(top_builddir)/scripts/git_hash.sh

Re: [lng-odp] [PATCH] helper: ring: remove unused include

2015-05-18 Thread Maxim Uvarov
Merged, Maxim. On 05/18/2015 14:09, Bill Fischofer wrote: On Mon, May 18, 2015 at 4:49 AM, Nicolas Morey-Chaisemartin nmo...@kalray.eu mailto:nmo...@kalray.eu wrote: Signed-off-by: Nicolas Morey-Chaisemartin nmo...@kalray.eu mailto:nmo...@kalray.eu Reviewed-by: Bill Fischofer

[lng-odp] [PATCH 1/2] checkpatch: add spelling.txt

2015-05-18 Thread Maxim Uvarov
Add linux kernel spelling.txt file to detect common typos. Other alternative for ODP might be use lintian: /usr/share/lintian/data/spelling/corrections file. But check patch does not have option to override variable with that file name. So I think for now we can stay with kernels spelling.txt.

Re: [lng-odp] [PATCHv5 0/4] IPC

2015-05-18 Thread Maxim Uvarov
If no more comments here can all reviewers add their review-by to that patchset? So that I can merge that patches. Thank you, Maxim. On 05/08/2015 12:57, Maxim Uvarov wrote: v5: - accounted all comments for previous v4 review. - do not modify any api function, everything is done inside

Re: [lng-odp] odp_scheduler tests

2015-05-18 Thread Ola Liljedahl
On 18 May 2015 at 11:37, Radu-Andrei Bulie radu.bu...@freescale.com wrote: Hi, I have some observations regarding the odp_scheduler test functionality. Scheduler validation creates two kind of tests: -single threaded tests ā€“ that uses the cunit main thread for initialization.

[lng-odp] [PATCH 0/2] checkpatch: turn on spelling checks

2015-05-18 Thread Maxim Uvarov
Maxim Uvarov (2): checkpatch: add spelling.txt checkpatch: use codespell for odp .checkpatch.conf |1 + configure.ac | 20 + scripts/spelling.txt | 1043 ++ 3 files changed, 1064 insertions(+) create mode 100644

[lng-odp] [PATCH 2/2] checkpatch: use codespell for odp

2015-05-18 Thread Maxim Uvarov
checkpatch: use codespell for odp By default configure is looking for codespell installed. That check can be optionally turned off. Code spell can be used directly from command line or be used for checkpatch. For now it finds bunch of spelling issues: ./configure.ac:52: archetecture ==

Re: [lng-odp] [PATCH v2] linux-generic/odp_impl: add implementation version details

2015-05-18 Thread Maxim Uvarov
Nicolas does that work on your Makefile? -GIT_DESC !=$(top_srcdir)/scripts/git_hash.sh +GIT_DESC=`$(top_srcdir)/scripts/git_hash.sh` Thanks, Maxim. On 05/18/2015 18:32, Maxim Uvarov wrote: Hello Anders, can you please take a look what is portable solution here? Thank you, Maxim. On

Re: [lng-odp] [PATCH 1/2] examples: ipsec: tunnel mode support

2015-05-18 Thread Robbie King (robking)
Hi Maxim, Steve Kordus is going to handle this one. Thanks Steve! -Original Message- From: Maxim Uvarov [mailto:maxim.uva...@linaro.org] Sent: Monday, May 18, 2015 12:56 PM To: lng-odp@lists.linaro.org; Robbie King (robking) Subject: Re: [lng-odp] [PATCH 1/2] examples: ipsec: tunnel

Re: [lng-odp] [PATCH 1/2] examples: ipsec: tunnel mode support

2015-05-18 Thread Maxim Uvarov
Hello Robbie, can you please review that patch and next 2/2 patch. Thanks, Maxim. On 05/11/2015 14:48, alexandru.badici...@linaro.org wrote: From: Alexandru Badicioiu alexandru.badici...@linaro.org Tunnel mode is enabled from the command line using -t argument with the following format:

Re: [lng-odp] [PATCH v2] linux-generic/odp_impl: add implementation version details

2015-05-18 Thread Nicolas Morey-Chaisemartin
Yes, this seem to work on Centos 7 and does not generate a automake warning. Thanks ! Nicolas On 05/18/2015 05:45 PM, Maxim Uvarov wrote: Nicolas does that work on your Makefile? -GIT_DESC !=$(top_srcdir)/scripts/git_hash.sh +GIT_DESC=`$(top_srcdir)/scripts/git_hash.sh` Thanks, Maxim.

Re: [lng-odp] How to run ODP on Fedora?

2015-05-18 Thread Li, Charlie
Hi Maxim, I have tried linux-generic and odp_l2fwd worked. But when I tried netmap (https://git.linaro.org/lng/odp-netmap.git), I got the following compuler error. Did I missed anything? amd@amd-desktop:~/odp-netmap$ make Making all in doc make[1]: Entering directory `/home/amd/odp-netmap/doc'

Re: [lng-odp] How to run ODP on Fedora?

2015-05-18 Thread Ola Liljedahl
On 18 May 2015 at 20:36, Li, Charlie charlie...@amd.com wrote: Hi Maxim, I have tried linux-generic and odp_l2fwd worked. But when I tried netmap (https://git.linaro.org/lng/odp-netmap.git), I got the following compuler error. Did I missed anything? amd@amd-desktop:~/odp-netmap$ make

[lng-odp] [RFC] Add ipc.h

2015-05-18 Thread Ola Liljedahl
As promised, here is my first attempt at a standalone API for IPC - inter process communication in a shared nothing architecture (message passing between processes which do not share memory). Currently all definitions are in the file ipc.h but it is possible to break out some message/event

Re: [lng-odp] [PATCH 1/2] examples: ipsec: tunnel mode support

2015-05-18 Thread Steve Kordus (skordus)
Sorry it took so long. I just have a couple of questions/comments (see the SRK imbedded in the diffs below), otherwise it looked fine to me. Steve -Original Message- From: Robbie King (robking) Sent: Monday, May 18, 2015 1:47 PM To: Maxim Uvarov; lng-odp@lists.linaro.org Cc:

Re: [lng-odp] [RFC] Add ipc.h

2015-05-18 Thread Bill Fischofer
See comments inline. In general I like this, as it does seem clean and minimal. On Mon, May 18, 2015 at 5:03 PM, Ola Liljedahl ola.liljed...@linaro.org wrote: As promised, here is my first attempt at a standalone API for IPC - inter process communication in a shared nothing architecture

[lng-odp] IPC discussion

2015-05-18 Thread Ola Liljedahl
I am prototyping inter-process communication (message passing), primarily intended for communication between control and data plane applications. The linux-generic implementation is based on pktio (a new type ODP_PKTIO_TYPE_IPC) and messages are packets, much like Ethernet frames (48 bits

[lng-odp] [PATCH] helper: ring: remove unused include

2015-05-18 Thread Nicolas Morey-Chaisemartin
Signed-off-by: Nicolas Morey-Chaisemartin nmo...@kalray.eu --- helper/ring.c | 1 - 1 file changed, 1 deletion(-) diff --git a/helper/ring.c b/helper/ring.c index a24a020..721c1fc 100644 --- a/helper/ring.c +++ b/helper/ring.c @@ -75,7 +75,6 @@ #include odp_align_internal.h #include

Re: [lng-odp] IPC discussion

2015-05-18 Thread Maxim Uvarov
On 18 May 2015 at 12:00, Ola Liljedahl ola.liljed...@linaro.org wrote: I am prototyping inter-process communication (message passing), primarily intended for communication between control and data plane applications. The linux-generic implementation is based on pktio (a new type

Re: [lng-odp] [PATCH] example: classifier: check for null token

2015-05-18 Thread Maxim Uvarov
Merged, Thanks. On 05/15/2015 09:08, Bala Manoharan wrote: Reviewed-by: Balasubramanian Manoharan bala.manoha...@linaro.org On 15 May 2015 at 02:53, Mike Holmes mike.hol...@linaro.org wrote: fixes https://bugs.linaro.org/show_bug.cgi?id=1534 Signed-off-by: Mike Holmes mike.hol...@linaro.org

Re: [lng-odp] [PATCH] helper: ring: remove unused include

2015-05-18 Thread Bill Fischofer
On Mon, May 18, 2015 at 4:49 AM, Nicolas Morey-Chaisemartin nmo...@kalray.eu wrote: Signed-off-by: Nicolas Morey-Chaisemartin nmo...@kalray.eu Reviewed-by: Bill Fischofer bill.fischo...@linaro.org --- helper/ring.c | 1 - 1 file changed, 1 deletion(-) diff --git a/helper/ring.c

[lng-odp] [PATCH] example: ipsec: sequence number update with atomic variables

2015-05-18 Thread nikhil.agarwal
From: Nikhil Agarwal nikhil.agar...@freescale.com The existing implementation uses atomic queues to update the sequence number. In this particular case atomic queue are not giving any advantage over the atomic variable based implementation. Atomic queues have too much overhead for short critical

Re: [lng-odp] IPC discussion

2015-05-18 Thread Ola Liljedahl
On 18 May 2015 at 11:55, Maxim Uvarov maxim.uva...@linaro.org wrote: On 18 May 2015 at 12:00, Ola Liljedahl ola.liljed...@linaro.org wrote: I am prototyping inter-process communication (message passing), primarily intended for communication between control and data plane applications. The