Re: [lng-odp] [API-NEXT PATCH v3 3/3] api: config: removed ODP_CONFIG_MAX_THREADS

On Tue, Sep 15, 2015 at 5:56 AM, Petri Savolainen < petri.savolai...@nokia.com> wrote: > New thread API call odp_thread_count_max() replaces the > preprocessor macro in the API. A macro is still used > internally. > > Signed-off-by: Petri Savolainen > Reviewed-by:

Re: [lng-odp] [API-NEXT PATCH v3 1/3] api: init: added thread count params

On Tue, Sep 15, 2015 at 5:56 AM, Petri Savolainen < petri.savolai...@nokia.com> wrote: > Added max number of worker/control threads as global init > parameters. Implementation can e.g. optimize it's per worker > thread resource reservation or configuration accordingly. > > Maximum values are

Re: [lng-odp] [API-NEXT PATCH v3 2/3] api: thread: added thread count max

On Tue, Sep 15, 2015 at 5:56 AM, Petri Savolainen < petri.savolai...@nokia.com> wrote: > Maximum thread count is needed for preparation to remove > ODP_CONFIG_MAX_THREADS. It can be used e.g. to allocate > resources per thread ID. Thread IDs range from 0 to > count_max - 1. > > Signed-off-by:

Re: [lng-odp] [PATCH] checkpatch: allow comparison to NULL

On Tue, Sep 15, 2015 at 7:01 AM, Petri Savolainen < petri.savolai...@nokia.com> wrote: > Allow comparison to NULL since ODP API calls may return NULL > and test applications should be able to compare against that, > instead of forced to compare against 0 (!ptr). > > Signed-off-by: Petri

[lng-odp] [PATCH] test: l2fwd: fill correct source ethernet address

When running l2fwd in a VM using SR-IOV the host may drop packets if the source MAC address is not the same as that of the VF NIC. Modify test application so that the source MAC address is always filled correctly. Signed-off-by: Matias Elo --- test/performance/odp_l2fwd.c

Re: [lng-odp] [ODP-DPDK] Question about arguments for odp_generator

Hi, There is a separate list for ODP-DPDK, I've put it in the Cc. You can pass your parameters via ODP_PLATFORM_PARAMS environment variable: https://git.linaro.org/lng/odp-dpdk.git/blob/HEAD:/platform/linux-dpdk/README#l225 Regards, Zoltan On 14/09/15 12:13, Kury Nicolas wrote: Hi I have

Re: [lng-odp] [PATCH v2 2/5] example: ipsec: avoid mixing scheduler wait time and wall time

Petri, Could you please review this patch? This patch fixes bad ipsec example we were talked about some time ago. On 11.09.15 13:04, Ivan Khoronzhuk wrote: It's not correct to mix wall time and scheduler wait time, used timers can have different rates. As in this example scheduler is used

[lng-odp] [PATCH] api: split documentation from definitions

Defines in config.h should be defined by the platform appropriately and then possibly be exposed by APIs. Start the clean up process by moving the API Doxygen documentation away from the per platform definition. Signed-off-by: Mike Holmes --- include/odp/api/config.h

[lng-odp] [PATCH] checkpatch: allow comparison to NULL

Allow comparison to NULL since ODP API calls may return NULL and test applications should be able to compare against that, instead of forced to compare against 0 (!ptr). Signed-off-by: Petri Savolainen --- .checkpatch.conf | 1 + 1 file changed, 1 insertion(+) diff

Re: [lng-odp] [PATCH v2 5/5] performance: odp_pktio_perf: fix potential overflow for burst_gap

On 15.09.15 14:42, Savolainen, Petri (Nokia - FI/Espoo) wrote: -Original Message- From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of EXT Ivan Khoronzhuk Sent: Friday, September 11, 2015 1:05 PM To: lng-odp@lists.linaro.org Subject: [lng-odp] [PATCH v2 5/5]

Re: [lng-odp] [API-NEXT PATCH v2 3/3] api: config: removed ODP_CONFIG_MAX_THREADS

From: EXT Bill Fischofer [mailto:bill.fischo...@linaro.org] Sent: Friday, September 11, 2015 6:55 PM To: Savolainen, Petri (Nokia - FI/Espoo) Cc: LNG ODP Mailman List Subject: Re: [lng-odp] [API-NEXT PATCH v2 3/3] api: config: removed ODP_CONFIG_MAX_THREADS On Fri, Sep 11, 2015 at 7:55 AM,

[lng-odp] [API-NEXT PATCH v3 3/3] api: config: removed ODP_CONFIG_MAX_THREADS

New thread API call odp_thread_count_max() replaces the preprocessor macro in the API. A macro is still used internally. Signed-off-by: Petri Savolainen --- include/odp/api/config.h | 5 ---

[lng-odp] [API-NEXT PATCH v3 1/3] api: init: added thread count params

Added max number of worker/control threads as global init parameters. Implementation can e.g. optimize it's per worker thread resource reservation or configuration accordingly. Maximum values are platform specific. These values come typically from the user as command line arguments, etc.

Re: [lng-odp] [PATCH v2 5/5] performance: odp_pktio_perf: fix potential overflow for burst_gap

> -Original Message- > From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of > EXT Ivan Khoronzhuk > Sent: Friday, September 11, 2015 1:05 PM > To: lng-odp@lists.linaro.org > Subject: [lng-odp] [PATCH v2 5/5] performance: odp_pktio_perf: fix > potential overflow for

Re: [lng-odp] [PATCH v2 4/5] performance: odp_pktio_perf: fix potential overflow for send_duration

On Fri, Sep 11, 2015 at 01:04:48PM +0300, Ivan Khoronzhuk wrote: > The direct comparing of "cur_cycles" and "end_cycles" is not valid, > as "end_cycles" can be overflowed and comparison will give wrong > result. So use odp_time_diff_cycles() for that, as it takes in > account cycles overflow. > >

Re: [lng-odp] [PATCH v2 0/2] Fix ODP_SCHED_NO_WAIT case for odp_schedule_wait_time

ping On 10.09.15 19:18, Ivan Khoronzhuk wrote: These patches corrects ODP_SCHED_NO_WAIT corner case when scheduler time has resolution more then 1ns. Since v2: - linux-generic: odp_schedule: fix odp_schdule_wait_time Correct commit message - validation: schedule: don't check schedule

[lng-odp] [API NEXT PATCH v5 17/17] linux-generic: update CPU Hz calling functions

From: Hongbo Zhang The previous odp_sys_cpu_hz() is moved to cpu.h and then renamed to odp_cpu_hz(), but all the calling function of odp{_sys}_cpu_hz() want to show maximun CPU capacity in fact, so all the odp_sys_cpu_hz() calling functions are updated to use the newly

Re: [lng-odp] [PATCH v2 5/5] performance: odp_pktio_perf: fix potential overflow for burst_gap

Petri, On 15.09.15 16:01, Ivan Khoronzhuk wrote: On 15.09.15 15:54, Ivan Khoronzhuk wrote: On 15.09.15 15:45, Savolainen, Petri (Nokia - FI/Espoo) wrote: -Original Message- From: EXT Ivan Khoronzhuk [mailto:ivan.khoronz...@linaro.org] Sent: Tuesday, September 15, 2015 3:08 PM

Re: [lng-odp] [API NEXT PATCH v5 03/17] api: sysinfo: move CPU model API to cpu.h

Hi, Hongbo Can it be built after this change? Should it be build-able at least? On 15.09.15 16:55, hongbo.zh...@freescale.com wrote: From: Hongbo Zhang This patch moves odp_sys_cpu_model_str() to cpu.h, all the calling functions will be updated in later separate

Re: [lng-odp] [API NEXT PATCH v5 03/17] api: sysinfo: move CPU model API to cpu.h

On 15 September 2015 at 10:18, Ivan Khoronzhuk wrote: > Hi, Hongbo > > Can it be built after this change? Should it be build-able at least? All series should be build-able - if the check-odp apply-and-build script does not pass it cannot be committed. > > > On

[lng-odp] [API-NEXT PATCH v3 2/3] api: thread: added thread count max

Maximum thread count is needed for preparation to remove ODP_CONFIG_MAX_THREADS. It can be used e.g. to allocate resources per thread ID. Thread IDs range from 0 to count_max - 1. Signed-off-by: Petri Savolainen --- include/odp/api/thread.h| 14

[lng-odp] [API NEXT PATCH v5 00/17] api: sysinfo: CPU frequency API clean up

From: Hongbo Zhang v4 -> v5 changes: - most obvious change is split some patches into even smaller patches and re-arange the sequency for convenience of review - change odp_cpu_id_*() to odp_cpu_*_id() v3 -> v4 changes: - rebase to latest odp version - add

[lng-odp] [API NEXT PATCH v5 01/17] linux-generic: sysinfo: make the model_str per-CPU data

From: Hongbo Zhang For AMP system such as ARM big.LITTLE, cores are heterogeneous, and the model_str for each core may be different too, so this patch changes the model_str to data array model_str[] to contain data for each different core, while for the common SMP

[lng-odp] [API NEXT PATCH v5 02/17] linux-generic: sysinfo: make the cpu_hz per-CPU data

From: Hongbo Zhang For AMP system such as ARM big.LITTLE, cores are heterogeneous, and cpu_hz for each core may be different too, so this patch changes the cpu_hz to data array cpu_hz[] to contain data for each different core, while for the common SMP system, we can

[lng-odp] [API NEXT PATCH v5 04/17] api: sysinfo: move CPU Hz API to cpu.h

From: Hongbo Zhang All CPU related APIs should be moved to cpu.h, this patch moves odp_sys_cpu_hz(), all the calling functions will be also updated in later patch. Signed-off-by: Hongbo Zhang --- include/odp/api/cpu.h| 9

[lng-odp] [API NEXT PATCH v5 05/17] api: sysinfo: add new API to get per-CPU model string

From: Hongbo Zhang Previous patch makes varible model_str to array model_str[] to contain data for each CPU on AMP platforms, and then this patch adds new API to get the corresponding model string for each CPU indexed by CPU ID. Signed-off-by: Hongbo Zhang

[lng-odp] [API NEXT PATCH v5 03/17] api: sysinfo: move CPU model API to cpu.h

From: Hongbo Zhang This patch moves odp_sys_cpu_model_str() to cpu.h, all the calling functions will be updated in later separate patch. Signed-off-by: Hongbo Zhang --- include/odp/api/cpu.h| 9 +

[lng-odp] [API NEXT PATCH v5 07/17] api: sysinfo: add new API to get per-CPU max frequency

From: Hongbo Zhang This patch adds new API odp_cpu_hz_max_id() to get the corresponding max frequency for each CPU indexed by CPU ID. Signed-off-by: Hongbo Zhang --- include/odp/api/cpu.h| 11 +++

[lng-odp] [API NEXT PATCH v5 10/17] api: cpumask: add API odp_cpumask_all_available()

From: Hongbo Zhang In some cases, odp_cpu_count() isn't enough to show all the available CPUs, so a new API odp_cpumask_all_available() is introduced, which returns all the worker and control CPUs. Signed-off-by: Hongbo Zhang ---

[lng-odp] [API NEXT PATCH v5 13/17] example: update CPU model string calling functions

From: Hongbo Zhang The odp_sys_cpu_model_str() is moved to cpu.h and then renamed to odp_cpu_model_str(), so all the calling functions should be updated too, this patch updates the example part. Signed-off-by: Hongbo Zhang ---

[lng-odp] [API NEXT PATCH v5 06/17] api: sysinfo: add new API to get CPU max frequency

From: Hongbo Zhang This patch adds a new API odp_cpu_hz_max() to get the max frequency of the CPU on which the progeress is running. The previous odp_cpu_hz() should return the current frequency and will be adapted later. Signed-off-by: Hongbo Zhang

[lng-odp] [API NEXT PATCH v5 11/17] validation: system: update legacy CPU API names

From: Hongbo Zhang The legecy CPU related APIs, odp_sys_cpu_model_str() and odp_sys_cpu_hz() are moved to cpu.h, and then accordingly renamed to odp_cpu_model_str() and odp_cpu_hz(), this patch replaces the old names in validation code by the new ones. Signed-off-by:

[lng-odp] [API NEXT PATCH v5 12/17] validation: system: add validation for new CPU APIs

From: Hongbo Zhang This patch adds validation codes for newly added CPU APIs: odp_cpu_modle_str_id() odp_cpu_hz_id() odp_cpu_hz_max() odp_cpu_hz_max_id() and the new odp_cpumask_all_available() is verified too. Signed-off-by: Hongbo Zhang ---

[lng-odp] [API NEXT PATCH v5 14/17] test: update CPU model string calling functions

From: Hongbo Zhang The odp_sys_cpu_model_str() is moved to cpu.h and then renamed to odp_cpu_model_str(), so all the calling functions should be updated too, this patch updates the test part codes. Signed-off-by: Hongbo Zhang ---

[lng-odp] [API NEXT PATCH v5 16/17] test: update CPU Hz calling functions

From: Hongbo Zhang The previous odp_sys_cpu_hz() is moved to cpu.h and then renamed to odp_cpu_hz(), but all the calling function of odp{_sys}_cpu_hz() want to show maximun CPU capacity in fact, so all the odp_sys_cpu_hz() calling functions are updated to use the newly

[lng-odp] [API NEXT PATCH v5 15/17] example: update CPU Hz calling functions

From: Hongbo Zhang The previous odp_sys_cpu_hz() is moved to cpu.h and then renamed to odp_cpu_hz(), but all the calling function of odp{_sys}_cpu_hz() want to show maximun CPU capacity in fact, so all the odp_sys_cpu_hz() calling functions are updated to use the newly

Re: [lng-odp] [PATCH v2 5/5] performance: odp_pktio_perf: fix potential overflow for burst_gap

On 15.09.15 15:45, Savolainen, Petri (Nokia - FI/Espoo) wrote: -Original Message- From: EXT Ivan Khoronzhuk [mailto:ivan.khoronz...@linaro.org] Sent: Tuesday, September 15, 2015 3:08 PM To: Savolainen, Petri (Nokia - FI/Espoo); lng-odp@lists.linaro.org Subject: Re: [lng-odp] [PATCH

Re: [lng-odp] [PATCH v2 5/5] performance: odp_pktio_perf: fix potential overflow for burst_gap

> -Original Message- > From: EXT Ivan Khoronzhuk [mailto:ivan.khoronz...@linaro.org] > Sent: Tuesday, September 15, 2015 3:08 PM > To: Savolainen, Petri (Nokia - FI/Espoo); lng-odp@lists.linaro.org > Subject: Re: [lng-odp] [PATCH v2 5/5] performance: odp_pktio_perf: fix > potential

Re: [lng-odp] [PATCH v2 5/5] performance: odp_pktio_perf: fix potential overflow for burst_gap

On 15.09.15 15:54, Ivan Khoronzhuk wrote: On 15.09.15 15:45, Savolainen, Petri (Nokia - FI/Espoo) wrote: -Original Message- From: EXT Ivan Khoronzhuk [mailto:ivan.khoronz...@linaro.org] Sent: Tuesday, September 15, 2015 3:08 PM To: Savolainen, Petri (Nokia - FI/Espoo);

Re: [lng-odp] [PATCH v2 4/5] performance: odp_pktio_perf: fix potential overflow for send_duration

Stuart, Could you please review this patch. It uses start_cycles as it was proposed. On 11.09.15 13:04, Ivan Khoronzhuk wrote: The direct comparing of "cur_cycles" and "end_cycles" is not valid, as "end_cycles" can be overflowed and comparison will give wrong result. So use