Re: [lng-odp] [PATCH] platform: move list of API files to Makefile.inc so it is common to all platforms

We can discuss it during today's public call. Thanks. On Tue, Nov 17, 2015 at 2:23 AM, Nicolas Morey-Chaisemartin < nmo...@kalray.eu> wrote: > I have read few things here and there about the repo split but haven't > seen the full plan of the ML (maybe I missed it). > Is there some more

Re: [lng-odp] [PATCH] platform: move list of API files to Makefile.inc so it is common to all platforms

I am wondering if it makes more sense to have odp-framework.git which contains the api, docs, helpers and tests and then separate out the platform specific linux-generic renaming it to odp-linux to match the other platforms. Then all platforms are odp-framework + the platforms they want to

Re: [lng-odp] [API-NEXT PATCHv10 0/4] Egress Traffic Manager

Problem with building 32 bit app: /* A hash table entry is LOGICALLY either empty, a pointer to a 64-byte * aligned name_tbl_entry_t OR a pointer to a 64-byte aligned secondary hash * table. Since the bottom 6-bits of this value are not needed to hold the * address, these 6 bits are used

[lng-odp] [PATCH] scripts: git_hash: support gitfiles

With recent git releases, the .git at the top of a repo is not necessary a directory but can be a gitfile pointing to a remote git directory. This is commonly used by git-worktree and git-submodule. This patch changes the check for .git to allow for any file (symlinks too) Signed-off-by: Nicolas

[lng-odp] [Bug 1906] New: not tested uint64_t odp_cpu_cycles_resolution(void)

https://bugs.linaro.org/show_bug.cgi?id=1906 Bug ID: 1906 Summary: not tested uint64_t odp_cpu_cycles_resolution(void) Product: OpenDataPlane - linux- generic reference Version: api-next Hardware: Other OS: Linux

[lng-odp] [PATCHv2 2/2] doc: userguide: add baseline overview to document

Add a basic ODP overview to the User's Guide, providing an overview of ODP concepts, components, etc. Included are a number of diagrams covering component structure as well as packet RX, event scheduling, and packet TX processing. Signed-off-by: Bill Fischofer ---

[lng-odp] [PATCH] helper: test: add odp_table to .gitignore file

Signed-off-by: Bill Fischofer --- helper/test/.gitignore | 1 + 1 file changed, 1 insertion(+) diff --git a/helper/test/.gitignore b/helper/test/.gitignore index 213bc5e..50a0da4 100644 --- a/helper/test/.gitignore +++ b/helper/test/.gitignore @@ -2,5 +2,6 @@ *.log

Re: [lng-odp] [PATCH] platform: move list of API files to Makefile.inc so it is common to all platforms

That might be a reasonable split. Of course when complete we could just call the framework repo odp.git. The net result of this would be that the final split is simply to take the platforms out of the existing odp.git and move them to their own repo. In this case platform/linux-generic moves to

Re: [lng-odp] [PATCH 1/5] api: classification: add odp_cls_cos_pool_set() api

This should be marked API-NEXT. On Tue, Nov 17, 2015 at 12:16 AM, Balasubramanian Manoharan < bala.manoha...@linaro.org> wrote: > odp_cls_cos_pool_set() api is used to configure packet pool to CoS. > The packets arriving at the CoS is allocated from the configured pool > > Signed-off-by:

Re: [lng-odp] [PATCH 1/5] api: classification: add odp_cls_cos_pool_set() api

Thanks for pointing out. Will update in the next version. Regards, Bala On 17 November 2015 at 18:46, Bill Fischofer wrote: > This should be marked API-NEXT. > > On Tue, Nov 17, 2015 at 12:16 AM, Balasubramanian Manoharan > wrote: >> >>

Re: [lng-odp] [PATCHv2 2/2] doc: userguide: add baseline overview to document

That's what make does :) On Tue, Nov 17, 2015 at 11:57 AM, Mike Holmes wrote: > > > On 17 November 2015 at 12:54, Bill Fischofer > wrote: > >> Is that a review comment? Is there a problem with the rendering? >> > > Not a review comment just

Re: [lng-odp] [PATCHv2 2/2] doc: userguide: add baseline overview to document

On 17 November 2015 at 13:15, Bill Fischofer wrote: > That's what make does :) > Indeed - but reviews on docs are very hard to get, hopefully some one reads it and objects who would normally ignore it! > > On Tue, Nov 17, 2015 at 11:57 AM, Mike Holmes

Re: [lng-odp] [PATCHv2 2/2] doc: userguide: add baseline overview to document

On 17 November 2015 at 12:54, Bill Fischofer wrote: > Is that a review comment? Is there a problem with the rendering? > Not a review comment just to make it easier for folks to read initially. > On Tue, Nov 17, 2015 at 11:51 AM, Mike Holmes

Re: [lng-odp] [PATCHv2 2/2] doc: userguide: add baseline overview to document

This is the rendered doc http://people.linaro.org/~mike.holmes/output/users-guide.html On 17 November 2015 at 12:15, Bill Fischofer wrote: > Add a basic ODP overview to the User's Guide, providing > an overview of ODP concepts, components, etc. Included > are a

Re: [lng-odp] [PATCHv2 2/2] doc: userguide: add baseline overview to document

Is that a review comment? Is there a problem with the rendering? On Tue, Nov 17, 2015 at 11:51 AM, Mike Holmes wrote: > This is the rendered doc > > http://people.linaro.org/~mike.holmes/output/users-guide.html > > On 17 November 2015 at 12:15, Bill Fischofer

[lng-odp] odp_platform_init_t vs ODP_PLATFORM_PARAMS

Hi all, Our odp_init_global() has a second parameter with type odp_platform_init_t. It's supposed to convey platform specific init parameters, however neither linux-generic nor linux-dpdk uses that. In the latter we use instead the ODP_PLATFORM_PARAMS environment variable. It has the little

Re: [lng-odp] [PATCHv2 2/2] doc: userguide: add baseline overview to document

General comments to hash as we get docs moving. - I think this would be a lot easier to review in smaller pieces, a section at a time, for future patches I think we should do that. Images should go in first and it occurs to me we never add an image that is not used in a doc - maybe

[lng-odp] [API-NEXT PATCHv12 1/3] api: tm: add tm API definitions

This introduces an API for configuring and using Traffic Management systems. The purpose of this API is as a general packet scheduling system that accepts packets from input queues and applies strict priority scheduling, weighted fair queuing scheduling and/or bandwidth controls to decide which

[lng-odp] [API-NEXT PATCHv12 0/3] Egress Traffic Manager

Changes in v12 - Refactor to enable serial apply-and-build Changes in v11 - Squash Parts 2 and 3 to give new Part 2 that can build independently - Change typedef for hash_table_entry_t to uint64_t for 32-bit support Changes in v10 - Add back ARM definitions for _crc32w() from Alex that got

[lng-odp] [PATCHv3 2/2] doc: userguide: add baseline overview to document

Add a basic ODP overview to the User's Guide, providing an overview of ODP concepts, components, etc. Included are a number of diagrams covering component structure as well as packet RX, event scheduling, and packet TX processing. Signed-off-by: Bill Fischofer ---

Re: [lng-odp] [PATCHv2 2/2] doc: userguide: add baseline overview to document

Thanks for the spelling corrections. v4 submitted (v3 still had a typo) that corrects these and others and adds the list you suggested. Other comments inline: On Tue, Nov 17, 2015 at 12:52 PM, Mike Holmes wrote: > General comments to hash as we get docs moving. > >

Re: [lng-odp] [PATCH] helper: test: add odp_table to .gitignore file

On 17 November 2015 at 12:32, Bill Fischofer wrote: > Signed-off-by: Bill Fischofer > Reviewed-by: Mike Holmes > --- > helper/test/.gitignore | 1 + > 1 file changed, 1 insertion(+) > > diff --git

[lng-odp] [PATCHv4 2/2] doc: userguide: add baseline overview to document

Add a basic ODP overview to the User's Guide, providing an overview of ODP concepts, components, etc. Included are a number of diagrams covering component structure as well as packet RX, event scheduling, and packet TX processing. Signed-off-by: Bill Fischofer ---

Re: [lng-odp] odp_platform_init_t vs ODP_PLATFORM_PARAMS

I vote for B. The idea is that if the application wishes to override it can do so otherwise let the implementation take its defaults from the environment or however else it wishes to support platform-specific configuration options. This is in keeping with how we handle other overridable defaults

Re: [lng-odp] odp_platform_init_t vs ODP_PLATFORM_PARAMS

On 17 November 2015 at 13:54, Zoltan Kiss wrote: > Hi all, > > Our odp_init_global() has a second parameter with type > odp_platform_init_t. It's supposed to convey platform specific init > parameters, however neither linux-generic nor linux-dpdk uses that. In the >

[lng-odp] [API-NEXT PATCHv11 0/3] Egress Traffic Manager

Changes in v11 - Squash Parts 2 and 3 to give new Part 2 that can build independently - Change typedef for hash_table_entry_t to uint64_t for 32-bit support Changes in v10 - Add back ARM definitions for _crc32w() from Alex that got dropped in v9 Note: Checkpatch complains about the _asm() line.

[lng-odp] [API-NEXT PATCHv12 3/3] example: tm: traffic manager example

This commit includes all of the changes to build the traffic_mgr example application. Signed-off-by: Barry Spinney Signed-off-by: Bill Fischofer --- configure.ac| 1 + example/Makefile.am | 2 +-

Re: [lng-odp] [API-NEXT PATCHv11 0/3] Egress Traffic Manager

Sorry about that. v12 submitted. Passed apply-and-build and build-all for me. On Tue, Nov 17, 2015 at 4:31 PM, Mike Holmes wrote: > apply and build issues still show up for me - I used v11 - three patches > > ~/incoming/bill$ ls -l > total 452 > -rw--- 1 mike mike

Re: [lng-odp] [PATCH] platform: move list of API files to Makefile.inc so it is common to all platforms

I have read few things here and there about the repo split but haven't seen the full plan of the ML (maybe I missed it). Is there some more information somewhere ? Nicolas On 11/17/2015 05:21 AM, Bill Fischofer wrote: > This seems reasonable, but is probably already part of the new odp-api.git

[lng-odp] [API-NEXT PATCHv11 3/3] example: tm: traffic manager example

From: Barry Spinney This commit includes all of the changes to build the traffic_mgr example application. Signed-off-by: Barry Spinney Signed-off-by: Bill Fischofer --- configure.ac| 1 +

[lng-odp] [API-NEXT PATCHv11 1/3] api: tm: add tm API definitions

From: Barry Spinney This introduces an API for configuring and using Traffic Management systems. The purpose of this API is as a general packet scheduling system that accepts packets from input queues and applies strict priority scheduling, weighted fair queuing scheduling

[lng-odp] [PATCH v2] remove hard platform links

Signed-off-by: Mike Holmes --- example/Makefile.inc | 1 - helper/Makefile.am | 1 - test/Makefile.inc| 1 - 3 files changed, 3 deletions(-) diff --git a/example/Makefile.inc b/example/Makefile.inc index 05021d4..170f32e 100644 --- a/example/Makefile.inc +++

Re: [lng-odp] [API-NEXT PATCHv11 0/3] Egress Traffic Manager

apply and build issues still show up for me - I used v11 - three patches ~/incoming/bill$ ls -l total 452 -rw--- 1 mike mike 127026 Nov 17 17:17 lng-odp_API-NEXT_PATCHv11_1-3_api_tm_add_tm_API_definitions.mbox -rw--- 1 mike mike 286282 Nov 17 17:17