Re: [lng-odp] [API-NEXT PATCHv1] linux-generic:pktio:add an interface to support multi pool

Hi, Thank you for your explaining. But I can't totally agree with you. I don't know how does the ODP_PMR_LEN support range match. I mean if I want the packets with different lenth alloced from Pool No1~4 like this: lenthalloc from (0, 200)Pool-No.1 [200, 800)Poo

Re: [lng-odp] [PATCH] validation: print backtrace on segfault and other related signals

On 25 February 2016 at 07:26, Maxim Uvarov wrote: > ping. Is that reasonable patch? This makes the test framework more dependant on Linux and the validation suite needs to be agnostic, so I have to vote no, but agree that we should improve things. > > > Maxim. > > > On 02/17/16 15:11, Maxim

Re: [lng-odp] [API-NEXT PATCHv2 1/3] linux-generic: pktio: add link_status handler for loop interfaces

For the series Reviewed-by: Mike Holmes On 1 March 2016 at 14:56, Bill Fischofer wrote: > ODP loopback interfaces should always be considered up, so add a > handler for odp_pktio_link_status() for this device type that always > returns 1 to indicate the link is up. > > Signed-off-by: Bill Fisch

[lng-odp] [PATCH] validation: timer: don't access non-existing timers

Since e5c85d3f "validation: timer: handle early exhaustion of pool" the workers can handle if object caches retain packets, but with enough threads it can happen that a late starting thread won't be able to allocate any. This for loop should take that into account and not trying to access tt[0].ev.

[lng-odp] [PATCH] validation: pktio: add more debug log to pktio_pkt_seq()

Signed-off-by: Zoltan Kiss --- test/validation/pktio/pktio.c | 26 +- 1 file changed, 21 insertions(+), 5 deletions(-) diff --git a/test/validation/pktio/pktio.c b/test/validation/pktio/pktio.c index a5f25da..084e5cd 100644 --- a/test/validation/pktio/pktio.c +++ b/test/v

[lng-odp] [PATCH 2/2] linux-generic: packet: don't look for L2 header if there isn't any

The L2 offset functions should consider the L2 flag: return negative answer if there isn't any, and implicitly set it when offset is set. E.g. user created packets don't have L2 headers immediately. Signed-off-by: Zoltan Kiss --- platform/linux-generic/include/odp_packet_internal.h | 5 + pl

[lng-odp] [PATCH 0/2] packet_flags changes

These have to be applied in order, otherwise the code is not dependent on each other. Zoltan Kiss (2) linux-generic: packet_flags: use accessors to modify eth and l2 flag linux-generic: packet: don't look for L2 header if there isn't any -- 1.9.1 _

[lng-odp] [PATCH 1/2] linux-generic: packet_flags: use accessors to modify eth and l2 flag

This makes it possible for other implementations like ODP-DPDK to reuse classification code while using a different packet API. Signed-off-by: Zoltan Kiss --- platform/linux-generic/include/odp_classification_inlines.h | 2 +- platform/linux-generic/include/odp_packet_internal.h| 10 +++

Re: [lng-odp] [PATCH v1] validation: classification: add test case for odp_cos_drop() function

On 18 February 2016 at 07:48, Balasubramanian Manoharan < bala.manoha...@linaro.org> wrote: > Fixes: https://bugs.linaro.org/show_bug.cgi?id=2016 > > Signed-off-by: Balasubramanian Manoharan Reviewed-by: Mike Holmes > > --- > test/validation/classification/odp_classification_basic.c | 3 +++

[lng-odp] [PATCH v5 7/8] linux-generic: use one uniform call systemcpu()

From: Hongbo Zhang Currently there are two systemcpu() functions, one is for some specific platforms and the other is for default dummy, but most of the contents are same except for sysinfo->cache_line_size: one is true data from calling systemcpu_cache_line_size() and another is dummy data. In s

[lng-odp] [PATCH v5 8/8] linux-generic: sysinfo clean up for ARM

From: Hongbo Zhang The arch/arm/odp_sysinfo_parse.c is currently a symlink to arch/linux/odp_sysinfo_parse.c, but in fact there should be defferences between them. A separated real arch/arm/odp_sysinfo_parse.c is created for ARM, and the model_str is set to a general "ARM", which is much better

[lng-odp] [PATCH v5 5/8] linux-generic: move CPU info dummy data to generic default file

From: Hongbo Zhang The dummy data of cpu_hz_max and model_str are used when platform is unknown or data cannot be acquired, but these variables should be set in function odp_cpuinfo_parser() instead of the systemcpu() which should cover only the cpu_count, huge_page_size and cache_line_size. Sig

[lng-odp] [PATCH v5 4/8] linux-generic: create ARM files and move ARM ODP_CACHE_LINE_SIZE in it

From: Hongbo Zhang Currently all ODP_CACHE_LINE_SIZE macros for different architectures are held in one header file, they should be moved to their own arch file. And in the legacy codes there was no ARM architecture directory, so this patch create it, the odp_cpu_arch.c and odp_sysinfo_parse.c ar

[lng-odp] [PATCH v5 6/8] linux-generic: systemcpu(): use input parameter instead of global data

From: Hongbo Zhang In the systemcpu() function, odp_global_data.system_info.huge_page_size should be sysinfo->huge_page_size instead, because when systemcpu() is called, the &odp_global_data.system_info is passed as parameter, we should operate the parameter instead of the global data directly, w

[lng-odp] [PATCH v5 3/8] linux-generic: separate PowerPC ODP_CACHE_LINE_SIZE to its arch file

From: Hongbo Zhang Currently all ODP_CACHE_LINE_SIZE macros for different architectures are held in one header file, they should be moved to their own arch file. This patch moves ODP_CACHE_LINE_SIZE for PowerPC. The previous arch/powerpc/odp/cpu_arch.h was a symlink to the generic arch/linux/odp/

[lng-odp] [PATCH v5 2/8] linux-generic: separate MIPS ODP_CACHE_LINE_SIZE to its arch file

From: Hongbo Zhang Currently all ODP_CACHE_LINE_SIZE macros for different architectures are held in one header file, they should be moved to their own arch file. This patch moves ODP_CACHE_LINE_SIZE for MIPS. Signed-off-by: Hongbo Zhang Reviewed-and-tested-by: Bill Fischofer --- platform/linu

[lng-odp] [PATCH v5 1/8] linux-generic: separate x86 ODP_CACHE_LINE_SIZE to its arch file

From: Hongbo Zhang Currently all ODP_CACHE_LINE_SIZE macros for different architectures are held in one header file, they should be moved to their own arch file. This patch moves ODP_CACHE_LINE_SIZE for x86. Signed-off-by: Mike Holmes Signed-off-by: Hongbo Zhang Reviewed-and-tested-by: Bill Fi

[lng-odp] [PATCH v5 0/8] Put ODP_CACHE_LINE_SIZE in ARCH file

Rebased Hongbo Zhang (8): linux-generic: separate x86 ODP_CACHE_LINE_SIZE to its arch file linux-generic: separate MIPS ODP_CACHE_LINE_SIZE to its arch file linux-generic: separate PowerPC ODP_CACHE_LINE_SIZE to its arch file linux-generic: create ARM files and move ARM ODP_CACHE_LINE_SIZE

Re: [lng-odp] Crash on odp_cpuinfo_parser

Thanks Mike & Maxim. You are so helpful. Regards, Wenxian On 2 March 2016 at 22:33, Maxim Uvarov wrote: > Has to be fixed with that commit: > > commit 50333e89b6c35edfa1221a4fbb74fc34bea6865d > Author: Hongbo Zhang > Date: Tue Feb 23 17:25:12 2016 +0800 > > linux-generic: fix usage of fu

Re: [lng-odp] Crash on odp_cpuinfo_parser

Has to be fixed with that commit: commit 50333e89b6c35edfa1221a4fbb74fc34bea6865d Author: Hongbo Zhang Date: Tue Feb 23 17:25:12 2016 +0800 linux-generic: fix usage of function strncpy This is for https://bugs.linaro.org/show_bug.cgi?id=2030: "Memory - illegal accesses (BUFFER_S

[lng-odp] [PATCHv2 2/2] linux-generic: test: ODP_SHM_PROC test

Adding a platform side test to test sharing memory between ODP and linux. Also tests that the shared memory device name (under /dev/shm/) is scoped. Signed-off-by: Christophe Milard Reviewed-and-tested-by: Bill Fischofer --- platform/linux-generic/m4/configure.m4 | 1 + platform/lin

[lng-odp] [PATCHv2 1/2] linux-generic: test: adding odp includes

A new Makefile.inc is created, defining common includes that linux specific tests will need if they need to build with ODP. Tests just acting as wrappers around platform agnostic tests will not need these defines, whereas tests building ODP executable will. Signed-off-by: Christophe Milard Review

[lng-odp] [PATCHv2 0/2] linux test for shared memory

(Note: requires: linux-generic: shmem: odp scope in /dev/shmem) Adding a platform side test to test sharing memory between ODP and linux. This test is more interresting for its side effects: *first complete test on the platform side building ODP and platform programs (other platform tests so far w

Re: [lng-odp] [PATCH] linux-generic: netmap: increase maximum descriptor count

Hi, Isn't 64 input/output queues quite low? Typically, the number of queues is the same as the number of virtual CPUs. Considering that typical high-end CPUs have 10 cores and HyperThreading (20 virtual CPUs total) and that high-end servers can have two CPU sockets (40 virtual CPUs total), the

Re: [lng-odp] [PATCH v1] validation: classification: add test case for odp_cos_drop() function

Ping Regards, Bala On 18 February 2016 at 18:18, Balasubramanian Manoharan < bala.manoha...@linaro.org> wrote: > Fixes: https://bugs.linaro.org/show_bug.cgi?id=2016 > > Signed-off-by: Balasubramanian Manoharan > --- > test/validation/classification/odp_classification_basic.c | 3 +++ > 1 file

Re: [lng-odp] [PATCH 0/2] linux test for shared memory

Bien sûr. ☺ On Wed, Mar 2, 2016 at 7:33 AM, Christophe Milard < christophe.mil...@linaro.org> wrote: > Ok. I'll send a v2 with atht typo fixed and your reviewed message, if that > is OK with you. > > On 2 March 2016 at 14:31, Bill Fischofer > wrote: > >> Ah, OK. That wasn't obvious, so ignore

Re: [lng-odp] [PATCH 0/2] linux test for shared memory

Ok. I'll send a v2 with atht typo fixed and your reviewed message, if that is OK with you. On 2 March 2016 at 14:31, Bill Fischofer wrote: > Ah, OK. That wasn't obvious, so ignore my issue 2: > > For this series: > > Reviewed-and-tested-by: Bill Fischofer > > On Wed, Mar 2, 2016 at 7:30 AM, Ch

Re: [lng-odp] [PATCH 0/2] linux test for shared memory

Ah, OK. That wasn't obvious, so ignore my issue 2: For this series: Reviewed-and-tested-by: Bill Fischofer On Wed, Mar 2, 2016 at 7:30 AM, Christophe Milard < christophe.mil...@linaro.org> wrote: > shmem_odp should not be run alone: it is forked and execv'd by shmem > linux. If you run make c

Re: [lng-odp] [PATCH 0/2] linux test for shared memory

shmem_odp should not be run alone: it is forked and execv'd by shmem linux. If you run make check, only shmem_linux is actually called: shmem_linux forks and execv shmem_odp and makes sure it see the shared memory. The comment at the beginning of shmem_linux.c explains it all... hopefully :-)

Re: [lng-odp] [PATCH 0/2] linux test for shared memory

Sorry, my bad. I forgot about --enable-test-vald When I add that then the tests build properly, so ignore my point 1. However, while shmem_linux runs and passes, shmem_odp still hangs. On Wed, Mar 2, 2016 at 7:19 AM, Christophe Milard < christophe.mil...@linaro.org> wrote: > Make shmem_odp wil

[lng-odp] [Bug 2103] New: netmap is not tested under CI

https://bugs.linaro.org/show_bug.cgi?id=2103 Bug ID: 2103 Summary: netmap is not tested under CI Product: OpenDataPlane - linux- generic reference Version: api-next Hardware: Other OS: Linux Status: UNCONFIRMED

Re: [lng-odp] [PATCH] validation: timer: replace %d by PRIu32

On 25 February 2016 at 05:31, Maxim Uvarov wrote: > On 02/23/16 18:47, Nicolas Morey-Chaisemartin wrote: > >> Signed-off-by: Nicolas Morey-Chaisemartin >> > Reviewed-by: Mike Holmes > --- >> test/validation/timer/timer.c | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> di

Re: [lng-odp] [PATCH 0/2] linux test for shared memory

Make shmem_odp will hang alone: it needs its linux counterpart. Make should fix that for you. I assume as soon as we sort out why you have this make problme, it will work better. And I have noticed the typo in the second patch title ODP_SHM_PROP should be ODP_SHM_PROC. will be fix in v2 with your

[lng-odp] [Bug 2102] New: make distcheck does not inherit original options

https://bugs.linaro.org/show_bug.cgi?id=2102 Bug ID: 2102 Summary: make distcheck does not inherit original options Product: OpenDataPlane - linux- generic reference Version: api-next Hardware: Other OS: Linux Statu

Re: [lng-odp] [PATCHv2 0/2] cleanly destroy resources

For this series: Reviewed-by: Bill Fischofer On Tue, Mar 1, 2016 at 9:52 AM, Maxim Uvarov wrote: > ping. Please review. > > (Should be simple run and see that there is no ODP_ERR() on ending > term_global() ) > > Maxim. > > On 02/25/16 15:35, Maxim Uvarov wrote: > >> v2: apply on master, not a

Re: [lng-odp] [PATCH 0/2] linux test for shared memory

shouldn't you have --enable-test-vald as well? If I run: ./bootstrap && ./configure --with-cunit-path=/home/erachmi/linaro/ODP/check-odp/installed/x86_64/cunit-2.1-3 --enable-test-vald && make -j 8 && make check I get: ... make[3]: Entering directory '/home/erachmi/linaro/ODP/odp/platform/linux-

Re: [lng-odp] [API-NEXT v6] doc: user-guide documentation for classification

Hi Maxim, Can you please merge this patch. Regards, Bala On 1 March 2016 at 08:53, Bill Fischofer wrote: > One small typo noted. Other than that: > > Reviewed-and-tested-by: Bill Fischofer > > > On Mon, Feb 29, 2016 at 7:16 AM, Balasubramanian Manoharan < > bala.manoha...@linaro.org> wrote:

Re: [lng-odp] Crash on odp_cpuinfo_parser

On 2 March 2016 at 01:03, Wenxian Li wrote: > Hi Experts, > > I met an ODP crash in linux generic. > It crashes at requiring the CPU frequency. > > pos = strchr(sysinfo->model_str[id], '@'); > *(pos - 1) = '\0'; > > My testbed is an ubuntu running on KVM, and the CPU model is: > "model name : QEM

Re: [lng-odp] [API-NEXT PATCH] api: do not split function prototypes

On Wed, Mar 2, 2016 at 6:37 AM, Petri Savolainen wrote: > Fixed function prototype formats on crypto and random api files. > Function return type and function name should be on the same line. > For example, it's easy to find all odp functions which return int32_t > (grep 'int32_t odp_') when the

Re: [lng-odp] [PATCH 0/2] linux test for shared memory

I failed to notice the pre-req. However after applying that patch I see the same behavior. ./bootstrap ./configure --enable-cunit-support make Result: nothing built in platforms/linux-generic/test/shmem If I go into that directory and type make then shmem_odp is built, but when I try to run it

[lng-odp] [API-NEXT PATCH] api: do not split function prototypes

Fixed function prototype formats on crypto and random api files. Function return type and function name should be on the same line. For example, it's easy to find all odp functions which return int32_t (grep 'int32_t odp_') when the return type is on the same line. Signed-off-by: Petri Savolainen

Re: [lng-odp] [API-NEXT PATCH v3 9/9] linux-generic: validation: add netmap test

On 02/26/16 16:48, Elo, Matias (Nokia - FI/Espoo) wrote: -Original Message- From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of EXT Maxim Uvarov Sent: Thursday, February 25, 2016 1:47 PM To: lng-odp@lists.linaro.org Subject: Re: [lng-odp] [API-NEXT PATCH v3 9/9] linux-g

Re: [lng-odp] [PATCH 0/2] linux test for shared memory

Hi Bill thanks for looking At it: I guess (hope) that point 2 is because the patch scoping shmem has not been merged yet (see first line of the cover letter). If you do have applied this patch, then I don't understand. (please confirm). I am very confused about point 1): I had a long fight with aut

Re: [lng-odp] [PATCH 0/2] linux test for shared memory

Two problems: 1. After applying this patch make doesn't make this test (Make infrastructure needs updating) 2. If I manually make the test, running it seems to hang. Haven't investigated further. On Tue, Mar 1, 2016 at 10:34 AM, Christophe Milard < christophe.mil...@linaro.org> wrote: > (Note:

Re: [lng-odp] [API-NEXT PATCH 1/2] api: sched: add schedule group info struct

For this series: Reviewed-and-tested-by: Bill Fischofer On Wed, Mar 2, 2016 at 4:36 AM, Petri Savolainen wrote: > Added info struct and call to enable request of schedule > group name among all other (potential new) parameters. > Currently, there are only two parameters: name and thrmask. > Th

Re: [lng-odp] [PATCH] linux-generic: netmap: increase maximum descriptor count

Merged, Maxim. On 02/26/16 17:02, Matias Elo wrote: Increase maximum descriptor count to support NICs with up to 64 input/output queues. Related debug messages are also improved. Signed-off-by: Matias Elo --- platform/linux-generic/include/odp_packet_netmap.h | 2 +- platform/linux-generic/

Re: [lng-odp] [API-NEXT PATCH 1/3] doc: images: add gv file for pktio state machine

Looks like Mike's doc restructure patch merged ahead of this one so Part 1 needed more than just a rebase. v2 sent which should now apply and build. Thanks. On Wed, Mar 2, 2016 at 3:24 AM, Christophe Milard < christophe.mil...@linaro.org> wrote: > Sorry. confused. What do I do wrong? > > erachm

[lng-odp] [API-NEXT PATCH 1/2] api: sched: add schedule group info struct

Added info struct and call to enable request of schedule group name among all other (potential new) parameters. Currently, there are only two parameters: name and thrmask. Thread mask call can be left as is, since it's suitable for fast path usage. Signed-off-by: Petri Savolainen --- include/odp

[lng-odp] [API-NEXT PATCH 2/2] linux-generic: sched: add schedule group info

Added implementation and validation test for schedule group info struct. Signed-off-by: Petri Savolainen --- platform/linux-generic/odp_schedule.c | 21 + test/validation/scheduler/scheduler.c | 8 2 files changed, 29 insertions(+) diff --git a/platform/linux-gener

[lng-odp] [API-NEXT PATCHv2 3/3] doc: userguide: add PktIO chapter to ODP User Guide

Signed-off-by: Bill Fischofer --- doc/users-guide/users-guide-pktio.adoc | 605 + doc/users-guide/users-guide.adoc | 2 + 2 files changed, 607 insertions(+) create mode 100644 doc/users-guide/users-guide-pktio.adoc diff --git a/doc/users-guide/users-guide

[lng-odp] [API-NEXT PATCHv2 1/3] doc: images: add gv file for pktio state machine

The PktIO FSM state diagram is built using GraphVis. Add the files and associated Makefile and .gitignore changes needed to support this new file. Signed-off-by: Bill Fischofer --- doc/Makefile.inc| 3 +++ doc/images/.gitignore | 1 + doc/images/pktio_fsm.gv | 17

Re: [lng-odp] [API-NEXT PATCH] linux-generic: dpdk: fix mtu return value type

Merged, Maxim. On 02/26/16 18:05, Bill Fischofer wrote: On Thu, Feb 25, 2016 at 6:08 AM, Matias Elo > wrote: DPDK pktio build is broken after odp_pktio_mtu() API change. Fix this by using correct return value type in dpdk_mtu_get(). Signed-off-by

Re: [lng-odp] [PATCH v2] configure.ac: distribute the AC_CONFIG_FILES

Merged, Maxim. On 02/29/16 12:19, Christophe Milard wrote: On 2016-02-26 17:29, Mike Holmes wrote: Signed-off-by: Mike Holmes Reviewed-by: Christophe Milard --- v2 Sort lists suggested by Maxim configure.ac| 44 doc/m4/config

Re: [lng-odp] [API-NEXT PATCH 1/3] doc: images: add gv file for pktio state machine

Sorry. confused. What do I do wrong? erachmi@erachmi-ericsson:~/linaro/ODP/odp$ git remote -v origin https://git.linaro.org/lng/odp.git (fetch) origin https://git.linaro.org/lng/odp.git (push) own ssh://g...@git.linaro.org/people/christophe.milard/odp.git (fetch) own ssh://g...@git.linaro.org/peop

Re: [lng-odp] [API-NEXT PATCH 1/3] doc: images: add gv file for pktio state machine

On 03/02/16 10:20, Christophe Milard wrote: Hi Bill, I am probably missing something obvious, but that Makefile does not exist for me... Does this require some previous patch that have made their way to the repo yet? erachmi@erachmi-ericsson:~/linaro/ODP/odp$ git am ~/incoming/lng-odp_API-NE