Re: [lng-odp] [PATCH] configure: reorder m4_includes

Hi, At least for me configure is still failing after this patch. $ ./configure --enable-test-perf --enable-test-vald --enable-test-cpp --with-cunit-path= --with-dpdk-path= --with-netmap-path= --prefix= checking for CU_get_error in -lcunit... no configure: error: CUnit libraries required make:

Re: [lng-odp] [openfastpath] User defined context pointer associated with pktio

Hi Bogdan, Sorry, but it looks like this question fell through the cracks as it was posted during BKK16 when everyone was distracted with other items. It would be trivial to add a user context field to the odp_pktio_param_t that's specified at odp_pktio_open() time. This is retrievable via

Re: [lng-odp] [PATCHv6] linux-generic: test: shmem: atomic check+open fifo

On Wed, Apr 6, 2016 at 7:31 AM, Christophe Milard < christophe.mil...@linaro.org> wrote: > Fixes: https://bugs.linaro.org/show_bug.cgi?id=2146 (CID 159395) > The open system call is directely used to check the presence of the fifo > and open it at the same time. > > Signed-off-by: Christophe

[lng-odp] [Bug 2168] platform/linux-generic/odp_init.c: stage is never used

https://bugs.linaro.org/show_bug.cgi?id=2168 Bill Fischofer changed: What|Removed |Added CC|

[lng-odp] [Bug 2168] New: platform/linux-generic/odp_init.c: stage is never used

https://bugs.linaro.org/show_bug.cgi?id=2168 Bug ID: 2168 Summary: platform/linux-generic/odp_init.c: stage is never used Product: OpenDataPlane - linux- generic reference Version: 1.8 Hardware: Other OS:

[lng-odp] [API-NEXT PATCH] api: debug: promote ODP_STATIC_ASSERT() to be an ODP API

Convert the formerly internal _ODP_STATIC_ASSERT() macro to be a full ODP API named ODP_STATIC_ASSERT(). This provides a wrapper around any platform-specific compile-time assertion macro. Signed-off-by: Bill Fischofer --- helper/include/odp/helper/eth.h

Re: [lng-odp] [API-NEXT PATCH 1/3] api: add cuckoo hash api

Last year, there was a discussion about cuckoo hash. I saw the last reply (https://lists.linaro.org/pipermail/lng-odp/2015-December/017921.html). You recommended to: “ 1) have this code with queues api; 2) remove ring code completely from helper 3) move ring code inside linux-generic (I

Re: [lng-odp] [PATCH 1/2] validation: pktio: fix statistics test

Merged this 1/2 patch. (trivial enhancements). Maxim. On 04/05/16 16:20, Matias Elo wrote: Stop trying to schedule new packets if all sent packets have already been received. Signed-off-by: Matias Elo --- test/validation/pktio/pktio.c | 8 +--- 1 file changed, 5

Re: [lng-odp] [PATCH 2/2] linux-generic: dpdk: implement pktio statistics

On 04/05/16 16:20, Matias Elo wrote: Copied pktio statistics implementation from odp-dpdk branch. Signed-off-by: Matias Elo --- platform/linux-generic/pktio/dpdk.c | 39 + 1 file changed, 39 insertions(+) diff --git

Re: [lng-odp] [API-NEXT PATCH 1/3] api: add cuckoo hash api

If that hash can not be hardware accelerated than it should be an odp helper and have odph_ prefix. Maxim. On 04/06/16 13:02, Ru Jia wrote: Added cuckoo hash api, which is an efficient hash table. It could be used for many algorithms. Signed-off-by: Ru Jia ---

Re: [lng-odp] [PATCHv2] linux-generic: packet pool runs out of blocks

On Wed, Apr 6, 2016 at 6:08 AM, Oriol Arcas wrote: > The packet pool may run out of blocks before reaching the low buffer > watermark. A block low watermark is added to fix it. > > Signed-off-by: Oriol Arcas > Reviewed-and-tested-by: Bill

Re: [lng-odp] [PATCH] linux-generic: dpdk: always set input hash functions

Merged, Maxim. On 04/06/16 08:18, Elo, Matias (Nokia - FI/Espoo) wrote: Thanks, -Matias *From:*EXT Bill Fischofer [mailto:bill.fischo...@linaro.org] *Sent:* Wednesday, April 06, 2016 3:22 AM *To:* Elo, Matias (Nokia - FI/Espoo) *Cc:* LNG ODP Mailman List

Re: [lng-odp] [PATCH] configure: reorder m4_includes

Merged, Maxim. On 04/05/16 20:08, Brian Brooks wrote: On 04/01 22:15:34, Anders Roxell wrote: Reorder the m4_include due to LIBS get contaminated while checking for libraries. Configure error: checking for GCC atomic builtins... no GCC-style __atomic builtins not supported by the compiler. Use

Re: [lng-odp] [API-NEXT PATCH 1/3] api: add cuckoo hash api

Thank you for the patch Remember that if there is a new API added we also need good validation test coverage in test/validation for it to be accepted eventually into master. The performance test is a really good thing to have but we need a cunit test case to help platforms ensure that they all

[lng-odp] [PATCHv6] linux-generic: test: shmem: atomic check+open fifo

Fixes: https://bugs.linaro.org/show_bug.cgi?id=2146 (CID 159395) The open system call is directely used to check the presence of the fifo and open it at the same time. Signed-off-by: Christophe Milard --- platform/linux-generic/test/shmem/shmem_linux.c | 15

Re: [lng-odp] [PATCH] linux-generic: packet pool runs out of blocks

Thank you for the comments, Bill and Maxim. I provided a PATCHv2. I addressed everything, but for odp_pool.c I left the inline variable declarations to not break the readability. -- Oriol Arcas Software Engineer Starflow Networks On Tue, Apr 5, 2016 at 9:54 PM, Bill Fischofer

[lng-odp] [PATCHv2] linux-generic: packet pool runs out of blocks

The packet pool may run out of blocks before reaching the low buffer watermark. A block low watermark is added to fix it. Signed-off-by: Oriol Arcas --- v2: renamed variables and added stats v1: fix for https://bugs.linaro.org/show_bug.cgi?id=2151

Re: [lng-odp] [PATCH] validation: pktio: remove octet check from stats test

On 05/04/16 17:16, Zoltan Kiss wrote: This test sets up two interface and connect them to each other, so in s/interface/interfaces/ Maxim, could you fix that when commit? (assuming the patch is OK) And an another note: Maxim told me when I brought this up first to disable stuff, and I

Re: [lng-odp] [PATCHv5] linux-generic: test: shmem: atomic check+open fifo

On 04/06/16 09:26, Christophe Milard wrote: I agree. But this was required by Maxim, If I understood him right. You can have a look at the previous versions (v4, v3) for different alternatives. I don't know what to do now. Maxim & Bill: If you can agree on something, I'd be happy to round

[lng-odp] [API-NEXT PATCH 2/3] linux-generic: add implementation of cuckoo hash

Signed-off-by: Ru Jia --- platform/linux-generic/Makefile.am | 2 + platform/linux-generic/odp_cuckoo_hash.c | 941 +++ 2 files changed, 943 insertions(+) create mode 100644 platform/linux-generic/odp_cuckoo_hash.c diff --git

[lng-odp] [API-NEXT PATCH 3/3] test/performance: add test program of cuckoo hash

Add the basic validation test and performance test programs of the cuckoo hash table. Signed-off-by: Ru Jia --- test/performance/Makefile.am | 4 +- test/performance/odp_cuckoo_hash.c | 771 + 2 files changed, 774 insertions(+), 1

[lng-odp] [API-NEXT PATCH 1/3] api: add cuckoo hash api

Added cuckoo hash api, which is an efficient hash table. It could be used for many algorithms. Signed-off-by: Ru Jia --- include/odp/api/spec/cuckoo_hash.h | 463 + include/odp_api.h | 1 +

[lng-odp] [PATCHv3] test: performance: Avoid possible out-of-bounds memory access

Resolving https://bugs.linaro.org/show_bug.cgi?id=2136 by initializing definite number of worker threads. Signed-off-by: Balakrishna Garapati --- v1: Fix for the https://bugs.linaro.org/show_bug.cgi?id=2136 v2: comments from v1 v3: Adding commit message

Re: [lng-odp] [PATCHv5] linux-generic: test: shmem: atomic check+open fifo

I agree. But this was required by Maxim, If I understood him right. You can have a look at the previous versions (v4, v3) for different alternatives. I don't know what to do now. Maxim & Bill: If you can agree on something, I'd be happy to round that up :-). Christophe On 6 April 2016 at