Re: [lng-odp] [PATCH v2 4/4] linux-gen: pktio: don't allocate new packets in classifier

Hi Oriol, Sounds like there is a bug in the raw socket implementation. I’ll take a look. As a side note, there is currently no classifier performance test as far as I can see. Performance test would be useful to prevent issues like this in the future. Additionally, classifier validation tests

[lng-odp] ML test

Hi, Can ayone using the ML on gmail can see this? IT tweaked some things in our mail server configuration and not sure if we still ned up in Junk or not :) Thanks Nicolas ___ lng-odp mailing list lng-odp@lists.linaro.org https://lists.linaro.org/

Re: [lng-odp] thread/shmem discussion summary V4

Hi, thanks Christophe and happy to discuss with and learn from team in yesterday's ARCH call :) The question which triggers this kind of thinking is: how to use ODP as a framework to produce re-usable building blocks to compose "Network Function Instance" in runtime, since until runtime it will pr

Re: [lng-odp] [PATCH v2 4/4] linux-gen: pktio: don't allocate new packets in classifier

Regards, Bala On 8 June 2016 at 12:24, Elo, Matias (Nokia - FI/Espoo) wrote: > > >> On 2 June 2016 at 13:15, Matias Elo wrote: >> > Don't allocate new packets inside of the internal >> > classifier helpers _odp_packet_cls_enq() and >> > _odp_packet_classifier(). Instead, save destination queue

Re: [lng-odp] thread/shmem discussion summary V4

OK. good that you agree (and please update the shared doc so it becomes the central point of information). There is something I like though, in your willingness to decouple the function and the pinning... Even if I am not sure this can be enforced by ODP at all time (as already stated), there is de

Re: [lng-odp] packet copy questions

And what about this first question: Should _odp_packet_copy_md_to_packet() copy timestamp and op_result? On 07/06/16 13:03, Bill Fischofer wrote: Sounds like this should be considered a bug. I'll open one to track it. On Tue, Jun 7, 2016 at 2:18 AM, Savolainen, Petri (Nokia - FI/Espoo) mailto:

Re: [lng-odp] [PATCH] example: timer simple

On Wed, Jun 8, 2016 at 1:57 AM, Maxim Uvarov wrote: > On 06/08/16 06:07, Bill Fischofer wrote: > >> >> >> On Tue, Jun 7, 2016 at 3:46 PM, Maxim Uvarov > > wrote: >> >> Example for simple timer usage. >> https://bugs.linaro.org/show_bug.cgi?id=2090 >> >>

[lng-odp] [RFCv2 API-NEXT] Adding API for Multi crypto operation support.

Signed-off-by: Nikhil Agarwal --- include/odp/api/spec/crypto.h | 29 +++-- 1 file changed, 27 insertions(+), 2 deletions(-) diff --git a/include/odp/api/spec/crypto.h b/include/odp/api/spec/crypto.h index d8123e9..7b4424d 100644 --- a/include/odp/api/spec/crypto.h +++ b/

Re: [lng-odp] thread/shmem discussion summary V4

On Fri, Jun 03, 2016 at 11:15:43AM +0200, Christophe Milard wrote: > since V3: Update following Bill's comments > since V2: Update following Barry and Bill's comments > since V1: Update following arch call 31 may 2016 > > This is a tentative to sum up the discussions around the thread/process > th

Re: [lng-odp] thread/shmem discussion summary V4

Thanks Jerin, I have merged your comments into the doc: there were many points you did not comments (not sure whether the yes below a group applied to the group of statement). You can review the doc to make sure I did not corrupt your feelings :-) once again, Thanks Christophe. On 8 June 2016 a

Re: [lng-odp] [PATCH 1/2] linux-generic: packet: copy user area as part of odp_packet_copy()

Hi, On 07/06/16 15:53, Bill Fischofer wrote: Resolve Bug https://bugs.linaro.org/show_bug.cgi?id=2310 by copying the user area as part of odp_packet_copy(). The copy fails if the user area size of the destination pool is not large enough to hold the source packet user area. Signed-off-by: Bill

Re: [lng-odp] [PATCH 2/2] validation: packet: ensure user area is copied correctly

Reviewed-by: Zoltan Kiss On 07/06/16 15:53, Bill Fischofer wrote: As part of resolution of Bug https://bugs.linaro.org/show_bug.cgi?id=2310 make sure that odp_packet_copy() handles user area copies correctly. The copy should fail if the target pool's user area size is not large enough to contai

Re: [lng-odp] [PATCH v2 4/4] linux-gen: pktio: don't allocate new packets in classifier

There is a bug in the pktin_recv_buf() function. I’ll submit a proper patch tomorrow, but the following patch fixes the issue. platform/linux-generic/odp_packet_io.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/platform/linux-generic/odp_packet_io.c b/platform/linux-

Re: [lng-odp] [PATCH] configure: split up libodphelper SO-version from libodp

On 7 June 2016 at 16:29, Anders Roxell wrote: > They can be updated separately so no need to bump both versions at the > same time, specially when there is no change in one of them. > I think it is clearer to say that the libodphelper and libodp lib need to track their evolving abi independe

Re: [lng-odp] thread/shmem discussion summary V4

Hi, Christophe and team For the shmem part: S18: yes S19, S20: I agree with Bill's comments are very accurate and formalized. S21: to cover the case shm addresses(pointers) passed within data structure especially think of cases: 3) Context pointer getters (odp_queue_context(), odp_packet_user_p

[lng-odp] [PATCHv2] configure: split up libodphelper SO-version from libodp

The libodphelper and libopd need to track their evolving ABI independently and so there needs to be two separate version numbers. Signed-off-by: Anders Roxell --- configure.ac | 3 +++ helper/Makefile.am | 2 +- 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/configure.ac b/c

Re: [lng-odp] [PATCH] example: timer simple

On 06/08/16 14:22, Bill Fischofer wrote: On Wed, Jun 8, 2016 at 1:57 AM, Maxim Uvarov > wrote: On 06/08/16 06:07, Bill Fischofer wrote: On Tue, Jun 7, 2016 at 3:46 PM, Maxim Uvarov mailto:maxim.uva...@linaro.org>

Re: [lng-odp] [PATCHv2] configure: split up libodphelper SO-version from libodp

it will be more complicated to follow dependencies if there will be separate version. I think for now it's better to stay with existence version numbers. Maxim. On 8 June 2016 at 19:15, Anders Roxell wrote: > The libodphelper and libopd need to track their evolving ABI > independently and so th

Re: [lng-odp] [PATCHv2] configure: split up libodphelper SO-version from libodp

On 8 June 2016 at 14:33, Maxim Uvarov wrote: > it will be more complicated to follow dependencies if there will be > separate version. I think for now it's better to stay with existence > version numbers. > Can you explain the complication, I thought this makes things much simpler. As Yi decoup

Re: [lng-odp] [API-NEXT PATCHv1 0/4] implement mechanism to allow inline and no inline use of ODP API

Hi, ODP-DPDK already has a simpler solution for this problem, the first patch was posted here as well: https://git.linaro.org/lng/odp-dpdk.git/commitdiff/968237b592a8162041a4edf0091575fd1390d647 It can get simpler as it doesn't need a separate config option, but it automatically turns on whe

Re: [lng-odp] [PATCHv2] configure: split up libodphelper SO-version from libodp

On 06/08/16 21:46, Mike Holmes wrote: On 8 June 2016 at 14:33, Maxim Uvarov > wrote: it will be more complicated to follow dependencies if there will be separate version. I think for now it's better to stay with existence version numbers. Can you

[lng-odp] [PATCHv2] example: timer simple

Example for simple timer usage. https://bugs.linaro.org/show_bug.cgi?id=2090 Signed-off-by: Maxim Uvarov --- v2: use better name for pool and more return code checks on destroy (Bills comments). example/timer/.gitignore | 1 + example/timer/Makefile.am| 12 ++- example/time

[lng-odp] [PATCHv2 1/2] linux-generic: packet: copy user area as part of odp_packet_copy()

Resolve Bug https://bugs.linaro.org/show_bug.cgi?id=2310 by copying the user area as part of odp_packet_copy(). The copy fails if the user area size of the destination pool is not large enough to hold the source packet user area. Reported-by: Zoltan Kiss Signed-off-by: Bill Fischofer --- v2: Zol

[lng-odp] [PATCHv2 2/2] validation: packet: ensure user area is copied correctly

As part of resolution of Bug https://bugs.linaro.org/show_bug.cgi?id=2310 make sure that odp_packet_copy() handles user area copies correctly. The copy should fail if the target pool's user area size is not large enough to contain the source user area. Signed-off-by: Bill Fischofer --- test/vali

Re: [lng-odp] [PATCH 1/2] linux-generic: packet: copy user area as part of odp_packet_copy()

On Wed, Jun 8, 2016 at 8:23 AM, Zoltan Kiss wrote: > Hi, > > > On 07/06/16 15:53, Bill Fischofer wrote: > >> Resolve Bug https://bugs.linaro.org/show_bug.cgi?id=2310 by copying the >> user area as part of odp_packet_copy(). The copy fails if the user area >> size of the destination pool is not la

Re: [lng-odp] [PATCHv2] example: timer simple

On Wed, Jun 8, 2016 at 2:27 PM, Maxim Uvarov wrote: > Example for simple timer usage. > https://bugs.linaro.org/show_bug.cgi?id=2090 > > Signed-off-by: Maxim Uvarov > Reviewed-and-tested-by: Bill Fischofer > --- > v2: use better name for pool and more return code checks on destroy > (Bills

Re: [lng-odp] thread/shmem discussion summary V4

On Wed, Jun 8, 2016 at 10:54 AM, Yi He wrote: > Hi, Christophe and team > > For the shmem part: > > S18: yes > S19, S20: I agree with Bill's comments are very accurate and formalized. > > S21: to cover the case shm addresses(pointers) passed within data structure > > especially think of cases: >

[lng-odp] [PATCH] linux-gen: pktio: fix variable overwrite in pktin_recv_buf

Fix variable overwrite bug in pktin_recv_buf(). Signed-off-by: Matias Elo --- platform/linux-generic/odp_packet_io.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/platform/linux-generic/odp_packet_io.c b/platform/linux-generic/odp_packet_io.c index 6de39b6..416a361

Re: [lng-odp] [PATCH] validation: tm: avoid resouce/memory leaks in corner cases

On 06/06/16 23:40, Bill Fischofer wrote: Resolve Bug https://bugs.linaro.org/show_bug.cgi?id=2306 by cleaning up TM queues and nodes in error paths. Signed-off-by: Bill Fischofer --- test/validation/traffic_mngr/traffic_mngr.c | 13 + 1 file changed, 13 insertions(+) diff --git

Re: [lng-odp] [PATCH] linux-gen: pktio: fix variable overwrite in pktin_recv_buf

uh... good fix, thanks :) On 06/09/16 08:24, Matias Elo wrote: Fix variable overwrite bug in pktin_recv_buf(). Signed-off-by: Matias Elo --- platform/linux-generic/odp_packet_io.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/platform/linux-generic/odp_packet_io