Re: [lng-odp] [PATCHv2] test: linux-gen: add pcap playback test

On Tue, Aug 2, 2016 at 11:08 AM, Maxim Uvarov wrote: > add pcap play back test which takes 2 arguments: 1 - pcap file, > 2 - packet mask to match. Intend is to test odp with different > input traffic to check internal implementation functions. In > current case it's test

Re: [lng-odp] [PATCH v2 2/6] linux-generic: use source files instead of symbolic links

On 4 August 2016 at 15:30, Brian Brooks wrote: > Use source files in arch/default for undetected archs. This > alleviates the need to use symlinks in the source code > directory structure. > I prefer a behaviour where this fails at config time if a new ARCH appears. If

[lng-odp] [PATCH v2 6/6] linux-generic: internal odp_cpu_hz_current()

Prefix odp_cpu_hz_current with '_' to be consistent with other internal cpu definitions in arch directory. Signed-off-by: Brian Brooks --- platform/linux-generic/arch/default/odp_sysinfo_parse.c | 3 ++- platform/linux-generic/arch/mips64/odp_sysinfo_parse.c | 3 ++-

[lng-odp] [PATCH v2 5/6] linux-generic: internal odp_cpu_cycles()

Lift the definition of odp_cpu_cycles() out of the arch specific directory into the common odp_cpu.c which then calls the internal arch specific definition. Signed-off-by: Brian Brooks --- platform/linux-generic/Makefile.am | 1 +

[lng-odp] [PATCH v2 4/6] linux-generic: lift odp_cpu_cycles_max/resolution()

Define odp_cpu_cycles_max() and odp_cpu_cycles_resolution() in the include API directory. These do not point to an internal value in arch because they are common across all archs. Signed-off-by: Brian Brooks --- platform/linux-generic/arch/default/odp_cpu_arch.c | 10

[lng-odp] [PATCH v2 2/6] linux-generic: use source files instead of symbolic links

Use source files in arch/default for undetected archs. This alleviates the need to use symlinks in the source code directory structure. Signed-off-by: Brian Brooks --- configure.ac | 13 +- platform/Makefile.inc

[lng-odp] [PATCH v2 1/6] linux-generic: internal odp_cpu_pause()

Signed-off-by: Brian Brooks --- platform/linux-generic/arch/default/odp/api/cpu_arch.h | 2 +- platform/linux-generic/arch/mips64/odp/api/cpu_arch.h | 2 +- platform/linux-generic/arch/powerpc/odp/api/cpu_arch.h | 2 +- platform/linux-generic/arch/x86/odp/api/cpu_arch.h

[lng-odp] [Bug 2456] New: ODP name string lengths are multiply defined across the API

https://bugs.linaro.org/show_bug.cgi?id=2456 Bug ID: 2456 Summary: ODP name string lengths are multiply defined across the API Product: OpenDataPlane - linux- generic reference Version: v1.10.1 Hardware: Other

Re: [lng-odp] [PATCH] validation: tm: use strncmp() to avoid potential string overrun

On Thu, Aug 4, 2016 at 10:23 AM, Mike Holmes wrote: > > > On 3 August 2016 at 17:06, Bill Fischofer > wrote: > >> Resolve Bug https://bugs.linaro.org/show_bug.cgi?id=2426 by switching >> from >> strcmp() to strncmp() >> >> Signed-off-by: Bill

Re: [lng-odp] [PATCH] test:linux-generic: run odp_scheduling in process mode

On Thu, Aug 4, 2016 at 11:17 AM, Brian Brooks wrote: > On 08/04 11:01:09, Bill Fischofer wrote: > > On Thu, Aug 4, 2016 at 10:59 AM, Mike Holmes > wrote: > > > > > > > > > > > On 4 August 2016 at 11:47, Bill Fischofer

Re: [lng-odp] [PATCH 1/6] linux-generic: internal odp_cpu_pause()

On 08/04 13:39:43, Christophe Milard wrote: > Hi, > I have problems applying these patches: > ... anyone has tried? > Can you grab them from the list and apply them, Brian? I see the same issue.. Will investigate and respin. Thanks for pointing it out.

Re: [lng-odp] [PATCH] test:linux-generic: run odp_scheduling in process mode

On 08/04 11:01:09, Bill Fischofer wrote: > On Thu, Aug 4, 2016 at 10:59 AM, Mike Holmes wrote: > > > > > > > On 4 August 2016 at 11:47, Bill Fischofer > > wrote: > > > >> > >> On Thu, Aug 4, 2016 at 10:36 AM, Mike Holmes

Re: [lng-odp] [PATCH] test:linux-generic: run odp_scheduling in process mode

On 08/04/16 18:26, Brian Brooks wrote: Reviewed-by: Brian Brooks On 08/04 09:18:14, Mike Holmes wrote: +ret=0 + +run() +{ + echo odp_scheduling_run_proc starts with $1 worker threads + echo = + +

Re: [lng-odp] [PATCH] test:linux-generic: run odp_scheduling in process mode

On Thu, Aug 4, 2016 at 10:59 AM, Mike Holmes wrote: > > > On 4 August 2016 at 11:47, Bill Fischofer > wrote: > >> >> On Thu, Aug 4, 2016 at 10:36 AM, Mike Holmes >> wrote: >> >>> On my vanilla x86 I don't get any

Re: [lng-odp] [PATCH] test:linux-generic: run odp_scheduling in process mode

On Thu, Aug 4, 2016 at 11:03 AM, Maxim Uvarov wrote: > On 08/04/16 18:26, Brian Brooks wrote: > >> Reviewed-by: Brian Brooks >> >> On 08/04 09:18:14, Mike Holmes wrote: >> >>> +ret=0 >>> + >>> +run() >>> +{ >>> + echo

Re: [lng-odp] [PATCH] test:linux-generic: run odp_scheduling in process mode

On 4 August 2016 at 11:47, Bill Fischofer wrote: > > On Thu, Aug 4, 2016 at 10:36 AM, Mike Holmes > wrote: > >> On my vanilla x86 I don't get any issues, keen to get this in and have >> CI run it on lots of HW to see what happens, many of the

Re: [lng-odp] [PATCH] test:linux-generic: run odp_scheduling in process mode

Quick update. I can repro this in v1.10.0.1 as well, however v1.10.0.0 seems good. On Thu, Aug 4, 2016 at 10:47 AM, Bill Fischofer wrote: > > On Thu, Aug 4, 2016 at 10:36 AM, Mike Holmes > wrote: > >> On my vanilla x86 I don't get any issues,

Re: [lng-odp] [PATCH] test:linux-generic: run odp_scheduling in process mode

On Thu, Aug 4, 2016 at 10:36 AM, Mike Holmes wrote: > On my vanilla x86 I don't get any issues, keen to get this in and have CI > run it on lots of HW to see what happens, many of the other tests > completely fail in process mode so we will expose a lot as we add them I

Re: [lng-odp] [PATCH] test:linux-generic: run odp_scheduling in process mode

On my vanilla x86 I don't get any issues, keen to get this in and have CI run it on lots of HW to see what happens, many of the other tests completely fail in process mode so we will expose a lot as we add them I think. On 4 August 2016 at 11:33, Bill Fischofer wrote:

Re: [lng-odp] [PATCH] test:linux-generic: run odp_scheduling in process mode

On Thu, Aug 4, 2016 at 10:26 AM, Brian Brooks wrote: > Reviewed-by: Brian Brooks > > On 08/04 09:18:14, Mike Holmes wrote: > > +ret=0 > > + > > +run() > > +{ > > + echo odp_scheduling_run_proc starts with $1 worker threads > > + echo

Re: [lng-odp] [PATCH] validation: tm: use strncmp() to avoid potential string overrun

On 3 August 2016 at 17:06, Bill Fischofer wrote: > Resolve Bug https://bugs.linaro.org/show_bug.cgi?id=2426 by switching from > strcmp() to strncmp() > > Signed-off-by: Bill Fischofer > Reviewd-by: Mike Holmes This

Re: [lng-odp] [PATCH] test:linux-generic: run odp_scheduling in process mode

Reviewed-by: Brian Brooks On 08/04 09:18:14, Mike Holmes wrote: > +ret=0 > + > +run() > +{ > + echo odp_scheduling_run_proc starts with $1 worker threads > + echo = > + > +

Re: [lng-odp] [PATCH] doc/implementers add internal prefix recommendation

On 4 August 2016 at 10:11, Christophe Milard wrote: > On 4 August 2016 at 16:08, Mike Holmes wrote: > > Promote coding style that reduces the chance of collisions with > > applications. > > > > Signed-off-by: Mike Holmes

Re: [lng-odp] [PATCH] doc/implementers add internal prefix recommendation

On 4 August 2016 at 16:08, Mike Holmes wrote: > Promote coding style that reduces the chance of collisions with > applications. > > Signed-off-by: Mike Holmes > --- > doc/implementers-guide/implementers-guide.adoc | 7 +++ > 1 file changed, 7

[lng-odp] [PATCH] doc/implementers add internal prefix recommendation

Promote coding style that reduces the chance of collisions with applications. Signed-off-by: Mike Holmes --- doc/implementers-guide/implementers-guide.adoc | 7 +++ 1 file changed, 7 insertions(+) diff --git a/doc/implementers-guide/implementers-guide.adoc

Re: [lng-odp] [API-NEXT PATCH] linux-gen: drv: byteorder: fixed macro typo

On 4 August 2016 at 04:51, Christophe Milard wrote: > Signed-off-by: Christophe Milard > Reviewed-by: Mike Holmes > --- > platform/linux-generic/include/odp/drv/plat/byteorder_types.h | 2 +- > 1 file

Re: [lng-odp] [API-NEXT PATCH] test: drv: atomic renamed to drvatomic

On 4 August 2016 at 04:58, Christophe Milard wrote: > At installation time (make install) all tests executables are copied > into a single directory (lib/odp/tests). > Having two modules with identical names on the two interfaces (api and drv) > leads to the same

[lng-odp] [PATCH] test:linux-generic: run odp_scheduling in process mode

Set up the environment to allow calling the performance tests in process mode as part of make check when enabled. To run the tests use --enable-test-perf-proc Initial patch using odp_scheduling as a proof Signed-off-by: Mike Holmes --- configure.ac

[lng-odp] [Bug 2414] api/spec/crypto.h contains todo items

https://bugs.linaro.org/show_bug.cgi?id=2414 Mike Holmes changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED

[lng-odp] [Bug 2424] CID 164655: Security best practices violations pktio/ipc.c:

https://bugs.linaro.org/show_bug.cgi?id=2424 Mike Holmes changed: What|Removed |Added Resolution|--- |FIXED

[lng-odp] [Bug 2435] Traffic manager example includes internal files

https://bugs.linaro.org/show_bug.cgi?id=2435 Mike Holmes changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED

[lng-odp] [Bug 2453] PRIu64 is causing problems for odp-dpdk

https://bugs.linaro.org/show_bug.cgi?id=2453 Mike Holmes changed: What|Removed |Added Ever confirmed|0 |1

Re: [lng-odp] [PATCH 1/6] linux-generic: internal odp_cpu_pause()

Hi, I have problems applying these patches: ... anyone has tried? Can you grab them from the list and apply them, Brian? Christophe. git am ~/incoming/PATCH_1-6_linux-generic_internal_odp_cpu_pause_.mbox Applying: linux-generic: internal odp_cpu_pause() fatal: corrupt patch at line 33 Patch

Re: [lng-odp] [PATCH] linux-gen: doc: defining the ODP thread

On 08/04/16 12:02, Christophe Milard wrote: On 4 August 2016 at 08:40, Maxim Uvarov wrote: I'm not sure that: platform/linux-generic/include/odp/api/platform_specific.dox directory is good for documentation files. Do we want to create a directory for a single file

Re: [lng-odp] [PATCH] linux-gen: doc: defining the ODP thread

On 4 August 2016 at 08:40, Maxim Uvarov wrote: > I'm not sure that: > > platform/linux-generic/include/odp/api/platform_specific.dox > directory is good for documentation files. Do we want to create a directory for a single file when the need for other files is not

[lng-odp] [API-NEXT PATCH] test: drv: atomic renamed to drvatomic

At installation time (make install) all tests executables are copied into a single directory (lib/odp/tests). Having two modules with identical names on the two interfaces (api and drv) leads to the same test executable name ('atomic_main' in this case). As a consequence one of the test overwrites

[lng-odp] [API-NEXT PATCH] linux-gen: drv: byteorder: fixed macro typo

Signed-off-by: Christophe Milard --- platform/linux-generic/include/odp/drv/plat/byteorder_types.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/platform/linux-generic/include/odp/drv/plat/byteorder_types.h

Re: [lng-odp] [PATCH] linux-gen: doc: defining the ODP thread

I'm not sure that: platform/linux-generic/include/odp/api/platform_specific.dox directory is good for documentation files. I do not see also corresponding changes in Makefile like EXTRA_DIST Mike, can you please also review. Doxygen looks like your field :) Thank you, Maxim. On 08/03/16

Re: [lng-odp] [PATCHv3] test: update in readme file

Merged, Maxim. On 08/03/16 22:27, Bill Fischofer wrote: On Fri, Jul 22, 2016 at 7:51 AM, Christophe Milard < christophe.mil...@linaro.org> wrote: mostly updating paths following new test structure Signed-off-by: Christophe Milard Reviewed-by: Bill Fischofer

Re: [lng-odp] [PATCH] helper/hashtable: use static to hide private functions

On 08/03/16 22:21, Anders Roxell wrote: On 2 August 2016 at 17:27, Mike Holmes wrote: On 2 August 2016 at 04:44, Maxim Uvarov wrote: On 08/02/16 10:54, Anders Roxell wrote: Signed-off-by: Anders Roxell ---