On 25 January 2017 at 06:34, Honnappa Nagarahalli <
honnappa.nagaraha...@linaro.org> wrote:
> On 24 January 2017 at 19:16, Bill Fischofer
> wrote:
> > On Tue, Jan 24, 2017 at 8:30 AM, Nikhil Agarwal
> wrote:
> >>
> >>
> >> -Original Message-
> >> From: lng-odp [mailto:lng-odp-boun...@lis
On Wed, Jan 25, 2017 at 12:57 AM, Maxim Uvarov wrote:
>
>
> On 25 January 2017 at 04:46, Bill Fischofer
> wrote:
>>
>> The ODP_STATIC_ASSERT() macro expands to _Static_assert(), however when
>> used in C++ programs this needs to expand to static_assert().
>>
>> This resolves Bug https://bugs.lina
On 01/25/17 15:29, Bill Fischofer wrote:
> On Wed, Jan 25, 2017 at 12:57 AM, Maxim Uvarov
> wrote:
>>
>>
>> On 25 January 2017 at 04:46, Bill Fischofer
>> wrote:
>>>
>>> The ODP_STATIC_ASSERT() macro expands to _Static_assert(), however when
>>> used in C++ programs this needs to expand to stati
On Wed, Jan 25, 2017 at 4:22 AM, Ola Liljedahl wrote:
>
>
> On 24 January 2017 at 15:30, Nikhil Agarwal wrote:
>>
>>
>>
>> -Original Message-
>> From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of Bill
>> Fischofer
>> Sent: Tuesday, January 24, 2017 1:15 AM
>> To: Nikhil
On 25 January 2017 at 13:39, Bill Fischofer
wrote:
> On Wed, Jan 25, 2017 at 4:22 AM, Ola Liljedahl
> wrote:
> >
> >
> > On 24 January 2017 at 15:30, Nikhil Agarwal
> wrote:
> >>
> >>
> >>
> >> -Original Message-
> >> From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of
https://bugs.linaro.org/show_bug.cgi?id=2856
Bug ID: 2856
Summary: CID 175038: Memory - corruptions: odp_bench_packet.c
Product: OpenDataPlane - linux- generic reference
Version: v1.13.0.0
Hardware: Other
OS: Linux
On Wed, Jan 25, 2017 at 6:58 AM, Ola Liljedahl wrote:
>
>
> On 25 January 2017 at 13:39, Bill Fischofer
> wrote:
>>
>> On Wed, Jan 25, 2017 at 4:22 AM, Ola Liljedahl
>> wrote:
>> >
>> >
>> > On 24 January 2017 at 15:30, Nikhil Agarwal
>> > wrote:
>> >>
>> >>
>> >>
>> >> -Original Message---
On 23 January 2017 at 20:46, Mike Holmes wrote:
> Adding the previously missing table functions to the public helper api
> allows the tests to use just odph_api.h
>
> Signed-off-by: Mike Holmes
> ---
> helper/Makefile.am | 10 +-
> helper/cuckootable.c
Merged,
Maxim.
On 01/25/17 05:28, Yi He wrote:
> Hi, Christophe and team
>
> Sorry for not running distcheck while reviewing, I compared the v11 and
> v10 and looks good to me, ran make check, doxygen-run and distcheck
> passed, for this series:
>
> Reviewed-and-tested-by: Yi He mailto:yi...@lin
Yes, it should be < > I think
>From stackoverflow
For #include "filename" the preprocessor searches in the same
directory as the file containing the directive. This method is
normally used to include programmer-defined header files.
For #include the preprocessor searches in an implementation
dep
On 24 January 2017 at 16:51, Mike Holmes wrote:
> On 24 January 2017 at 03:23, Savolainen, Petri (Nokia - FI/Espoo)
> wrote:
>>
>>
>>> -Original Message-
>>> From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of Mike
>>> Holmes
>>> Sent: Monday, January 23, 2017 9:46 PM
>>>
On 25 January 2017 at 15:17, Mike Holmes wrote:
> Yes, it should be < > I think
>
> From stackoverflow
> For #include "filename" the preprocessor searches in the same
> directory as the file containing the directive. This method is
> normally used to include programmer-defined header files.
>
> Fo
Add an example application implementing lock-free IPv4 fragmentation
and reassembly functionality using ODP's packet "concat" and "split".
Signed-off-by: Joe Savage
---
(This code contribution is provided under the terms of agreement LES-LTM-21309)
example/Makefile.am |
For the series:
Reviewed-by: Christophe Milard
On 23 January 2017 at 20:46, Mike Holmes wrote:
> Greatly reduce the proliferation of helper includes that every app needs
> Make the public helper API very obvious
> Fix recent inclusion of table APIs that were not in the helper include dir and
>
https://bugs.linaro.org/show_bug.cgi?id=2856
--- Comment #1 from Bill Fischofer ---
I've already marked this as a false positive in Coverity.
--
You are receiving this mail because:
You are on the CC list for the bug.
this patch is merged.
issue bellow (which I saw) is related to not enough disk space for
memory mapped file. I will create separate bug for that to list
it for history.
Maxim.
On 01/24/17 10:25, Christophe Milard wrote:
> Hi Maxim.
>
> I cannot reproduce that, and your trace seems to indicate
Merged,
Maxim.
On 01/25/17 05:33, Bill Fischofer wrote:
> On Mon, Jan 23, 2017 at 2:25 AM, Christophe Milard
> wrote:
>> Hence fixing CID 174663
>> (Fixes https://bugs.linaro.org/show_bug.cgi?id=2827)
>>
>> Signed-off-by: Christophe Milard
>
> Reviewed-by: Bill Fischofer
>
>> ---
>>
>> since
after first patch code does not compile:
make[1]: Entering directory `/opt/Linaro/odp3.git/helper/test'
CC chksum.o
In file included from chksum.c:8:
In file included from ../../include/odp_api.h:38:
In file included from
../../platform/linux-generic/include/odp/api/buffer.h:21:
../../platf
I also think this cleanup is a step in the right direction. If the
helpers are to be an adjunct ODP package that can be distributed
alongside ODP then this is what's needed. Otherwise they are just a
disjoint set of unrelated individual files that we should not try to
package at all. But that would
Relevant to ODP community CC'ed
On 25 January 2017 at 11:14, Sorin Vultureanu wrote:
> Hi,
>
>
>
> It looks like your issue is with ODP API
>
>
>
> IMO odp_schedule_multi() should look like this:
>
> odp_schedule_multi() should always return num if wait = ODP_SCHED_WAIT
>
> And 0 ... num if wait
Merged,
Maxim.
On 01/25/17 18:59, Bill Fischofer wrote:
> I also think this cleanup is a step in the right direction. If the
> helpers are to be an adjunct ODP package that can be distributed
> alongside ODP then this is what's needed. Otherwise they are just a
> disjoint set of unrelated individu
Merged,
Maxim.
On 01/24/17 13:11, Matias Elo wrote:
> Add new test application for ordered queue functionality and performance
> validation. The application sets sequence numbers to incoming packets using
> ordered pktin queues and ordered context locks. After being tagged packets
> are enqueued t
merged,
Maxim.
On 01/24/17 03:55, Bill Fischofer wrote:
> On Mon, Jan 23, 2017 at 9:38 AM, Christophe Milard
> wrote:
>> _ishm prereserves address space for _ODP_ISHM_SINGLE_VA allocated memory
>> by reserving unreachable "memory", using PROT_NONE, hence really allocating
>> virtual space (as the
Petri, can you please review/test this patch?
Maxim.
On 01/24/17 17:05, Bill Fischofer wrote:
> Ping. This still needs a review.
>
> On Sat, Jan 14, 2017 at 12:24 PM, Bill Fischofer
> wrote:
>> As reported in Bug https://bugs.linaro.org/show_bug.cgi?id=2816 packet
>> alloc/free performance for
ping, please review.
Maxim.
On 01/19/17 17:34, Maxim Uvarov wrote:
> Core 0 might be not available and app should
> ask for available core before pinning to it.
> https://bugs.linaro.org/show_bug.cgi?id=2806
>
> Signed-off-by: Maxim Uvarov
> ---
> example/hello/odp_hello.c | 15 ++-
quick review for that bellow.
It will be very helpful if rehe was some README with description about
this app, run environments and some output. So people can learn
something before looking to code.
On 01/25/17 17:26, Joe Savage wrote:
> Add an example application implementing lock-free IPv4 fra
https://bugs.linaro.org/show_bug.cgi?id=2857
Bug ID: 2857
Summary: Bus error on not enough hdd space (Ubuntu VM, aarch64)
Product: OpenDataPlane - linux- generic reference
Version: master
Hardware: Other
OS: Linux
S
https://bugs.linaro.org/show_bug.cgi?id=2857
Bill Fischofer changed:
What|Removed |Added
CC||bill.fischo...@linaro.org
--- Comment #1 from
On Wed, Jan 25, 2017 at 10:16 AM, Mike Holmes wrote:
> Relevant to ODP community CC'ed
>
> On 25 January 2017 at 11:14, Sorin Vultureanu
> wrote:
>> Hi,
>>
>>
>>
>> It looks like your issue is with ODP API
>>
>>
>>
>> IMO odp_schedule_multi() should look like this:
>>
>> odp_schedule_multi() sho
I agree with all of Maxim's comments. In addition, attempting to
compile with clang gives these errors:
Making all in fragreass
make[2]: Entering directory '/home/bill/linaro/review/example/fragreass'
CC odp_fragreass-odp_fragreass.o
In file included from odp_fragreass.c:21:
In file includ
On Wed, Jan 25, 2017 at 2:03 PM, Bill Fischofer
wrote:
> I agree with all of Maxim's comments. In addition, attempting to
> compile with clang gives these errors:
>
> Making all in fragreass
> make[2]: Entering directory '/home/bill/linaro/review/example/fragreass'
> CC odp_fragreass-odp_f
Additional review comments based on testing:
On Wed, Jan 25, 2017 at 8:26 AM, Joe Savage wrote:
> Add an example application implementing lock-free IPv4 fragmentation
> and reassembly functionality using ODP's packet "concat" and "split".
>
> Signed-off-by: Joe Savage
> ---
> (This code contribu
Hi,
I hold an Indian passport and live in US. I need to
get a visa for BUD17. If you are in a similar situation and know the
procedure, can you please email me the details?
Thank you,
Honnappa
I agree, it needs additional operations. One could combine multiple
atomic operations into a single stage where possible. If the scheduler
is implemented in hardware, impact will be less.
The other option is for the reordering logic to call per packet
functions which run the atomic stage.
On 25 J
it's better to discuss such things on lng-internal@
On 26 January 2017 at 07:50, Honnappa Nagarahalli <
honnappa.nagaraha...@linaro.org> wrote:
> Hi,
>
> I hold an Indian passport and live in US. I need to
> get a visa for BUD17. If you are in a similar situation and know the
> pr
35 matches
Mail list logo