Re: [lng-odp] [PATCH] doc: helper: add missing doxygen for helper table functions

just: ./configure make doxygen-doc On 8 February 2017 at 01:36, Bill Fischofer wrote: > How are you generating this? When I run make doxygen-doc it's > completely clean. Is this another doxygen version issue? > > There is a small typo in one of the files so I'll send

[lng-odp] [API-NEXT PATCHv4 3/4] validation/example: call odp_timer_capability() before creating a timer pool

Use odp_timer_capability() to determine the max timer resolution Signed-off-by: Kevin Wang --- example/generator/odp_generator.c | 8 +++- example/timer/odp_timer_simple.c | 9 - example/timer/odp_timer_test.c| 7

[lng-odp] [API-NEXT PATCHv4 2/4] linux-generic: timer: implement odp_timer_capability()

Implement a new internal function timer_res_init() to detect the max timer resolution without overrun at the ODP init stage. It will check timer resolution from 1ms to 100us, 10us...1ns until the timer is overrun. Signed-off-by: Kevin Wang ---

[lng-odp] [API-NEXT PATCHv4 1/4] api: timer: add odp_timer_capability() api

Currently, user needs to decide the timer resolution before creating a timer pool. But sometimes it will cause timer overrun as the system can't support such high resolution. So a new API is required to expose the timer capability to the user. Signed-off-by: Kevin Wang ---

[lng-odp] [API-NEXT PATCHv4 0/4] a new API to support timer capability

*** BLURB HERE *** Kevin Wang (4): api: timer: add odp_timer_capability() api linux-generic: timer: implement odp_timer_capability() validation/example: call odp_timer_capability() before creating a timer pool doc: userguide: add odp_timer_capability() section to user guide

Re: [lng-odp] [PATCHv4] linux-generic: debug: enable helper use from c++ programs

I've done a fair amount of experimentation with using variants of Brian's suggested macros. This works for C but for C++ it results in an error message saying that it can't do relocation and to please compile with -fPIC, which we've already determined is an unacceptable requirement for ODP

[lng-odp] [PATCHv2] doc: helper: add missing doxygen for helper table functions

Resolve Bug https://bugs.linaro.org/show_bug.cgi?id=2865 by adding missing doxygen documentation for helper table functions Signed-off-by: Bill Fischofer --- Changes for v2: - Remove extraneous char in odph_cuckootable.h helper/include/odp/helper/odph_cuckootable.h

Re: [lng-odp] [PATCH] doc: helper: add missing doxygen for helper table functions

How are you generating this? When I run make doxygen-doc it's completely clean. Is this another doxygen version issue? There is a small typo in one of the files so I'll send a v2 to correct that. On Tue, Feb 7, 2017 at 9:43 AM, Maxim Uvarov wrote: > Bill, > > patch is

Re: [lng-odp] [PATCH v2 1/3] linux-generic: crypto: add missing include

Good catch. For Part 1: Reviewed-by: Bill Fischofer But see comments for Part 2. Not clear that part is needed. On Tue, Feb 7, 2017 at 12:06 PM, Dmitry Eremin-Solenikov wrote: > OpenSSL 1.1.0 headers do not include , so include it

Re: [lng-odp] [PATCH v2 2/3] linux-generic: crypto: move OpenSSL locks out of global crypto data

On Tue, Feb 7, 2017 at 12:06 PM, Dmitry Eremin-Solenikov wrote: > In preparation to update crypto code for OpenSSL 1.1.0 move locks out of > global data. > > Signed-off-by: Dmitry Eremin-Solenikov > --- >

Re: [lng-odp] [PATCH] linux-generic: crypto: support OpenSSL 1.1.0

On 02/07/17 20:52, Dmitry Eremin-Solenikov wrote: > On 07.02.2017 18:59, Maxim Uvarov wrote: >> On 02/07/17 12:21, Dmitry Eremin-Solenikov wrote: >>> Hello, >>> >>> On 7 February 2017 at 10:14, Maxim Uvarov >>> wrote: What is function is not used error? Is it gcc or

Re: [lng-odp] [PATCH] linux-generic: crypto: support OpenSSL 1.1.0

On 07.02.2017 18:59, Maxim Uvarov wrote: On 02/07/17 12:21, Dmitry Eremin-Solenikov wrote: Hello, On 7 February 2017 at 10:14, Maxim Uvarov wrote: What is function is not used error? Is it gcc or #error in includes? First error: In file included from

[lng-odp] [PATCH v2 1/3] linux-generic: crypto: add missing include

OpenSSL 1.1.0 headers do not include , so include it manually to fix the following error: In file included from ./include/odp_packet_internal.h:28:0, from odp_classification.c:13: ./include/odp_crypto_internal.h:55:5: error: unknown type name ‘EVP_CIPHER_CTX’ EVP_CIPHER_CTX

[lng-odp] [PATCH v2 2/3] linux-generic: crypto: move OpenSSL locks out of global crypto data

In preparation to update crypto code for OpenSSL 1.1.0 move locks out of global data. Signed-off-by: Dmitry Eremin-Solenikov --- platform/linux-generic/odp_crypto.c | 67 ++--- 1 file changed, 47 insertions(+), 20 deletions(-)

[lng-odp] [PATCH v2 3/3] linux-generic: crypto: support OpenSSL 1.1.0

OpenSSL 1.1.0 uses new threading API. It is no longer necessary to set locking callbacks to use OpenSSL in a multi-threaded environment. The old threading API should no longer be used. So don't allocate/set locking callbacks with new OpenSSL. Signed-off-by: Dmitry Eremin-Solenikov

Re: [lng-odp] [API-NEXT PATCH] linux-gen: fix odp_schedule.m4

Merged, Maxim. On 02/07/17 06:17, Bill Fischofer wrote: > On Mon, Feb 6, 2017 at 8:35 PM, Yi He wrote: >> Fixed configure script when enables schedule option >> schedule-iquery=yes or schedule-sp=yes: command not found >> >> Signed-off-by: Yi He > >

Re: [lng-odp] [API-NEXT PATCH] linux-gen: support older libconfig version

ping. On 01/27/17 00:11, Maxim Uvarov wrote: > Travis CI uses old libconfig8 amd64 1.3.2-2ubuntu2, > which does not have defines for errors. Move error print > under ifdef to fix compilation. > > Signed-off-by: Maxim Uvarov > --- > platform/linux-generic/odp_init.c | 7

Re: [lng-odp] [PATCH] linux-generic: crypto: support OpenSSL 1.1.0

On 02/07/17 12:21, Dmitry Eremin-Solenikov wrote: > Hello, > > On 7 February 2017 at 10:14, Maxim Uvarov wrote: >> What is function is not used error? Is it gcc or #error in includes? > > First error: > > In file included from ./include/odp_packet_internal.h:28:0, >

Re: [lng-odp] [PATCH] [RFC] API:update odp_schedle_multi to return events from multiple queues.

On 7 February 2017 at 14:22, Nikhil Agarwal wrote: > > > On 3 February 2017 at 19:20, Ola Liljedahl wrote: >> >> Do we have any performance comparison between using this new API >> compared to using the existing API and the SW behind >>

Re: [lng-odp] [PATCH] doc: helper: add missing doxygen for helper table functions

Bill, patch is good. Can you please add description for missing functions for v2: /opt/Linaro/odp3.git/helper/include/odp/helper/odph_cuckootable.h:136: warning: Member odph_cuckoo_table_ops (variable) of group odph_cuckootable is not documented.

Re: [lng-odp] [PATCHv4] linux-generic: debug: enable helper use from c++ programs

Given these issues with obsolete compiler levels, it may be simpler to go with Brian's suggestion and just use some simple macros. I'll post a v4 along those lines. On Tue, Feb 7, 2017 at 7:51 AM, Maxim Uvarov wrote: > On 02/07/17 16:39, Bill Fischofer wrote: >> The

Re: [lng-odp] [PATCHv3] codecov: add code coverage integrated to github

Merged, Maxim. On 02/07/17 16:52, Mike Holmes wrote: > > > On 7 February 2017 at 08:48, Maxim Uvarov > wrote: > > Results for code coverage will be available in https://codecov.io. > On each successful run in github automatic

Re: [lng-odp] [PATCH] [RFC] API:update odp_schedle_multi to return events from multiple queues.

On Tue, Feb 7, 2017 at 7:39 AM, Nikhil Agarwal wrote: > > > On 7 February 2017 at 18:58, Bill Fischofer > wrote: >> >> On Tue, Feb 7, 2017 at 7:22 AM, Nikhil Agarwal >> wrote: >> > On 3 February 2017 at 19:20, Ola

Re: [lng-odp] [PATCHv3] codecov: add code coverage integrated to github

On 7 February 2017 at 08:48, Maxim Uvarov wrote: > Results for code coverage will be available in https://codecov.io. > On each successful run in github automatic code coverage will > be run under travis ci. And at the end of travis log there will > be link to code

Re: [lng-odp] [PATCHv4] linux-generic: debug: enable helper use from c++ programs

On 02/07/17 16:39, Bill Fischofer wrote: > The errors being reported here are on unchanged code paths with an > older clang version (3.4.0 vs.4.2.1). Not sure why you'd see that here > and not in the unchanged code. > > Also, this run is reporting doxygen issues with the traffic manager > that I

[lng-odp] [PATCHv3] codecov: add code coverage integrated to github

Results for code coverage will be available in https://codecov.io. On each successful run in github automatic code coverage will be run under travis ci. And at the end of travis log there will be link to code coverage for specific commit which you push. Also github merge requests will post

Re: [lng-odp] [PATCH] [RFC] API:update odp_schedle_multi to return events from multiple queues.

On 7 February 2017 at 18:58, Bill Fischofer wrote: > On Tue, Feb 7, 2017 at 7:22 AM, Nikhil Agarwal > wrote: > > On 3 February 2017 at 19:20, Ola Liljedahl > wrote: > > > >> Do we have any performance comparison

Re: [lng-odp] [PATCHv4] linux-generic: debug: enable helper use from c++ programs

The errors being reported here are on unchanged code paths with an older clang version (3.4.0 vs.4.2.1). Not sure why you'd see that here and not in the unchanged code. Also, this run is reporting doxygen issues with the traffic manager that I don't see running locally: $ make doxygen-doc

Re: [lng-odp] [API-NEXT PATCH 1/4] api: timer: add odp_timer_capability() api

On 02/07/17 12:28, Kevin Wang wrote: > ​Hi Bill, Mike, > ​./scripts/checkpatch is already ok. > But those patches still can't be identified as a series. Not sure the > reason. I'll list my commit steps. > > 1. git format-patch origin/api-next -s --cover-letter > --subject-prefix="API-NEXT

Re: [lng-odp] [PATCHv4] linux-generic: debug: enable helper use from c++ programs

I pushed it to github and test failed: https://api.travis-ci.org/jobs/199201799/log.txt?deansi=true Maxim. On 02/07/17 05:51, Brian Brooks wrote: > On 02/06 13:14:17, Bill Fischofer wrote: >> Ping. Brian can you please verify that this now works on your system. >> It works on my Ubuntu 16.04

Re: [lng-odp] [PATCH] [RFC] API:update odp_schedle_multi to return events from multiple queues.

On Tue, Feb 7, 2017 at 7:22 AM, Nikhil Agarwal wrote: > On 3 February 2017 at 19:20, Ola Liljedahl wrote: > >> Do we have any performance comparison between using this new API >> compared to using the existing API and the SW behind >>

Re: [lng-odp] [PATCH] [RFC] API:update odp_schedle_multi to return events from multiple queues.

On 3 February 2017 at 19:20, Ola Liljedahl wrote: > Do we have any performance comparison between using this new API > compared to using the existing API and the SW behind > odp_schedule_multi() sorts the events (if necessary) and only returns > events for one queue at

Re: [lng-odp] [PATCH 04/10] test: l2fwd: add pktio driver print out

On Tue, Feb 7, 2017 at 2:03 AM, Savolainen, Petri (Nokia - FI/Espoo) wrote: > > >> -Original Message- >> From: Bill Fischofer [mailto:bill.fischo...@linaro.org] >> Sent: Tuesday, February 07, 2017 2:10 AM >> To: Petri Savolainen

Re: [lng-odp] [PATCH 03/10] linux-gen: packet: packet handle is hdr pointer

On Tue, Feb 7, 2017 at 1:50 AM, Savolainen, Petri (Nokia - FI/Espoo) wrote: >> -Original Message- >> From: Bill Fischofer [mailto:bill.fischo...@linaro.org] >> Sent: Tuesday, February 07, 2017 2:05 AM >> To: Petri Savolainen

Re: [lng-odp] [EXT] Re: ODP crypto support with HW offload

Hi Bala, See inline Thanks Dima -Original Message- From: Bala Manoharan [mailto:bala.manoha...@linaro.org] Sent: Tuesday, February 07, 2017 10:30 AM To: Dmitri Epshtein Cc: lng-odp-forward; Nir Erez Subject: Re: [lng-odp] [EXT] Re: ODP crypto support with HW offload Regards, Bala On

[lng-odp] [PATCHv3 1/1] test: generator: Updated global statistics calculation to provide useful/easy-to-parse information

Signed-off-by: Bogdan Pricope --- example/generator/odp_generator.c | 57 --- 1 file changed, 35 insertions(+), 22 deletions(-) diff --git a/example/generator/odp_generator.c b/example/generator/odp_generator.c index

Re: [lng-odp] [EXT] Re: ODP crypto support with HW offload

Hi Dmitri, Pls see inline.. Regards, Bala On 7 February 2017 at 16:46, Dmitri Epshtein wrote: > Hi Bala, > > See inline > > Thanks > Dima > > -Original Message- > From: Bala Manoharan [mailto:bala.manoha...@linaro.org] > Sent: Tuesday, February 07, 2017 10:30 AM >

Re: [lng-odp] drv API issue

Hi Christophe, Another issue may relate to driver interface. As you know, there is some soc level initialization specific to some platform before the network driver works. Where do you expect this kind of initialization? at the odp_init or driver_init? For dpaa2, the thread is also needed before

Re: [lng-odp] [API-NEXT PATCH 1/4] api: timer: add odp_timer_capability() api

​Hi Bill, Mike, ​./scripts/checkpatch is already ok. But those patches still can't be identified as a series. Not sure the reason. I'll list my commit steps. 1. git format-patch origin/api-next -s --cover-letter --subject-prefix="API-NEXT PATCHv3" Then there will be five new files are created. 2.

Re: [lng-odp] [PATCH] linux-generic: crypto: support OpenSSL 1.1.0

Hello, On 7 February 2017 at 10:14, Maxim Uvarov wrote: > What is function is not used error? Is it gcc or #error in includes? First error: In file included from ./include/odp_packet_internal.h:28:0, from odp_classification.c:13:

[lng-odp] [PATCHv2 1/1] test: generator: Updated global statistics calculation to provide useful/easy-to-parse information

Signed-off-by: Bogdan Pricope --- example/generator/odp_generator.c | 58 +++ 1 file changed, 35 insertions(+), 23 deletions(-) diff --git a/example/generator/odp_generator.c b/example/generator/odp_generator.c index

[lng-odp] [API-NEXT PATCHv3 4/4] doc: userguide: add odp_timer_capability() section to user guide

Signed-off-by: Kevin Wang --- doc/users-guide/users-guide-timer.adoc | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/doc/users-guide/users-guide-timer.adoc b/doc/users-guide/users-guide-timer.adoc index 9cd30de..ccca7d4 100644 ---

[lng-odp] [API-NEXT PATCHv3 3/4] validation/example: call odp_timer_capability() before creating a timer pool

Use odp_timer_capability() to determine the max timer resolution Signed-off-by: Kevin Wang --- example/generator/odp_generator.c | 8 +++- example/timer/odp_timer_simple.c | 9 - example/timer/odp_timer_test.c| 7

[lng-odp] [API-NEXT PATCHv3 2/4] linux-generic: timer: implement odp_timer_capability()

Implement a new internal function timer_res_init() to detect the max timer resolution without overrun at the ODP init stage. It will check timer resolution from 1ms to 100us, 10us...1ns until the timer is overrun. Signed-off-by: Kevin Wang ---

[lng-odp] [API-NEXT PATCHv3 1/4] api: timer: add odp_timer_capability() api

Currently, user needs to decide the timer resolution before creating a timer pool. But sometimes it will cause timer overrun as the system can't support such high resolution. So a new API is required to expose the timer capability to the user. Signed-off-by: Kevin Wang ---

[lng-odp] [API-NEXT PATCHv3 0/4] new API to support timer capability

*** BLURB HERE *** Kevin Wang (4): api: timer: add odp_timer_capability() api linux-generic: timer: implement odp_timer_capability() validation/example: call odp_timer_capability() before creating a timer pool doc: userguide: add odp_timer_capability() section to user guide

[lng-odp] [API-NEXT PATCHv3 0/4] new API to support timer capability

*** BLURB HERE *** Kevin Wang (4): api: timer: add odp_timer_capability() api linux-generic: timer: implement odp_timer_capability() validation/example: call odp_timer_capability() before creating a timer pool doc: userguide: add odp_timer_capability() section to user guide

[lng-odp] [PATCH 1/1] test: generator: Updated global stats calculation to provide useful/easy-to-parse information

Signed-off-by: Bogdan Pricope --- example/generator/odp_generator.c | 58 +++ 1 file changed, 35 insertions(+), 23 deletions(-) diff --git a/example/generator/odp_generator.c b/example/generator/odp_generator.c index

Re: [lng-odp] [EXT] Re: ODP crypto support with HW offload

Regards, Bala On 6 February 2017 at 18:08, Dmitri Epshtein wrote: > Hi, > > There are two issues in current odp_crypto APIs (file > $ODP_DIR/include/odp/api/spec/crypto.h) > > 1. No support batch/burst for crypto operations > 2. No support crypto results polling by

Re: [lng-odp] [PATCH 04/10] test: l2fwd: add pktio driver print out

> -Original Message- > From: Bill Fischofer [mailto:bill.fischo...@linaro.org] > Sent: Tuesday, February 07, 2017 2:10 AM > To: Petri Savolainen > Cc: lng-odp-forward > Subject: Re: [lng-odp] [PATCH 04/10] test: l2fwd: add pktio