Re: [lng-odp] [PATCH 4/4] linux-generic: crypto: switch to EVP interface for cipher algorithms

On 25.04.2017 04:41, Dmitry Eremin-Solenikov wrote: > Switch AES-CBC and 3DES-CBC to use generic (EVP) interface instad of low > level interface (as recommended by OpenSSL documentation). This allows > to use the same code path for all non-AEAD ciphers. The only AEAD cipher > (AES-GCM) already

Re: [lng-odp] [API-NEXT PATCH v4 0/8] A scalable software scheduler

Another issue with v4: make distcheck fails: make[2]: Entering directory '/home/bill/linaro/odp/opendataplane-1.14.0.0/_build/sub/platform/linux-generic' CC _fdserver.lo CC _ishm.lo In file included from ../../../../platform/linux-generic/_ishm.c:49:0:

[lng-odp] [Linaro/odp] de52bb: linux-generic: crypto: properly handle errors in p...

Branch: refs/heads/master Home: https://github.com/Linaro/odp Commit: de52bbc9058604745e443195fbd9f4504d700d8d https://github.com/Linaro/odp/commit/de52bbc9058604745e443195fbd9f4504d700d8d Author: Dmitry Eremin-Solenikov Date: 2017-04-26

Re: [lng-odp] [PATCH 0/4] crypto: rework implementation of encryption and auth code

For this series: Reviewed-and-tested-by: Bill Fischofer On Mon, Apr 24, 2017 at 8:41 PM, Dmitry Eremin-Solenikov < dmitry.ereminsoleni...@linaro.org> wrote: > This is a copy of patchset at https://github.com/Linaro/odp/pull/11 . > > The main goal of this patchset is

Re: [lng-odp] [API-NEXT PATCH 8/8] linux-gen: time: use hw time counter when available

On 04/26/17 12:40, Peltonen, Janne (Nokia - FI/Espoo) wrote: >>> odp_sched_latency currently uses clock_gettime. It is my understanding >>> that clock_gettime does not have the over head of the system call. Can >>> you elaborate more on the 'improved significantly' part? >>> >> >> clock_gettime()

Re: [lng-odp] [Linaro/odp] Zeroing packet data (#18)

On 04/26/17 17:27, Dmitry Eremin-Solenikov wrote: > On 26.04.2017 17:06, Codecov wrote: >> Impacted Files >> Coverage Δ >> test/common_plat/validation/api/packet/packet.c >>

Re: [lng-odp] [PATCH] linux-generic: rwlock: fix odp_rwlock_read_trylock()

On 26.04.2017 20:54, Peltonen, Janne (Nokia - FI/Espoo) wrote: > > That does not work. Since the value of cnt is not checked, the code > would happily take the lock even when a writer already has it. Nice catch. Updated to check for writers. -- With best wishes Dmitry

Re: [lng-odp] [PATCH] linux-generic: rwlock: fix odp_rwlock_read_trylock()

That does not work. Since the value of cnt is not checked, the code would happily take the lock even when a writer already has it. Janne > -Original Message- > From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of Github > ODP bot > Sent: Wednesday, April 26,

[lng-odp] [PATCH] linux-generic: rwlock: fix odp_rwlock_read_trylock()

From: Dmitry Eremin-Solenikov odp_rwlock_read_trylock() currently works only if there are no readers (and writers) as it compares counter with 0. Make it actually work in case there are other active readers. Fixes: https://bugs.linaro.org/show_bug.cgi?id=2974

[lng-odp] [Bug 2974] New: odp_rwlock_read_trylock() fails if lock is already held for read access

https://bugs.linaro.org/show_bug.cgi?id=2974 Bug ID: 2974 Summary: odp_rwlock_read_trylock() fails if lock is already held for read access Product: OpenDataPlane - linux- generic reference Version: v1.14.0.0 Hardware:

[lng-odp] [Bug 2942] Compilation fails using clang 4.0.0

https://bugs.linaro.org/show_bug.cgi?id=2942 Bill Fischofer changed: What|Removed |Added Status|IN_PROGRESS |RESOLVED

Re: [lng-odp] [API-NEXT PATCH 2/8] linux-gen: cpu_flags: added x86 cpu flag read functions

On 04/24 07:21:09, Savolainen, Petri (Nokia - FI/Espoo) wrote: > > > > -Original Message- > > From: Brian Brooks [mailto:brian.bro...@arm.com] > > Sent: Friday, April 21, 2017 7:51 PM > > To: Petri Savolainen > > Cc: lng-odp@lists.linaro.org > > Subject: Re:

Re: [lng-odp] [API-NEXT PATCH 8/8] linux-gen: time: use hw time counter when available

On 04/26 08:02:09, Savolainen, Petri (Nokia - FI/Espoo) wrote: > > > > > > > diff --git a/platform/linux- > > generic/include/odp/api/plat/time_types.h > > > > b/platform/linux-generic/include/odp/api/plat/time_types.h > > > > > index 4847f3b1..8ae7ce82 100644 > > > > > ---

Re: [lng-odp] [API-NEXT PATCH 8/8] linux-gen: time: use hw time counter when available

On 04/26 07:30:15, Savolainen, Petri (Nokia - FI/Espoo) wrote: > > > > > This function (cpu_global_time()) is called only when we have first > > checked that TSC is invariant. Also we measure the TSC frequency in that > > case. This function is defined in the same file as cpu_cycles(), and the >

Re: [lng-odp] [API-NEXT PATCH 8/8] linux-gen: time: use hw time counter when available

On 04/26 07:11:57, Savolainen, Petri (Nokia - FI/Espoo) wrote: > > > > > From coverletter: > > > "This patch set modifies time implementation to use TSC when running on > > a x86 > > > CPU that has invarint TSC CPU flag set. Otherwise, the same Linux system > > time > > > is used as before. TSC

Re: [lng-odp] [Linaro/odp] Zeroing packet data (#18)

On Wed, Apr 26, 2017 at 9:27 AM, Dmitry Eremin-Solenikov < dmitry.ereminsoleni...@linaro.org> wrote: > On 26.04.2017 17:06, Codecov wrote: > > Impacted Files > > Coverage Δ > > test/common_plat/validation/api/packet/packet.c > >

Re: [lng-odp] [Linaro/odp] Zeroing packet data (#18)

On 26.04.2017 17:06, Codecov wrote: > Impacted Files > Coverage Δ > test/common_plat/validation/api/packet/packet.c >

Re: [lng-odp] [Linaro/odp] Zeroing packet data (#18)

Maxim, On 26.04.2017 17:02, muvarov wrote: > From: Github ODP bot > From: Dmitry Eremin-Solenikov > > Check that odp_packet_zero_data() works with single-segment packets and > with segmented packets. > > Signed-off-by: Dmitry Eremin-Solenikov Can we somehow prevent these e-mails from

Re: [lng-odp] [API-NEXT PATCH v3 8/8] Add scalable scheduler

Yes, you are right. You need the dictionary, it throws up that warning if you do not have the dictionary. Which script checks for the dependencies? -Original Message- From: Brian Brooks [mailto:brian.bro...@arm.com] Sent: Wednesday, April 19, 2017 2:38 AM To: Bill Fischofer

[lng-odp] [PATCH 3/3] validation: packet: add tests for odp_packet_zero_data()

From: Dmitry Eremin-Solenikov Check that odp_packet_zero_data() works with single-segment packets and with segmented packets. Signed-off-by: Dmitry Eremin-Solenikov --- /** Email created from pull request 18

[lng-odp] [PATCH 2/3] linux-generic: packet: implement odp_packet_zero_data()

From: Dmitry Eremin-Solenikov Signed-off-by: Dmitry Eremin-Solenikov --- /** Email created from pull request 18 (lumag:packet-zero) ** https://github.com/Linaro/odp/pull/18 ** Patch:

Re: [lng-odp] [API-NEXT PATCH v4 3/8] pktio: loop: use handle instead of pointer to buffer

> On 19 Apr 2017, at 10:14, Brian Brooks wrote: > > Signed-off-by: Kevin Wang > --- > platform/linux-generic/pktio/loop.c | 11 +-- > 1 file changed, 9 insertions(+), 2 deletions(-) > > diff --git a/platform/linux-generic/pktio/loop.c >

Re: [lng-odp] [API-NEXT PATCH v4 3/8] pktio: loop: use handle instead of pointer to buffer

On Wed, Apr 19, 2017 at 2:14 AM, Brian Brooks wrote: > Signed-off-by: Kevin Wang > --- > platform/linux-generic/pktio/loop.c | 11 +-- > 1 file changed, 9 insertions(+), 2 deletions(-) > > diff --git a/platform/linux-generic/pktio/loop.c

Re: [lng-odp] [API-NEXT PATCH] api: packet: introduce odp_packet_data_range_t

-Original Message- From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of Dmitry Eremin-Solenikov Sent: 25 April 2017 22:01 To: lng-odp@lists.linaro.org Subject: [lng-odp] [API-NEXT PATCH] api: packet: introduce odp_packet_data_range_t Rename odp_crypto_data_range_t to

Re: [lng-odp] [API-NEXT PATCH 8/8] linux-gen: time: use hw time counter when available

> > odp_sched_latency currently uses clock_gettime. It is my understanding > > that clock_gettime does not have the over head of the system call. Can > > you elaborate more on the 'improved significantly' part? > > > > clock_gettime() uses the same TSC, but when you profile it with perf you can

Re: [lng-odp] [API-NEXT PATCH 8/8] linux-gen: time: use hw time counter when available

> > +#define SEC_IN_NS 10ULL > > + > > +/* Measure TSC frequency. Frequency information registers are defined > for x86, > > + * but those are often not enumerated. */ > > +uint64_t cpu_global_time_freq(void) > > +{ > > + struct timespec sleep, ts1, ts2; > > + uint64_t t1, t2,

[lng-odp] [PATCH 2/2] test: pktio_run: exit if binary was not found

From: Maxim Uvarov No need to continue run if binary was not found in paths. Signed-off-by: Maxim Uvarov --- /** Email created from pull request 17 (muvarov:master_bug2969) ** https://github.com/Linaro/odp/pull/17 ** Patch:

[lng-odp] [PATCH 1/2] test: tm: add paths to find tm binary

From: Maxim Uvarov Use the same algorithm as pktio_run.sh to find paths in different cases (in tree build, out of tree build, distcheck and etc). Fixes: https://bugs.linaro.org/show_bug.cgi?id=2969 Signed-off-by: Maxim Uvarov --- /** Email

[lng-odp] [PATCH 23/23] test: drv: test for setting and retrieving driver's data

From: Christophe Milard trivial tests for function odpdrv_device_set_data() and odpdrv_device_get_data(). Signed-off-by: Christophe Milard --- /** Email created from pull request 16 (heyi-linaro:driver-framework) **

Re: [lng-odp] [API-NEXT PATCH 8/8] linux-gen: time: use hw time counter when available

> > > > diff --git a/platform/linux- > generic/include/odp/api/plat/time_types.h > > > b/platform/linux-generic/include/odp/api/plat/time_types.h > > > > index 4847f3b1..8ae7ce82 100644 > > > > --- a/platform/linux-generic/include/odp/api/plat/time_types.h > > > > +++

[lng-odp] [PATCH 22/23] linux-gen: adding functions to attach driver's data to the device

From: Christophe Milard Implementation of the functions to set/retrieve driver's data to/from a bound device. Signed-off-by: Christophe Milard --- /** Email created from pull request 16 (heyi-linaro:driver-framework) **

[lng-odp] [PATCH 21/23] drv: driver: adding functions to attach driver's data to the device

From: Christophe Milard Driver will need to attach their data to devices when bound. The patch introduce a data setter and a data getter function to do so. Signed-off-by: Christophe Milard --- /** Email created from pull request 16

[lng-odp] [PATCH 20/23] test: drv: driver registration and probing

From: Christophe Milard Register driver, devios, enumerators, create devices, and check that probing occurs correctely. Signed-off-by: Christophe Milard --- /** Email created from pull request 16 (heyi-linaro:driver-framework) **

[lng-odp] [PATCH 19/23] linux-gen: driver registration and probing

From: Christophe Milard Driver registration and probing is implemented for linux-gen ODP. Signed-off-by: Christophe Milard --- /** Email created from pull request 16 (heyi-linaro:driver-framework) **

[lng-odp] [PATCH 18/23] drv: complement parameters to the driver probe() function

From: Christophe Milard Of course, when probing a driver, the latter should be given the devio handle to be used. This is what this patch adds. It also adds the index of the devio, hence telling the driver which of the possible ODPDRV_MAX_DEVIOS devios was selected,

[lng-odp] [PATCH 17/23] drv: adding driver remove function

From: Christophe Milard The remove function, as for other driver items (such as enumerators...) is called before the driver is to be removed, i.e. after all devices have been been unbound from the driver. remove() should release any resource held by the driver.

[lng-odp] [PATCH 16/23] test: drv: devio creation and destruction

From: Christophe Milard Testing that devios can be registered and removed in/from ODP. Signed-off-by: Christophe Milard --- /** Email created from pull request 16 (heyi-linaro:driver-framework) **

[lng-odp] [PATCH 13/23] test: drv: device creation and destruction

From: Christophe Milard Testing that devices can be created and removed from ODP. Signed-off-by: Christophe Milard --- /** Email created from pull request 16 (heyi-linaro:driver-framework) ** https://github.com/Linaro/odp/pull/16 **

[lng-odp] [PATCH 15/23] linux-gen: drv: devio registration

From: Christophe Milard devios (dev IO) provide a interface for drivers to access a device: Devices enumerated by enumerators may be accessed in by different mechanisms (depending on iommu presence or other factors). This extra abstraction is provided by devios,

[lng-odp] [PATCH 11/23] drv: driver: adding device query function

From: Christophe Milard Adding a function for querying a list of devices: this function may be used by enumerators to query for the list of their registered devices or for a subset of them. Note that this function returns a malloc'd list of devices which is to be

[lng-odp] [PATCH 14/23] drv: driver: adding a probe and remove callback for devio

From: Christophe Milard Needed to delete the resources needed for the devio. That is possibly the memory allocated for its "ops" part if it was allocated. May be NULL if nothing needs to be done at devio deletion time. Signed-off-by: Christophe Milard

[lng-odp] [PATCH 12/23] linux-gen: drv: driver: adding device querry function

From: Christophe Milard Implementation of the device query function for the linux-gen ODP. Signed-off-by: Christophe Milard --- /** Email created from pull request 16 (heyi-linaro:driver-framework) **

[lng-odp] [PATCH 10/23] linux-gen: drv: device creation and deletion

From: Christophe Milard Functions to create and remove devices are populated to do more proper things. Signed-off-by: Christophe Milard --- /** Email created from pull request 16 (heyi-linaro:driver-framework) **

[lng-odp] [PATCH 09/23] drv: driver: add callback function for device destruction

From: Christophe Milard When a device is destroyed by an enumerator, odpdrv_device_destroy() is called. However, the complete device destruction may require waiting for IO to be completed: the device destruction is therefore divided in 2 steps:

[lng-odp] [PATCH 07/23] test: drv: enumerator registration tests

From: Christophe Milard making sure that enumerators are probed. Signed-off-by: Christophe Milard --- /** Email created from pull request 16 (heyi-linaro:driver-framework) ** https://github.com/Linaro/odp/pull/16 ** Patch:

[lng-odp] [PATCH 08/23] drv: driver: change drv unbind function name and pass correct parameter

From: Christophe Milard The driver removal function expects a device, of course... Also unbind seems a better name to disconnect from a device since remove has been used for removing the object itself for enumerators. Some extra parameters to allow for graceful

[lng-odp] [PATCH 06/23] linux-gen: drv: enumerator registration

From: Christophe Milard The enumerator registration functions for the linux-gen ODP implementation. Signed-off-by: Christophe Milard --- /** Email created from pull request 16 (heyi-linaro:driver-framework) **

[lng-odp] [PATCH 05/23] test: drv: enumerator_class registration tests

From: Christophe Milard Testing that enumerators classes can register properly. Saddly restricted to statically linked enumerators classes, as testing with modules in autotools seems to be an issue so far. Signed-off-by: Christophe Milard

[lng-odp] [PATCH 04/23] linux-gen: drv: enumerator_class registration

From: Christophe Milard The functions to register and probe enumerator classes are added. Signed-off-by: Christophe Milard --- /** Email created from pull request 16 (heyi-linaro:driver-framework) **

[lng-odp] [PATCH 03/23] drv: making parameter strings dynamically computable

From: Christophe Milard Declaring strings as const in the driver API prevents dynamic calculation of these strings, which is a drawback. For instance, the device addresses (string) are typically calculated by enumerators, and should therefore not be const... Other

[lng-odp] [PATCH 01/23] drv: adding compiler hints in the driver interface

From: Christophe Milard Largely inspired from its north api counterpart, the drv/spec/hint.h file is added. Also includes the __constructor__ attributes that many driver interface items will need. Signed-off-by: Christophe Milard ---

[lng-odp] [PATCH 02/23] linux-gen: adding compiler hints in the driver interface

From: Christophe Milard Just including the spec file from the linux-generic side, as usual. Signed-off-by: Christophe Milard --- /** Email created from pull request 16 (heyi-linaro:driver-framework) **

Re: [lng-odp] make check FAILS on TM test

sending patch for that... On 26 April 2017 at 09:46, Savolainen, Petri (Nokia - FI/Espoo) < petri.savolai...@nokia-bell-labs.com> wrote: > > 'make check' fails now on both master and api-next. > > > FAIL: ../../test/common_plat/validation/api/traffic_mngr/traffic_mngr >

Re: [lng-odp] [API-NEXT PATCH 8/8] linux-gen: time: use hw time counter when available

> > > This function (cpu_global_time()) is called only when we have first > checked that TSC is invariant. Also we measure the TSC frequency in that > case. This function is defined in the same file as cpu_cycles(), and the > file is x86 specific. So, we know what we are doing, and just re-using

Re: [lng-odp] [API-NEXT PATCH 8/8] linux-gen: time: use hw time counter when available

> > From coverletter: > > "This patch set modifies time implementation to use TSC when running on > a x86 > > CPU that has invarint TSC CPU flag set. Otherwise, the same Linux system > time > > is used as before. TSC is much more efficient both in performance and > > latency/jitter wise than

[lng-odp] make check FAILS on TM test

'make check' fails now on both master and api-next. FAIL: ../../test/common_plat/validation/api/traffic_mngr/traffic_mngr = ./../../test/common_plat/validation/api/traffic_mngr/traffic_mngr.sh: 15: