On Thu, Jun 1, 2017 at 9:48 PM, Brian Brooks wrote:
> On 06/01 15:00:28, Bill Fischofer wrote:
>> If this is a bug fix it should reference a Bug that describes in more
>> detail what is being fixed.
>
> Can you elaborate?
>
> The subject line "Fixes for GCC 7" is sufficient.
https://bugs.linaro.org/show_bug.cgi?id=3024
Bug ID: 3024
Summary: odp_traffic_mngr example is broken
Product: OpenDataPlane - linux- generic reference
Version: v1.14.0.0
Hardware: Other
OS: Linux
Status:
On 01/06/2017, 22:15, "Honnappa Nagarahalli"
wrote:
>On 1 June 2017 at 15:09, Ola Liljedahl wrote:
>>
>>
>> On 01/06/2017, 21:03, "Bill Fischofer"
>>wrote:
>>
>>>On Thu, Jun 1, 2017 at 10:59 AM, Honnappa
On 1 June 2017 at 15:09, Ola Liljedahl wrote:
>
>
> On 01/06/2017, 21:03, "Bill Fischofer" wrote:
>
>>On Thu, Jun 1, 2017 at 10:59 AM, Honnappa Nagarahalli
>> wrote:
>>> On 1 June 2017 at 01:26, Elo, Matias (Nokia
On 01/06/2017, 21:03, "Bill Fischofer" wrote:
>On Thu, Jun 1, 2017 at 10:59 AM, Honnappa Nagarahalli
> wrote:
>> On 1 June 2017 at 01:26, Elo, Matias (Nokia - FI/Espoo)
>> wrote:
>>>
On 31 May 2017, at
If this is a bug fix it should reference a Bug that describes in more
detail what is being fixed.
On Thu, Jun 1, 2017 at 2:05 PM, Brian Brooks wrote:
> Signed-off-by: Brian Brooks
> Reviewed-by: Ola Liljedahl
> Reviewed-by:
Branch: refs/heads/master
Home: https://github.com/Linaro/odp
Commit: a48979af5b36c11fb5c7f8d2c6029c12bb191b51
https://github.com/Linaro/odp/commit/a48979af5b36c11fb5c7f8d2c6029c12bb191b51
Author: Petri Savolainen
Date: 2017-06-01 (Thu, 01 Jun
Signed-off-by: Brian Brooks
Reviewed-by: Ola Liljedahl
Reviewed-by: Honnappa Nagarahalli
---
configure.ac | 5 +
platform/linux-generic/m4/configure.m4| 4
On Thu, Jun 1, 2017 at 10:59 AM, Honnappa Nagarahalli
wrote:
> On 1 June 2017 at 01:26, Elo, Matias (Nokia - FI/Espoo)
> wrote:
>>
>>> On 31 May 2017, at 23:53, Bill Fischofer wrote:
>>>
>>> On Wed, May 31, 2017
Re-sending with updated comments.
Regards
Shally
On Thu, Jun 1, 2017 at 7:58 PM, Verma, Shally
wrote:
> Regards
> Shally
>
> -Original Message-
> From: Savolainen, Petri (Nokia - FI/Espoo) [mailto:petri.savolainen@
> nokia.com]
> Sent: 01 June 2017 18:20
> To:
From: Honnappa Nagarahalli
Created abstract queue type. Queue APIs and functions towards the
internal components are converted into function pointers.
Signed-off-by: Honnappa Nagarahalli
---
/** Email created from pull request 43
github
/** Email created from pull request 43 (nagarahalli:api-next-mod-queue1)
** https://github.com/Linaro/odp/pull/43
** Patch: https://github.com/Linaro/odp/pull/43.patch
** Base sha: a9fc17e1bbef1c3585fd5de47e5023e4d66504f5
** Merge commit sha:
On 1 June 2017 at 01:26, Elo, Matias (Nokia - FI/Espoo)
wrote:
>
>> On 31 May 2017, at 23:53, Bill Fischofer wrote:
>>
>> On Wed, May 31, 2017 at 8:12 AM, Elo, Matias (Nokia - FI/Espoo)
>> wrote:
>>>
>> What’s the
https://bugs.linaro.org/show_bug.cgi?id=3017
--- Comment #4 from Maxim Uvarov ---
https://github.com/Linaro/odp/commit/14bebe8bac40b2b0f4a00cce4ef9a7031cc1b8cc
2017-06-01T17:43:16+03:00
Maxim Uvarov maxim.uva...@linaro.org
test: time: do not fail under gcov
code
Branch: refs/heads/next
Home: https://github.com/Linaro/odp
Commit: f0483afab9c4a75210e1bd9a66b37432eafa6e3a
https://github.com/Linaro/odp/commit/f0483afab9c4a75210e1bd9a66b37432eafa6e3a
Author: Petri Savolainen
Date: 2017-05-30 (Tue, 30 May 2017)
https://bugs.linaro.org/show_bug.cgi?id=3017
--- Comment #3 from Maxim Uvarov ---
https://github.com/Linaro/odp/commit/7a7e3ff9d50d67b7c79058db98ba27ab5a806437
2017-06-01T16:04:07+03:00
Maxim Uvarov maxim.uva...@linaro.org
test: time: do not fail under gcov
code
Branch: refs/heads/api-next
Home: https://github.com/Linaro/odp
Commit: 7a7e3ff9d50d67b7c79058db98ba27ab5a806437
https://github.com/Linaro/odp/commit/7a7e3ff9d50d67b7c79058db98ba27ab5a806437
Author: Maxim Uvarov
Date: 2017-06-01 (Thu, 01 Jun 2017)
Regards
Shally
-Original Message-
From: Savolainen, Petri (Nokia - FI/Espoo) [mailto:petri.savolai...@nokia.com]
Sent: 01 June 2017 18:20
To: Shally Verma ; lng-odp@lists.linaro.org
Cc: Challa, Mahipal ; Narayana, Prasad Athreya
On 06/01/17 13:52, Matias Elo wrote:
> A system may simultaneously support multiple huge page sizes. Add a new API
> function odp_sys_huge_page_size_all() which returns all supported page
> sizes. odp_sys_huge_page_size() stays unmodified to maintain backward
> compatibility.
>
> Signed-off-by:
https://bugs.linaro.org/show_bug.cgi?id=3017
--- Comment #2 from Maxim Uvarov ---
https://github.com/Linaro/odp/commit/7a7e3ff9d50d67b7c79058db98ba27ab5a806437
2017-06-01T16:04:07+03:00
Maxim Uvarov maxim.uva...@linaro.org
test: time: do not fail under gcov
code
Branch: refs/heads/master
Home: https://github.com/Linaro/odp
Commit: 7a7e3ff9d50d67b7c79058db98ba27ab5a806437
https://github.com/Linaro/odp/commit/7a7e3ff9d50d67b7c79058db98ba27ab5a806437
Author: Maxim Uvarov
Date: 2017-06-01 (Thu, 01 Jun 2017)
Thanks, will do.
-Matias
> On 1 Jun 2017, at 15:44, Bill Fischofer wrote:
>
> This still needs implementation, validation tests, and doc updates to
> be complete.
>
> On Thu, Jun 1, 2017 at 5:52 AM, Matias Elo wrote:
>> A system may
> -Original Message-
> From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of
> Shally Verma
> Sent: Monday, May 22, 2017 9:55 AM
> To: lng-odp@lists.linaro.org
> Cc: Mahipal Challa ; pathr...@cavium.com; Shally Verma
>
> Subject:
This still needs implementation, validation tests, and doc updates to
be complete.
On Thu, Jun 1, 2017 at 5:52 AM, Matias Elo wrote:
> A system may simultaneously support multiple huge page sizes. Add a new API
> function odp_sys_huge_page_size_all() which returns all
After quick comparison between next and api-next: ipsec.h should not yet be in
next branch == not in next release.
Also, it would be good to have these in next release
* checkpatch/spelling (master)
* crypto bug fixes/missing implementation series (api-next)
-Petri
From: Maxim Uvarov
>>> + *
>>> + * @param[out] size Points to an array of huge page sizes for output
>>> + * @param num Maximum number of huge page sizes to output
>>> + *
>>> + * @return Number of supported huge page sizes
>>> + * @retval 0 on no huge pages
>>> + */
>>> +unsigned
For this series:
Reviewed-by: Bill Fischofer
On Thu, Jun 1, 2017 at 2:18 AM, Petri Savolainen
wrote:
> Checkpatch code should not be modified directly. When the code
> is updated to a next version, any local modifications would
> be lost
On Fri, May 5, 2017 at 8:58 AM, Matias Elo wrote:
> The old test wasn't valid, since a system may support multiple huge page
> sizes. As odp_sys_huge_page_size() returns currently only a single value
> more precise test than 'page_size != 0' cannot be performed.
>
>
On Thu, Jun 1, 2017 at 6:00 AM, Petri Savolainen
wrote:
> Updated Linux spelling file to it's latest version.
>
> Signed-off-by: Petri Savolainen
Reviewed-by: Bill Fischofer
> ---
> scripts/spelling.txt |
On Thu, Jun 1, 2017 at 6:04 AM, Savolainen, Petri (Nokia - FI/Espoo)
wrote:
> Reviewed-by: Petri Savolainen
>
>
>> -Original Message-
>> From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of
>> Matias Elo
>> Sent:
Reviewed-by: Petri Savolainen
> -Original Message-
> From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of
> Matias Elo
> Sent: Thursday, June 01, 2017 1:53 PM
> To: lng-odp@lists.linaro.org
> Subject: Suspected SPAM - [lng-odp] [API-NEXT
Updated Linux spelling file to it's latest version.
Signed-off-by: Petri Savolainen
---
scripts/spelling.txt | 151 +--
1 file changed, 147 insertions(+), 4 deletions(-)
diff --git a/scripts/spelling.txt
A system may simultaneously support multiple huge page sizes. Add a new API
function odp_sys_huge_page_size_all() which returns all supported page
sizes. odp_sys_huge_page_size() stays unmodified to maintain backward
compatibility.
Signed-off-by: Matias Elo
---
Reviewed-by: Petri Savolainen
> -Original Message-
> From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of
> Dmitry Eremin-Solenikov
> Sent: Thursday, June 01, 2017 12:03 PM
> To: lng-odp@lists.linaro.org
> Subject: [lng-odp] [PATCH API-NEXT
> On 5 May 2017, at 17:19, Bill Fischofer wrote:
>
>
>
> On Fri, May 5, 2017 at 8:58 AM, Matias Elo wrote:
> The old test wasn't valid, since a system may support multiple huge page
> sizes. As odp_sys_huge_page_size() returns currently only
Signed-off-by: Dmitry Eremin-Solenikov
---
platform/linux-generic/odp_crypto.c | 13 -
1 file changed, 12 insertions(+), 1 deletion(-)
diff --git a/platform/linux-generic/odp_crypto.c
b/platform/linux-generic/odp_crypto.c
index
Signed-off-by: Dmitry Eremin-Solenikov
---
platform/linux-generic/odp_crypto.c | 13 -
1 file changed, 12 insertions(+), 1 deletion(-)
diff --git a/platform/linux-generic/odp_crypto.c
b/platform/linux-generic/odp_crypto.c
index
Signed-off-by: Dmitry Eremin-Solenikov
---
test/common_plat/validation/api/crypto/crypto.h| 3 +-
.../validation/api/crypto/odp_crypto_test_inp.c| 110 -
.../validation/api/crypto/test_vectors.h | 50 ++
Signed-off-by: Dmitry Eremin-Solenikov
---
test/common_plat/validation/api/crypto/crypto.h| 3 +-
.../validation/api/crypto/odp_crypto_test_inp.c| 126 +++--
.../validation/api/crypto/test_vectors.h | 44 +++
Signed-off-by: Dmitry Eremin-Solenikov
---
test/common_plat/validation/api/crypto/crypto.h| 2 +
.../validation/api/crypto/odp_crypto_test_inp.c| 71 ++
.../validation/api/crypto/test_vectors.h | 12
If odp_crypto_session_create() failed, there is no point in
checking/freeing session, as it might not have been updated.
Signed-off-by: Dmitry Eremin-Solenikov
---
test/common_plat/performance/odp_crypto.c | 44 +++
1 file changed,
There is no point in having separate cases for NULL algorithms. Add
capabilities returning 0 key/digest/iv length.
Signed-off-by: Dmitry Eremin-Solenikov
---
platform/linux-generic/odp_crypto.c| 14 ++
Signed-off-by: Dmitry Eremin-Solenikov
---
platform/linux-generic/odp_crypto.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/platform/linux-generic/odp_crypto.c
b/platform/linux-generic/odp_crypto.c
index ea7c702650f6..32fece308beb
Signed-off-by: Dmitry Eremin-Solenikov
---
platform/linux-generic/odp_crypto.c | 184 +++-
1 file changed, 138 insertions(+), 46 deletions(-)
diff --git a/platform/linux-generic/odp_crypto.c
Signed-off-by: Dmitry Eremin-Solenikov
---
platform/linux-generic/odp_crypto.c | 78 +
1 file changed, 45 insertions(+), 33 deletions(-)
diff --git a/platform/linux-generic/odp_crypto.c
b/platform/linux-generic/odp_crypto.c
There is now nearly no difference between AES-CBC and 3DES-CBC code.
Merge it into generic 'cipher' support, easing adding support for other
ciphers in future.
Signed-off-by: Dmitry Eremin-Solenikov
---
.../linux-generic/include/odp_crypto_internal.h| 13
Rewrite 3DES-CBC to use generic EVP interface following AES-GCM
implementation.
Signed-off-by: Dmitry Eremin-Solenikov
---
.../linux-generic/include/odp_crypto_internal.h| 5 +-
platform/linux-generic/odp_crypto.c| 78
Rewrite AES-CBC to use generic EVP interface following AES-GCM
implementation.
Signed-off-by: Dmitry Eremin-Solenikov
---
.../linux-generic/include/odp_crypto_internal.h| 3 +-
platform/linux-generic/odp_crypto.c| 70 --
Signed-off-by: Dmitry Eremin-Solenikov
---
platform/linux-generic/odp_crypto.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/platform/linux-generic/odp_crypto.c
b/platform/linux-generic/odp_crypto.c
index 3deec7de3f7c..ff3f1ac76780 100644
---
Using single context for all operations is not thread safe: multiple
threads can access the same context in parallel, affecting its internal
state. Make AES-GCM functions use local context for en/decryption
operations.
Signed-off-by: Dmitry Eremin-Solenikov
---
There is no need to memcpy IV if it gets passed to EVP functions.
Signed-off-by: Dmitry Eremin-Solenikov
---
platform/linux-generic/odp_crypto.c | 20 ++--
1 file changed, 2 insertions(+), 18 deletions(-)
diff --git
Make AES-GCM use recently introduced aad and auth_digest_len fields.
Signed-off-by: Dmitry Eremin-Solenikov
---
platform/linux-generic/odp_crypto.c | 58 ++---
1 file changed, 15 insertions(+), 43 deletions(-)
diff --git
In addition to truncated digests (used by IPsec) add full-length
capabilities to SHA* algos.
Signed-off-by: Dmitry Eremin-Solenikov
---
platform/linux-generic/odp_crypto.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git
Signed-off-by: Dmitry Eremin-Solenikov
---
platform/linux-generic/odp_crypto.c | 19 +--
1 file changed, 13 insertions(+), 6 deletions(-)
diff --git a/platform/linux-generic/odp_crypto.c
b/platform/linux-generic/odp_crypto.c
index
Signed-off-by: Dmitry Eremin-Solenikov
---
example/ipsec/odp_ipsec_cache.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/example/ipsec/odp_ipsec_cache.c b/example/ipsec/odp_ipsec_cache.c
index b2a91c242fe0..dba0ea0ab0c6 100644
---
Signed-off-by: Dmitry Eremin-Solenikov
---
.../validation/api/crypto/odp_crypto_test_inp.c| 55 +-
.../validation/api/crypto/test_vectors.h | 65 --
2 files changed, 64 insertions(+), 56 deletions(-)
diff --git
Signed-off-by: Dmitry Eremin-Solenikov
---
test/common_plat/performance/odp_crypto.c | 14 +++---
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/test/common_plat/performance/odp_crypto.c
b/test/common_plat/performance/odp_crypto.c
index
Signed-off-by: Dmitry Eremin-Solenikov
---
.../validation/api/crypto/odp_crypto_test_inp.c| 57 +-
.../validation/api/crypto/test_vectors.h | 10
.../validation/api/crypto/test_vectors_len.h | 3 --
3 files changed,
This is a cummulative patchset incorporating:
- AAD/ auth_digest_len implementation
- crypto engine working across packet segments
- SHA-1/SHA-512 implementation
- small fixes
GitHub bot did not send this serie for quite some time, so I'm sending it
manually. On GitHub exactly the same patch
On 01.06.2017 11:22, Dmitry Eremin-Solenikov wrote:
> This is a cummulative patchset incorporating:
> - AAD/ auth_digest_len implementation
> - crypto engine working across packet segments
> - SHA-1/SHA-512 implementation
> - small fixes
>
> GitHub bot did not send this serie for quite some
Signed-off-by: Dmitry Eremin-Solenikov
---
test/common_plat/validation/api/crypto/crypto.h| 2 +
.../validation/api/crypto/odp_crypto_test_inp.c| 71 ++
.../validation/api/crypto/test_vectors.h | 12
There is no need to memcpy IV if it gets passed to EVP functions.
Signed-off-by: Dmitry Eremin-Solenikov
---
platform/linux-generic/odp_crypto.c | 20 ++--
1 file changed, 2 insertions(+), 18 deletions(-)
diff --git
Signed-off-by: Dmitry Eremin-Solenikov
---
platform/linux-generic/odp_crypto.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/platform/linux-generic/odp_crypto.c
b/platform/linux-generic/odp_crypto.c
index 3deec7de3f7c..ff3f1ac76780 100644
---
Using single context for all operations is not thread safe: multiple
threads can access the same context in parallel, affecting its internal
state. Make AES-GCM functions use local context for en/decryption
operations.
Signed-off-by: Dmitry Eremin-Solenikov
---
There is no point in having separate cases for NULL algorithms. Add
capabilities returning 0 key/digest/iv length.
Signed-off-by: Dmitry Eremin-Solenikov
---
platform/linux-generic/odp_crypto.c| 14 ++
There is no need to memcpy IV if it gets passed to EVP functions.
Signed-off-by: Dmitry Eremin-Solenikov
---
platform/linux-generic/odp_crypto.c | 20 ++--
1 file changed, 2 insertions(+), 18 deletions(-)
diff --git
Make AES-GCM use recently introduced aad and auth_digest_len fields.
Signed-off-by: Dmitry Eremin-Solenikov
---
platform/linux-generic/odp_crypto.c | 58 ++---
1 file changed, 15 insertions(+), 43 deletions(-)
diff --git
Make AES-GCM use recently introduced aad and auth_digest_len fields.
Signed-off-by: Dmitry Eremin-Solenikov
---
platform/linux-generic/odp_crypto.c | 58 ++---
1 file changed, 15 insertions(+), 43 deletions(-)
diff --git
In addition to truncated digests (used by IPsec) add full-length
capabilities to SHA* algos.
Signed-off-by: Dmitry Eremin-Solenikov
---
platform/linux-generic/odp_crypto.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git
In addition to truncated digests (used by IPsec) add full-length
capabilities to SHA* algos.
Signed-off-by: Dmitry Eremin-Solenikov
---
platform/linux-generic/odp_crypto.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git
Signed-off-by: Dmitry Eremin-Solenikov
---
platform/linux-generic/odp_crypto.c | 19 +--
1 file changed, 13 insertions(+), 6 deletions(-)
diff --git a/platform/linux-generic/odp_crypto.c
b/platform/linux-generic/odp_crypto.c
index
Signed-off-by: Dmitry Eremin-Solenikov
---
platform/linux-generic/odp_crypto.c | 19 +--
1 file changed, 13 insertions(+), 6 deletions(-)
diff --git a/platform/linux-generic/odp_crypto.c
b/platform/linux-generic/odp_crypto.c
index
Signed-off-by: Dmitry Eremin-Solenikov
---
test/common_plat/performance/odp_crypto.c | 13 ++---
1 file changed, 6 insertions(+), 7 deletions(-)
diff --git a/test/common_plat/performance/odp_crypto.c
b/test/common_plat/performance/odp_crypto.c
index
Signed-off-by: Dmitry Eremin-Solenikov
---
example/ipsec/odp_ipsec_cache.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/example/ipsec/odp_ipsec_cache.c b/example/ipsec/odp_ipsec_cache.c
index b2a91c242fe0..dba0ea0ab0c6 100644
---
Signed-off-by: Dmitry Eremin-Solenikov
---
.../validation/api/crypto/odp_crypto_test_inp.c| 55 +-
.../validation/api/crypto/test_vectors.h | 65 --
2 files changed, 64 insertions(+), 56 deletions(-)
diff --git
Signed-off-by: Dmitry Eremin-Solenikov
---
.../validation/api/crypto/odp_crypto_test_inp.c| 55 +-
.../validation/api/crypto/test_vectors.h | 65 --
2 files changed, 64 insertions(+), 56 deletions(-)
diff --git
Signed-off-by: Dmitry Eremin-Solenikov
---
.../validation/api/crypto/odp_crypto_test_inp.c| 57 +-
.../validation/api/crypto/test_vectors.h | 10
.../validation/api/crypto/test_vectors_len.h | 3 --
3 files changed,
Signed-off-by: Dmitry Eremin-Solenikov
---
.../validation/api/crypto/odp_crypto_test_inp.c| 57 +-
.../validation/api/crypto/test_vectors.h | 10
.../validation/api/crypto/test_vectors_len.h | 3 --
3 files changed,
This is a cummulative patchset incorporating:
- AAD/ auth_digest_len implementation
- crypto engine working across packet segments
- SHA-1/SHA-512 implementation
- small fixes
GitHub bot did not send this serie for quite some time, so I'm sending it
manually. On GitHub exactly the same patch
> -Original Message-
> From: Honnappa Nagarahalli [mailto:honnappa.nagaraha...@linaro.org]
> Sent: Wednesday, May 31, 2017 9:03 PM
> To: Savolainen, Petri (Nokia - FI/Espoo)
> Cc: Brian Brooks ; lng-odp@lists.linaro.org; Ola
> Liljedahl
> On 31 May 2017, at 17:40, Bogdan Pricope wrote:
>
> Add HW checksum calculation/validation support for dpdk pktio.
> No UDP/TCP HW checksum calculation/validation support for:
> - IPv4 fragments
> - IPv6 packets with extension headers (including fragments)
>
>
On 31.05.2017 21:03, Honnappa Nagarahalli wrote:
> On 31 May 2017 at 03:02, Savolainen, Petri (Nokia - FI/Espoo)
> wrote:
>>
>>
>> Arch specific code is not commonly added into odp-linux, but when you do add
>> it you need to try hard not to break the code for others.
Checkpatch code should not be modified directly. When the code
is updated to a next version, any local modifications would
be lost and needed to be done again.
Camelcase check is enabled again. Exceptions to camelcase are
allowed e.g. when calling an external library interface.
Signed-off-by:
These warnings were disabled with code modification. Use
checkpatch config file to ignore those.
Signed-off-by: Petri Savolainen
---
.checkpatch.conf | 2 ++
1 file changed, 2 insertions(+)
diff --git a/.checkpatch.conf b/.checkpatch.conf
index 043551a4..990a54d2
> On 31 May 2017, at 23:53, Bill Fischofer wrote:
>
> On Wed, May 31, 2017 at 8:12 AM, Elo, Matias (Nokia - FI/Espoo)
> wrote:
>>
> What’s the purpose of calling ord_enq_multi() here? To save (stash)
> packets if the thread is
85 matches
Mail list logo