Hi Bala,
According to the documentation, classifier can be operate with PKTIN_QUEUE_MODE.
/** Enable classifier
*
* * 0: Classifier is disabled (default)
* * 1: Classifier is enabled. Use classifier to direct incoming
* packets into pktin event
Hi,
Both these modes cannot co-exist.
There is a parameter 'classifier_enable' and 'hash_enable' as part of
odp_pktin_queue_param_t which is used to identify whether classifier
or hashing is enabled for a particular pktio interface.
Both classifier and hash configuration are orthogonal and only
https://bugs.linaro.org/show_bug.cgi?id=2903
--- Comment #11 from Bala Manoharan ---
I was hoping my PR for RED will get in soon.
I will work on this bug and get this in before TigerMoth.
Regards,
Bala
On 9 November 2017 at 21:22,
I was hoping my PR for RED will get in soon.
I will work on this bug and get this in before TigerMoth.
Regards,
Bala
On 9 November 2017 at 21:22, wrote:
> https://bugs.linaro.org/show_bug.cgi?id=2903
>
> --- Comment #10 from Bill Fischofer
Hi Bogdan/Josep,
I have created a document explaining my thoughts, please take a look.
https://docs.google.com/a/linaro.org/document/d/1dUHnt1jOm61Lz3GkwT7RHMCPMCmHRo0pXio3MMdKHsM/edit?usp=sharing
Thanks,
Honnappa
Balasubramanian Manoharan(bala-manoharan) replied on github web page:
platform/linux-generic/odp_classification.c
line 5
@@ -190,6 +190,8 @@ int odp_cls_capability(odp_cls_capability_t *capability)
capability->supported_terms.bit.tcp_sport = 1;
ODP2.0 should allow ODP to leverage directly libiverbs from a native ODP
pktio without DPDK layer.
Mellanox has created a userland framework based on libiverbs while we try
to promote an extension of Mediated Device (vfio-mdev).
FF
On 9 November 2017 at 14:18, Maxim Uvarov
From: Balasubramanian Manoharan
odp_percent_t is used to express values which are percentages
Signed-off-by: Balasubramanian Manoharan
---
/** Email created from pull request 277 (bala-manoharan:RED)
**
From: Balasubramanian Manoharan
Adds random early detection and Back pressure feature to CoS
Signed-off-by: Balasubramanian Manoharan
---
/** Email created from pull request 277 (bala-manoharan:RED)
**
From: Balasubramanian Manoharan
linux-generic does not support random early detection and back pressure
Signed-off-by: Balasubramanian Manoharan
---
/** Email created from pull request 277 (bala-manoharan:RED)
**
From: Balasubramanian Manoharan
odp_threshold_t is used to configure different threshold types
Signed-off-by: Balasubramanian Manoharan
---
/** Email created from pull request 277 (bala-manoharan:RED)
**
adds RED and BP configuration to both pool and queue parameters
github
/** Email created from pull request 277 (bala-manoharan:RED)
** https://github.com/Linaro/odp/pull/277
** Patch: https://github.com/Linaro/odp/pull/277.patch
** Base sha:
From: Bill Fischofer
Signed-off-by: Bill Fischofer
---
/** Email created from pull request 290 (Bill-Fischofer-Linaro:v1.16-changelog)
** https://github.com/Linaro/odp/pull/290
** Patch: https://github.com/Linaro/odp/pull/290.patch
**
Add additional updates for v1.16.0.0 CHANGELOG to reflect items already in
master.
github
/** Email created from pull request 290 (Bill-Fischofer-Linaro:v1.16-changelog)
** https://github.com/Linaro/odp/pull/290
** Patch:
Hi,
I'm trying to understand how odp-classifier can work with PKTIO in
ODP_PKTIN_MODE_QUEUE mode, as this combination is allow in the API.
When configuring PKTIO in ODP_PKTIN_MODE_QUEUE then application should call
'odp_pktin_event_queue' to retrieve the odp-queues.
When application create a
muvarov replied on github web page:
test/validation/api/pktio/pktio.c
@@ -48,6 +48,9 @@ static int num_ifaces;
interface that just become up.*/
static bool wait_for_network;
+/* Dummy global variable to avoid compiler optimizing out API calls */
+uint64_t odp_valid_test_pktio_u64;
Petri Savolainen(psavol) replied on github web page:
test/validation/api/pktio/pktio.c
@@ -48,6 +48,9 @@ static int num_ifaces;
interface that just become up.*/
static bool wait_for_network;
+/* Dummy global variable to avoid compiler optimizing out API calls */
+uint64_t
Bill Fischofer(Bill-Fischofer-Linaro) replied on github web page:
include/odp/api/spec/packet.h
line 129
@@ -1140,6 +1179,82 @@ int odp_packet_move_data(odp_packet_t pkt, uint32_t
dst_offset,
*/
/**
+ * Packet parse parameters
+ */
+typedef struct odp_packet_parse_param_t {
+ /**
bogdanPricope replied on github web page:
include/odp/api/spec/packet.h
@@ -1140,6 +1179,82 @@ int odp_packet_move_data(odp_packet_t pkt, uint32_t
dst_offset,
*/
/**
+ * Packet parse parameters
+ */
+typedef struct odp_packet_parse_param_t {
+ /** Protocol header at parse starting
bogdanPricope replied on github web page:
include/odp/api/spec/packet.h
@@ -1140,6 +1179,82 @@ int odp_packet_move_data(odp_packet_t pkt, uint32_t
dst_offset,
*/
/**
+ * Packet parse parameters
+ */
+typedef struct odp_packet_parse_param_t {
+ /** Protocol header at parse starting
bogdanPricope replied on github web page:
include/odp/api/spec/packet.h
@@ -1140,6 +1179,82 @@ int odp_packet_move_data(odp_packet_t pkt, uint32_t
dst_offset,
*/
/**
+ * Packet parse parameters
+ */
+typedef struct odp_packet_parse_param_t {
+ /** Protocol header at parse starting
Dmitry Eremin-Solenikov(lumag) replied on github web page:
include/odp/api/spec/packet.h
line 75
@@ -1140,6 +1179,82 @@ int odp_packet_move_data(odp_packet_t pkt, uint32_t
dst_offset,
*/
/**
+ * Packet parse parameters
+ */
+typedef struct odp_packet_parse_param_t {
+ /** Protocol
Petri Savolainen(psavol) replied on github web page:
include/odp/api/spec/packet.h
line 129
@@ -1140,6 +1179,82 @@ int odp_packet_move_data(odp_packet_t pkt, uint32_t
dst_offset,
*/
/**
+ * Packet parse parameters
+ */
+typedef struct odp_packet_parse_param_t {
+ /** Protocol header
Petri Savolainen(psavol) replied on github web page:
include/odp/api/spec/packet.h
@@ -1140,6 +1179,82 @@ int odp_packet_move_data(odp_packet_t pkt, uint32_t
dst_offset,
*/
/**
+ * Packet parse parameters
+ */
+typedef struct odp_packet_parse_param_t {
+ /** Protocol header at parse
Petri Savolainen(psavol) replied on github web page:
include/odp/api/spec/packet.h
line 87
@@ -1140,6 +1179,82 @@ int odp_packet_move_data(odp_packet_t pkt, uint32_t
dst_offset,
*/
/**
+ * Packet parse parameters
+ */
+typedef struct odp_packet_parse_param_t {
+ /** Protocol header at
Petri Savolainen(psavol) replied on github web page:
include/odp/api/spec/packet.h
@@ -1140,6 +1179,82 @@ int odp_packet_move_data(odp_packet_t pkt, uint32_t
dst_offset,
*/
/**
+ * Packet parse parameters
+ */
+typedef struct odp_packet_parse_param_t {
+ /** Protocol header at parse
nagarahalli replied on github web page:
platform/linux-generic/pktio/dpdk.c
line 70
@@ -1372,10 +1382,10 @@ static int dpdk_recv(pktio_entry_t *pktio_entry, int
index,
if (!pkt_dpdk->lockless_rx)
odp_ticketlock_lock(_dpdk->rx_lock[index]);
/**
-* ixgbe_pmd
Petri Savolainen(psavol) replied on github web page:
include/odp/api/spec/crypto.h
@@ -131,6 +131,12 @@ typedef enum {
*/
ODP_AUTH_ALG_AES_GCM,
+ /** AES in Galois/Counter MAC Mode
+*
+* @note Must be paired with cipher ODP_CIPHER_ALG_NULL
+*/
+
Add additional updates for v1.16.0.0 CHANGELOG to reflect items already in
master.
github
/** Email created from pull request 290 (Bill-Fischofer-Linaro:v1.16-changelog)
** https://github.com/Linaro/odp/pull/290
** Patch:
From: Bill Fischofer
---
/** Email created from pull request 290 (Bill-Fischofer-Linaro:v1.16-changelog)
** https://github.com/Linaro/odp/pull/290
** Patch: https://github.com/Linaro/odp/pull/290.patch
** Base sha: 88e124e13900109e0d0aec1981417382f357c98a
** Merge
https://bugs.linaro.org/show_bug.cgi?id=3210
Dmitry Eremin-Solenikov changed:
What|Removed |Added
Status|RESOLVED
https://bugs.linaro.org/show_bug.cgi?id=2411
--- Comment #10 from Bill Fischofer ---
Ping to Petri. Did you want to post a PR to remove the to-dos?
--
You are receiving this mail because:
You are on the CC list for the bug.
https://bugs.linaro.org/show_bug.cgi?id=2988
--- Comment #13 from Bill Fischofer ---
Not critical for Tiger Moth. Can revisit this afterwards.
--
You are receiving this mail because:
You are on the CC list for the bug.
https://bugs.linaro.org/show_bug.cgi?id=2903
--- Comment #10 from Bill Fischofer ---
Ping to Bala. Still on your to-do list?
--
You are receiving this mail because:
You are on the CC list for the bug.
https://bugs.linaro.org/show_bug.cgi?id=3210
Bill Fischofer changed:
What|Removed |Added
Resolution|--- |FIXED
https://bugs.linaro.org/show_bug.cgi?id=3411
Bill Fischofer changed:
What|Removed |Added
Resolution|--- |FIXED
From: Dmitry Eremin-Solenikov
Implement AES-GMAC on top of OpenSSL AES-GCM with all text going into
AAD part.
Signed-off-by: Dmitry Eremin-Solenikov
---
/** Email created from pull request 288 (lumag:gmac)
**
From: Dmitry Eremin-Solenikov
Implement AES-GMAC-ESP support.
Signed-off-by: Dmitry Eremin-Solenikov
---
/** Email created from pull request 288 (lumag:gmac)
** https://github.com/Linaro/odp/pull/288
** Patch:
From: Dmitry Eremin-Solenikov
Add AES-GMAC-ESP testcase based on draft-mcgrew-gcm-test-01.
Signed-off-by: Dmitry Eremin-Solenikov
---
/** Email created from pull request 288 (lumag:gmac)
**
From: Dmitry Eremin-Solenikov
Add AES-GMAC declarations to support RFC4543.
Signed-off-by: Dmitry Eremin-Solenikov
---
/** Email created from pull request 288 (lumag:gmac)
** https://github.com/Linaro/odp/pull/288
**
From: Dmitry Eremin-Solenikov
Some paths during odp_ipsec_sa_create() can lead to SA leakage. Fix
them by always releasing SA in error case.
Signed-off-by: Dmitry Eremin-Solenikov
---
/** Email created from pull request 288
From: Dmitry Eremin-Solenikov
Add AES-GMAC test vector based on draft-mcgrew-gcm-test-01.
Signed-off-by: Dmitry Eremin-Solenikov
---
/** Email created from pull request 288 (lumag:gmac)
**
This is an example of AES-GMAC(-ESP) implementation. Plaintext is passed as
normal packet, IV/salt are passed according to the rest of API. This
incorporates one commit from #243.
github
/** Email created from pull request 288 (lumag:gmac)
**
From: Dmitry Eremin-Solenikov
Reusing IV block with GCM results in disastrous consequences. Use
counter instead of random-generated IV to remove possibility for IV
reuse.
Signed-off-by: Dmitry Eremin-Solenikov
---
/** Email
Nice to see it working. I think we did not yet tested it with Mellanox
drivers.
For linux-generic refer to .travis.yaml or ./scripts/build-pktio-dpdk
scripts. Also all required steps are in README.
Maxim.
On 11/09/17 14:47, Elo, Matias (Nokia - FI/Espoo) wrote:
> Hi Gyanesh,
>
> Pretty much
Application may need help on inner packet parsing e.g. after decrypt
or IP reassembly of a packet. Application specifies from where
to start and where to stop parsing. Implementation may be
vectorized (more efficient) when multiple packets are parsed
together with the same parse requirements.
Matias Elo(matiaselo) replied on github web page:
platform/linux-generic/pktio/dpdk.c
line 39
@@ -1135,6 +1135,13 @@ static void dpdk_init_capability(pktio_entry_t
*pktio_entry,
rte_eth_dev_info_get(pkt_dpdk->port_id, dev_info);
capa->max_input_queues =
Matias Elo(matiaselo) replied on github web page:
platform/linux-generic/pktio/dpdk.c
line 39
@@ -1135,6 +1135,13 @@ static void dpdk_init_capability(pktio_entry_t
*pktio_entry,
rte_eth_dev_info_get(pkt_dpdk->port_id, dev_info);
capa->max_input_queues =
From: Petri Savolainen
Call ones complement function. Actual validation of
correctness of the sum is to be done, when an implementation
exist which sets the sum on packet input.
Signed-off-by: Petri Savolainen
---
/** Email created from
From: Petri Savolainen
Added dummy implementation of ones complement calls. Linux
generic implementation does not calculate the sum for all
incoming packets as it would be wasteful in SW. It's better
to wait until application asks it with odp_chksum_ones_comp16().
Added packet metadata for ones complement sum over IP
payload in a packet. Some NICs calculate the sum
during packet input (at least for IP fragments) and
store the value into the packet descriptor. This offloads
L4 checksum calculation for IP fragments as SW does not
need sum all payload data,
From: Petri Savolainen
Added validation tests for the new packet parse APIs.
Signed-off-by: Petri Savolainen
---
/** Email created from pull request 273 (psavol:next-packet-parse)
** https://github.com/Linaro/odp/pull/273
** Patch:
From: Petri Savolainen
Implemented new API functions for packet parsing.
Signed-off-by: Petri Savolainen
---
/** Email created from pull request 273 (psavol:next-packet-parse)
** https://github.com/Linaro/odp/pull/273
** Patch:
From: Petri Savolainen
Added packet metadata for ones complement sum over
packet data. Some NICs calculate the sum during packet
input (at least for IP fragments) and store the value
into the packet descriptor. This offloads L4 checksum
calculation for IP fragments
From: Petri Savolainen
Moved parser test packet definitions into a new, common
header file. The same test packets can be used in various
test suites.
Signed-off-by: Petri Savolainen
---
/** Email created from pull request 273
From: Petri Savolainen
Use common values between ipsec parse and
packet protocol layer enums.
Signed-off-by: Petri Savolainen
---
/** Email created from pull request 273 (psavol:next-packet-parse)
**
From: Petri Savolainen
Application may need help on packet parsing e.g. after decrypt
or IP reassembly of a packet. Application specifies from where
to start and where to stop parsing. Implementation may be
vectorized (more efficient) when multiple packets are parsed
From: Petri Savolainen
Use common values between pktio parser layer and
packet protocol layer enums.
Signed-off-by: Petri Savolainen
---
/** Email created from pull request 273 (psavol:next-packet-parse)
**
Application may need help on inner packet parsing e.g. after decrypt
or IP reassembly of a packet. Application specifies from where
to start and where to stop parsing. Implementation may be
vectorized (more efficient) when multiple packets are parsed
together with the same parse requirements.
Hi Gyanesh,
Pretty much the same steps should also work with odp linux-generic. The main
difference is configure script. With linux-generic you use
'--with-dpdk-path=' option and optionally --enable-dpdk-zero-copy
flag. The supported dpdk version is v17.08.
-Matias
> On 9 Nov 2017, at
From: Petri Savolainen
Application may need help on packet parsing e.g. after decrypt
or IP reassembly of a packet. Application specifies from where
to start and where to stop parsing. Implementation may be
vectorized (more efficient) when multiple packets are parsed
From: Petri Savolainen
Added validation tests for the new packet parse APIs.
Signed-off-by: Petri Savolainen
---
/** Email created from pull request 273 (psavol:next-packet-parse)
** https://github.com/Linaro/odp/pull/273
** Patch:
From: Petri Savolainen
Moved parser test packet definitions into a new, common
header file. The same test packets can be used in various
test suites.
Signed-off-by: Petri Savolainen
---
/** Email created from pull request 273
From: Petri Savolainen
Implemented new API functions for packet parsing.
Signed-off-by: Petri Savolainen
---
/** Email created from pull request 273 (psavol:next-packet-parse)
** https://github.com/Linaro/odp/pull/273
** Patch:
From: Petri Savolainen
Use common values between ipsec parse and
packet protocol layer enums.
Signed-off-by: Petri Savolainen
---
/** Email created from pull request 273 (psavol:next-packet-parse)
**
From: Petri Savolainen
Use common values between pktio parser layer and
packet protocol layer enums.
Signed-off-by: Petri Savolainen
---
/** Email created from pull request 273 (psavol:next-packet-parse)
**
Application may need help on inner packet parsing e.g. after decrypt
or IP reassembly of a packet. Application specifies from where
to start and where to stop parsing. Implementation may be
vectorized (more efficient) when multiple packets are parsed
together with the same parse requirements.
bogdanPricope replied on github web page:
include/odp/api/spec/packet.h
line 92
@@ -1140,6 +1179,82 @@ int odp_packet_move_data(odp_packet_t pkt, uint32_t
dst_offset,
*/
/**
+ * Packet parse parameters
+ */
+typedef struct odp_packet_parse_param_t {
+ /** Protocol header at parse
muvarov replied on github web page:
platform/linux-generic/pktio/dpdk.c
line 44
@@ -337,39 +337,62 @@ static struct rte_mempool_ops ops_stack = {
MEMPOOL_REGISTER_OPS(ops_stack);
-#define HAS_IP4_CSUM_FLAG(m, f) ((m->ol_flags & PKT_RX_IP_CKSUM_MASK) == f)
+#define IP4_CSUM_RESULT(m)
bogdanPricope replied on github web page:
platform/linux-generic/pktio/dpdk.c
line 44
@@ -337,39 +337,62 @@ static struct rte_mempool_ops ops_stack = {
MEMPOOL_REGISTER_OPS(ops_stack);
-#define HAS_IP4_CSUM_FLAG(m, f) ((m->ol_flags & PKT_RX_IP_CKSUM_MASK) == f)
+#define IP4_CSUM_RESULT(m)
bogdanPricope replied on github web page:
platform/linux-generic/pktio/dpdk.c
line 44
@@ -337,39 +337,62 @@ static struct rte_mempool_ops ops_stack = {
MEMPOOL_REGISTER_OPS(ops_stack);
-#define HAS_IP4_CSUM_FLAG(m, f) ((m->ol_flags & PKT_RX_IP_CKSUM_MASK) == f)
+#define IP4_CSUM_RESULT(m)
Petri Savolainen(psavol) replied on github web page:
include/odp/api/spec/packet.h
line 59
@@ -1140,6 +1179,82 @@ int odp_packet_move_data(odp_packet_t pkt, uint32_t
dst_offset,
*/
/**
+ * Packet parse parameters
+ */
+typedef struct odp_packet_parse_param_t {
+ /** Protocol header at
bogdanPricope replied on github web page:
include/odp/api/spec/packet.h
line 93
@@ -1140,6 +1179,82 @@ int odp_packet_move_data(odp_packet_t pkt, uint32_t
dst_offset,
*/
/**
+ * Packet parse parameters
+ */
+typedef struct odp_packet_parse_param_t {
+ /** Protocol header at parse
Petri Savolainen(psavol) replied on github web page:
include/odp/api/spec/packet.h
line 74
@@ -1140,6 +1179,82 @@ int odp_packet_move_data(odp_packet_t pkt, uint32_t
dst_offset,
*/
/**
+ * Packet parse parameters
+ */
+typedef struct odp_packet_parse_param_t {
+ /** Protocol header at
Petri Savolainen(psavol) replied on github web page:
include/odp/api/spec/packet.h
line 83
@@ -1140,6 +1179,82 @@ int odp_packet_move_data(odp_packet_t pkt, uint32_t
dst_offset,
*/
/**
+ * Packet parse parameters
+ */
+typedef struct odp_packet_parse_param_t {
+ /** Protocol header at
muvarov replied on github web page:
platform/linux-generic/pktio/dpdk.c
line 5
@@ -1079,7 +1079,7 @@ static int dpdk_input_queues_config(pktio_entry_t
*pktio_entry,
const odp_pktin_queue_param_t *p)
{
odp_pktin_mode_t mode =
Matias Elo(matiaselo) replied on github web page:
platform/linux-generic/pktio/dpdk.c
line 5
@@ -1079,7 +1079,7 @@ static int dpdk_input_queues_config(pktio_entry_t
*pktio_entry,
const odp_pktin_queue_param_t *p)
{
odp_pktin_mode_t mode =
Matias Elo(matiaselo) replied on github web page:
platform/linux-generic/pktio/dpdk.c
line 70
@@ -1372,10 +1382,10 @@ static int dpdk_recv(pktio_entry_t *pktio_entry, int
index,
if (!pkt_dpdk->lockless_rx)
odp_ticketlock_lock(_dpdk->rx_lock[index]);
/**
-*
Matias Elo(matiaselo) replied on github web page:
platform/linux-generic/pktio/dpdk.c
line 70
@@ -1372,10 +1382,10 @@ static int dpdk_recv(pktio_entry_t *pktio_entry, int
index,
if (!pkt_dpdk->lockless_rx)
odp_ticketlock_lock(_dpdk->rx_lock[index]);
/**
-*
From: Bogdan Pricope
Add L3/L4 checksum validation flags to signal if operation was performed
by the platform and its result.
Signed-off-by: Bogdan Pricope
---
/** Email created from pull request 269 (bogdanPricope:api_next_csum_status_pr)
From: Bogdan Pricope
Update odp_generator example application to use L3/L4 checksum
validation status functions.
Signed-off-by: Bogdan Pricope
---
/** Email created from pull request 269 (bogdanPricope:api_next_csum_status_pr)
**
Implement checksum validation status API: add flags, implement API, implement
functionality for dpdk pktio and update odp_generator example application.
github
/** Email created from pull request 269 (bogdanPricope:api_next_csum_status_pr)
**
Hi Maxim,
Thanks for the help. I managed to figure out the configuration error and it
works fine for "ODP-DPDK". The MLX5 pmd was not included properly.
But regarding "ODP" repo (not odp-dpdk), do i need to follow any steps to
be able to use MLX ???
P Gyanesh Kumar Patra
On Wed, Nov 8, 2017 at
83 matches
Mail list logo